Files
InvoiceShelf/tests/Feature/Admin/CustomerTest.php
Darko Gjorgjijoski defbfc6406 Fix CustomerPolicy missing hasCompany() check (IDOR) (#604)
* Fix CustomerPolicy missing hasCompany() check (cross-company IDOR)

Add $user->hasCompany($customer->company_id) check to view, update,
delete, restore, and forceDelete methods in CustomerPolicy, matching
the pattern used by all other policies (InvoicePolicy, PaymentPolicy,
EstimatePolicy, etc.).

Without this check, a user in Company A with view-customer ability
could access customers belonging to Company B by providing the target
customer's ID.

Add cross-company authorization tests to verify the fix.

Closes #565

* Scope bulk delete to current company to prevent cross-company deletion

Filter customer IDs through whereCompany() before passing to
deleteCustomers(), ensuring users cannot delete customers belonging
to other companies via the bulk delete endpoint.
2026-04-03 13:56:34 +02:00

198 lines
4.8 KiB
PHP

<?php
use App\Http\Controllers\V1\Admin\Customer\CustomersController;
use App\Http\Requests\CustomerRequest;
use App\Models\Company;
use App\Models\Customer;
use App\Models\Invoice;
use App\Models\User;
use Illuminate\Support\Facades\Artisan;
use Laravel\Sanctum\Sanctum;
use function Pest\Laravel\getJson;
use function Pest\Laravel\postJson;
use function Pest\Laravel\putJson;
beforeEach(function () {
Artisan::call('db:seed', ['--class' => 'DatabaseSeeder', '--force' => true]);
Artisan::call('db:seed', ['--class' => 'DemoSeeder', '--force' => true]);
$user = User::find(1);
$this->withHeaders([
'company' => $user->companies()->first()->id,
]);
Sanctum::actingAs(
$user,
['*']
);
});
test('get customers', function () {
$response = getJson('api/v1/customers?page=1');
$response->assertOk();
});
test('customer stats', function () {
$customer = Customer::factory()->create();
$invoice = Invoice::factory()->create([
'customer_id' => $customer->id,
]);
$response = getJson("api/v1/customers/{$customer->id}/stats");
$response->assertStatus(200);
});
test('create customer', function () {
$customer = Customer::factory()->raw([
'shipping' => [
'name' => 'newName',
'address_street_1' => 'address',
],
'billing' => [
'name' => 'newName',
'address_street_1' => 'address',
],
]);
postJson('api/v1/customers', $customer)
->assertOk();
$this->assertDatabaseHas('customers', [
'name' => $customer['name'],
'email' => $customer['email'],
]);
});
test('store validates using a form request', function () {
$this->assertActionUsesFormRequest(
CustomersController::class,
'store',
CustomerRequest::class
);
});
test('get customer', function () {
$customer = Customer::factory()->create();
$response = getJson("api/v1/customers/{$customer->id}");
$this->assertDatabaseHas('customers', [
'id' => $customer->id,
'name' => $customer['name'],
'email' => $customer['email'],
]);
$response->assertOk();
});
test('update customer', function () {
$customer = Customer::factory()->create();
$customer1 = Customer::factory()->raw([
'shipping' => [
'name' => 'newName',
'address_street_1' => 'address',
],
'billing' => [
'name' => 'newName',
'address_street_1' => 'address',
],
]);
$response = putJson('api/v1/customers/'.$customer->id, $customer1);
$customer1 = collect($customer1)
->only([
'email',
])
->merge([
'creator_id' => Auth::id(),
])
->toArray();
$response->assertOk();
$this->assertDatabaseHas('customers', $customer1);
});
test('update validates using a form request', function () {
$this->assertActionUsesFormRequest(
CustomersController::class,
'update',
CustomerRequest::class
);
});
test('search customers', function () {
$filters = [
'page' => 1,
'limit' => 15,
'search' => 'doe',
'email' => '.com',
];
$queryString = http_build_query($filters, '', '&');
$response = getJson('api/v1/customers?'.$queryString);
$response->assertOk();
});
test('delete multiple customer', function () {
$customers = Customer::factory()->count(4)->create();
$ids = $customers->pluck('id');
$data = [
'ids' => $ids,
];
$response = postJson('api/v1/customers/delete', $data);
$response
->assertOk()
->assertJson([
'success' => true,
]);
});
test('cannot view customer from another company', function () {
$otherCompany = Company::factory()->create();
$otherCustomer = Customer::factory()->create([
'company_id' => $otherCompany->id,
]);
getJson("api/v1/customers/{$otherCustomer->id}")
->assertForbidden();
});
test('cannot update customer from another company', function () {
$otherCompany = Company::factory()->create();
$otherCustomer = Customer::factory()->create([
'company_id' => $otherCompany->id,
]);
putJson("api/v1/customers/{$otherCustomer->id}", [
'name' => 'Hacked Name',
'email' => 'hacked@example.com',
])->assertForbidden();
});
test('cannot bulk delete customer from another company', function () {
$otherCompany = Company::factory()->create();
$otherCustomer = Customer::factory()->create([
'company_id' => $otherCompany->id,
]);
postJson('api/v1/customers/delete', [
'ids' => [$otherCustomer->id],
])->assertOk();
$this->assertDatabaseHas('customers', [
'id' => $otherCustomer->id,
]);
});