Files
InvoiceShelf/app/Http/Controllers/Company/Members/MembersController.php
Darko Gjorgjijoski 6d1816bd1b refactor: reorganize app/Services and app/Support by domain
The app/Services/ directory had grown into 22 flat files at the root plus 7 uneven subdirectories — finding anything required scrolling through an alphabetical mix of small CRUD services, infrastructure drivers, and install-time utilities. This commit groups services by domain, folds Backup into a new Storage namespace, and moves framework-infrastructure and install-time helpers out of Services and into Support where they belong.

New Services layout: Documents/ (Invoice, Estimate, RecurringInvoice, Payment, Expense, Transaction, DocumentItem, SerialNumber, Currency — matches the 'Documents' navigation group); Company/ (Company, Member, Invitation); Mail/ (MailConfiguration, CompanyMailConfig); Storage/ (FileDisk, plus Backup folded in). ExchangeRateProviderService moves next to its drivers in ExchangeRate/; FontService moves into Pdf/ where it belongs. CustomerService, ItemService, CustomFieldService stay at the Services root as standalone single-file domains.

Moves to Support/: Hashids/ (library wrapper — not business logic); Setup/ (one-shot install-time utilities — stateless helpers); Pdf/ (ImageUtils, PdfTemplateUtils, plus the existing PdfHtmlSanitizer consolidated into the same subdir). These are all framework infrastructure and stateless utilities — the 'service' label never really fit them.

Namespace declarations in 29 moved files updated to match new paths. 62 consumer files (controllers, other services, tests, database factories, seeders, routes, bootstrap/providers.php) have their use statements rewritten via a literal-string replacement script — no regex meant no risk of half-matching. Three Documents services needed an explicit 'use App\Services\Mail\CompanyMailConfigService' added because the same-namespace short reference they relied on no longer resolves after the split.

Verified: composer dump-autoload, 350 tests pass (850 assertions), vendor/bin/pint clean, npm run build succeeds.
2026-04-11 10:00:00 +02:00

104 lines
2.4 KiB
PHP

<?php
namespace App\Http\Controllers\Company\Members;
use App\Http\Controllers\Controller;
use App\Http\Requests\DeleteMemberRequest;
use App\Http\Requests\MemberRequest;
use App\Http\Resources\UserResource;
use App\Models\User;
use App\Services\Company\MemberService;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
class MembersController extends Controller
{
public function __construct(
private readonly MemberService $memberService,
) {}
/**
* Display a listing of the resource.
*
* @return JsonResponse
*/
public function index(Request $request)
{
$this->authorize('viewAny', User::class);
$limit = $request->has('limit') ? $request->limit : 10;
$user = $request->user();
$users = User::whereCompany()
->applyFilters($request->all())
->where('id', '<>', $user->id)
->latest()
->paginate($limit);
return UserResource::collection($users)
->additional(['meta' => [
'user_total_count' => User::whereCompany()->count(),
]]);
}
/**
* Store a newly created resource in storage.
*
* @return JsonResponse
*/
public function store(MemberRequest $request)
{
$this->authorize('create', User::class);
$user = $this->memberService->create($request);
return new UserResource($user);
}
/**
* Display the specified resource.
*
* @return JsonResponse
*/
public function show(User $user)
{
$this->authorize('view', $user);
return new UserResource($user);
}
/**
* Update the specified resource in storage.
*
* @return JsonResponse
*/
public function update(MemberRequest $request, User $user)
{
$this->authorize('update', $user);
$this->memberService->update($user, $request);
return new UserResource($user);
}
/**
* Display a listing of the resource.
*
* @param Request $request
* @return JsonResponse
*/
public function delete(DeleteMemberRequest $request)
{
$this->authorize('delete multiple users', User::class);
if ($request->users) {
$this->memberService->delete($request->users);
}
return response()->json([
'success' => true,
]);
}
}