mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-08-04 07:02:13 +00:00
05e8acc3b1
Only invoices and estimates could be customised. Payment receipts and all five
reports were hardcoded to app.pdf.*, so changing them meant editing files inside
the image -- and losing the edit on the next upgrade.
Those documents have no template picker and no design to choose between, so
overriding one is not a selection: it is a same-named file in
storage/app/templates/pdf/{type}/ winning over the built-in. PdfTemplateUtils::
resolveView() is that rule, and it needs no setting, no column and no UI.
resolveView asks View::exists rather than checking the storage disk. The disk and
the view namespace are registered separately and could disagree about where
custom templates live; asking the thing that will actually render removes that
possibility.
make:template covers the new types. Their names are not free, since an override
replaces one specific document, so it validates against the real list -- 'payment'
for payments, and the five report names -- and reports what is available when the
name is wrong. Neither type gets a preview image written, having no picker to
show one in.
The payment preview route also went through the built-in view directly rather
than the service, so ?preview ignored an override and rendered with none of the
shared data. It goes through the service now, like invoices and estimates.
Claude-Session: https://claude.ai/code/session_01QmECndmNZwzN65Zz9P87dF
53 lines
1.6 KiB
PHP
53 lines
1.6 KiB
PHP
<?php
|
|
|
|
namespace App\Http\Controllers\Pdf;
|
|
|
|
use App\Http\Controllers\Controller;
|
|
use App\Models\Estimate;
|
|
use App\Models\Invoice;
|
|
use App\Models\Payment;
|
|
use App\Services\Document\EstimateService;
|
|
use App\Services\Document\InvoiceService;
|
|
use App\Services\Document\PaymentService;
|
|
use Illuminate\Http\Request;
|
|
|
|
class DocumentPdfController extends Controller
|
|
{
|
|
public function __construct(
|
|
private readonly InvoiceService $invoiceService,
|
|
private readonly EstimateService $estimateService,
|
|
private readonly PaymentService $paymentService,
|
|
) {}
|
|
|
|
public function invoice(Request $request, Invoice $invoice)
|
|
{
|
|
if ($request->has('preview')) {
|
|
return $this->invoiceService->getPdfData($invoice);
|
|
}
|
|
|
|
return $invoice->getGeneratedPDFOrStream('invoice');
|
|
}
|
|
|
|
public function estimate(Request $request, Estimate $estimate)
|
|
{
|
|
if ($request->has('preview')) {
|
|
return $this->estimateService->getPdfData($estimate);
|
|
}
|
|
|
|
return $estimate->getGeneratedPDFOrStream('estimate');
|
|
}
|
|
|
|
public function payment(Request $request, Payment $payment)
|
|
{
|
|
if ($request->has('preview')) {
|
|
// Through the service, so the preview gets the same shared data and
|
|
// the same custom-override resolution as the rendered receipt. This
|
|
// used to name the built-in view directly, so a preview ignored an
|
|
// override and rendered with no data at all.
|
|
return $this->paymentService->getPdfData($payment);
|
|
}
|
|
|
|
return $payment->getGeneratedPDFOrStream('payment');
|
|
}
|
|
}
|