feat: remove more actions button in datatables.

2026-02-15 12:20:31 +00:00 · 2021-04-19 18:23:11 +02:00
parent 537150b222
commit c6aca4ecfa
24 changed files with 95 additions and 74 deletions
--- a/client/src/containers/Accounting/JournalsLanding/utils.js
+++ b/client/src/containers/Accounting/JournalsLanding/utils.js
@@ -6,7 +6,6 @@ import {
  StatusAccessor,
  DateAccessor,
  AmountAccessor,
-  ActionsCell,
 } from './components';

 /**
@@ -65,14 +64,6 @@ export const useManualJournalsColumns = () => {
        width: 125,
        className: 'created_at',
      },
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
    ],
    [],
  );
--- a/client/src/containers/Accounting/MakeJournal/utils.js
+++ b/client/src/containers/Accounting/MakeJournal/utils.js
@@ -125,19 +125,20 @@ export const transformErrors = (resErrors, { setErrors, errors }) => {
    setEntriesErrors(error.indexes, 'contact_id', 'error');
  }
  if ((error = getError(ERROR.ENTRIES_SHOULD_ASSIGN_WITH_CONTACT))) {
-    if (error.meta.contact_type === 'customer') {
+    if (error.meta.find(meta => meta.contact_type === 'customer')) {
      toastMessages.push(
        formatMessage({
          id: 'receivable_accounts_should_assign_with_customers',
        }),
      );
    }
-    if (error.meta.contact_type === 'vendor') {
+    if (error.meta.find(meta => meta.contact_type === 'vendor')) {
      toastMessages.push(
        formatMessage({ id: 'payable_accounts_should_assign_with_vendors' }),
      );
    }
-    setEntriesErrors(error.meta.indexes, 'contact_id', 'error');
+    const indexes = error.meta.map((meta => meta.indexes)).flat();
+    setEntriesErrors(indexes, 'contact_id', 'error');
  }
  if ((error = getError(ERROR.JOURNAL_NUMBER_ALREADY_EXISTS))) {
    newErrors = setWith(
@@ -153,7 +154,7 @@ export const transformErrors = (resErrors, { setErrors, errors }) => {
  if (toastMessages.length > 0) {
    AppToaster.show({
      message: toastMessages.map((message) => {
-        return <div>- {message}</div>;
+        return <div>{message}</div>;
      }),
      intent: Intent.DANGER,
    });
--- a/client/src/containers/Purchases/Bills/BillsLanding/components.js
+++ b/client/src/containers/Purchases/Bills/BillsLanding/components.js
@@ -201,14 +201,6 @@ export function useBillsTableColumns() {
        width: 90,
        className: 'reference_no',
      },
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
    ],
    [formatMessage],
  );
--- a/client/src/containers/Purchases/PaymentMades/PaymentsLanding/components.js
+++ b/client/src/containers/Purchases/PaymentMades/PaymentsLanding/components.js
@@ -118,15 +118,6 @@ export function usePaymentMadesTableColumns() {
        width: 140,
        className: 'reference',
      },
-
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
    ],
    [formatMessage],
  );
--- a/client/src/containers/Sales/Estimates/EstimatesLanding/components.js
+++ b/client/src/containers/Sales/Estimates/EstimatesLanding/components.js
@@ -203,15 +203,7 @@ export function useEstiamtesTableColumns() {
        accessor: 'reference',
        width: 90,
        className: 'reference',
-      },
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
+      }
    ],
    [formatMessage],
  );
--- a/client/src/containers/Sales/Invoices/InvoicesLanding/components.js
+++ b/client/src/containers/Sales/Invoices/InvoicesLanding/components.js
@@ -221,14 +221,6 @@ export function useInvoicesTableColumns() {
        width: 90,
        className: 'reference_no',
      },
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
    ],
    [formatMessage],
  );
--- a/client/src/containers/Sales/PaymentReceives/PaymentsLanding/components.js
+++ b/client/src/containers/Sales/PaymentReceives/PaymentsLanding/components.js
@@ -127,15 +127,7 @@ export function usePaymentReceivesColumns() {
        accessor: 'reference_no',
        width: 140,
        className: 'reference_no',
-      },
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
+      }
    ],
    [formatMessage],
  );
--- a/client/src/containers/Sales/Receipts/ReceiptsLanding/components.js
+++ b/client/src/containers/Sales/Receipts/ReceiptsLanding/components.js
@@ -146,14 +146,6 @@ export function useReceiptsTableColumns() {
        width: 140,
        className: 'reference_no',
      },
-      {
-        id: 'actions',
-        Header: '',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 50,
-        disableResizing: true,
-      },
    ],
    [formatMessage],
  );
--- a/client/src/containers/Vendors/VendorsLanding/components.js
+++ b/client/src/containers/Vendors/VendorsLanding/components.js
@@ -127,15 +127,7 @@ export function useVendorsTableColumns() {
        accessor: BalanceAccessor,
        className: 'receivable_balance',
        width: 100,
-      },
-      {
-        id: 'actions',
-        Cell: ActionsCell,
-        className: 'actions',
-        width: 70,
-        disableResizing: true,
-        disableSortBy: true,
-      },
+      }
    ],
    [formatMessage],
  );
--- a/client/src/style/components/DataTable/DataTableEditable.scss
+++ b/client/src/style/components/DataTable/DataTableEditable.scss
@@ -30,7 +30,6 @@
        padding: 10px 10px;
        background-color: #f0f2f8;
        font-size: 14px;
-        font-weight: 500;
        color: #415060;
        border-bottom: 1px solid #d2dce2;

--- a/client/src/style/pages/Bills/List.scss
+++ b/client/src/style/pages/Bills/List.scss
@@ -1,6 +1,9 @@
 .dashboard__insider--bills {
  .bigcapital-datatable {
    .tbody {
+      .tr {
+        min-height: 50px;
+      }
      .td.amount {
        .cell-inner {
          > span {
--- a/client/src/style/pages/Customers/List.scss
+++ b/client/src/style/pages/Customers/List.scss
@@ -4,6 +4,11 @@

  .bigcapital-datatable{

+    .tr .td{
+      padding-top: 0.6rem;
+      padding-bottom: 0.6rem;
+    }
+
    .avatar.td{

      .avatar{
--- a/client/src/style/pages/Expense/List.scss
+++ b/client/src/style/pages/Expense/List.scss
@@ -5,6 +5,10 @@
  .bigcapital-datatable {
    .table {
      .tbody {
+
+        .tr{
+          min-height: 50px;
+        }
        .td.amount {
          span {
            font-weight: 600;
--- a/client/src/style/pages/InventoryAdjustments/List.scss
+++ b/client/src/style/pages/InventoryAdjustments/List.scss
@@ -0,0 +1,15 @@
+
+// Blueprint framework.
+// @import '@blueprintjs/core/src/blueprint.scss';
+
+.dashboard__insider--inventory_adjustments {
+  .bigcapital-datatable {
+    .table {
+      .tbody {
+        .tr{
+          min-height: 50px;
+        }
+      }
+    }
+  }
+}
--- a/client/src/style/pages/Items/List.scss
+++ b/client/src/style/pages/Items/List.scss
@@ -6,6 +6,9 @@
  .bigcapital-datatable {
    .table {
      .tbody {
+        .tr{
+          min-height: 50px;
+        }
        .item_type.td {
          .bp3-tag {
            font-size: 13px;
--- a/client/src/style/pages/ItemsCategories/List.scss
+++ b/client/src/style/pages/ItemsCategories/List.scss
@@ -0,0 +1,14 @@
+
+
+.dashboard__insider--items-categories-list{
+
+  .bigcapital-datatable {
+    .table {
+      .tbody {
+        .tr{
+          min-height: 50px;
+        }
+      }
+    }
+  }
+}
--- a/client/src/style/pages/ManualJournal/List.scss
+++ b/client/src/style/pages/ManualJournal/List.scss
@@ -4,6 +4,9 @@
    }

    .tbody {
+      .tr .td{
+        padding: 0.8rem 0.5rem;
+      }
      .td.amount {
        .bp3-popover-target {
          border-bottom: 1px solid #e7e7e7;
--- a/client/src/style/pages/PaymentMade/List.scss
+++ b/client/src/style/pages/PaymentMade/List.scss
@@ -4,6 +4,9 @@
  .bigcapital-datatable{

    .tbody{
+      .tr{
+        min-height: 50px;
+      }

      .td.amount {

--- a/client/src/style/pages/PaymentReceive/List.scss
+++ b/client/src/style/pages/PaymentReceive/List.scss
@@ -4,6 +4,9 @@
  .bigcapital-datatable{

    .tbody{
+      .tr .td{
+        min-height: 50px;
+      }

      .td.amount {

--- a/client/src/style/pages/SaleEstimate/List.scss
+++ b/client/src/style/pages/SaleEstimate/List.scss
@@ -5,6 +5,11 @@

    .tbody{

+      .tr .td{
+        padding-top: 0.88rem;
+        padding-bottom: 0.88rem;
+      }
+
      .td.amount {

        .cell-inner{
--- a/client/src/style/pages/SaleInvoice/List.scss
+++ b/client/src/style/pages/SaleInvoice/List.scss
@@ -7,6 +7,9 @@


    .tbody{
+      .tr{
+        min-height: 50px;
+      }
      .balance.td{

        .cell-inner{
--- a/client/src/style/pages/SaleReceipt/List.scss
+++ b/client/src/style/pages/SaleReceipt/List.scss
@@ -5,6 +5,10 @@

    .tbody{

+      .tr .td{
+        min-height: 50px;
+      }
+
      .td.amount {

        .cell-inner{
--- a/client/src/style/pages/Vendors/List.scss
+++ b/client/src/style/pages/Vendors/List.scss
@@ -2,6 +2,13 @@

    .bigcapital-datatable {

+        tbody {
+            .tr .td {
+                padding-top: 0.6rem;
+                padding-bottom: 0.6rem;
+            }
+        }
+
        .avatar.td {

            .avatar {
--- a/client/src/style/pages/authentication.scss
+++ b/client/src/style/pages/authentication.scss
@@ -0,0 +1,15 @@
+
+// Blueprint framework.
+// @import '@blueprintjs/core/src/blueprint.scss';
+
+.dashboard__insider--inventory-adjustments-list {
+  .bigcapital-datatable {
+    .table {
+      .tbody {
+        .tr .td{
+          padding: 0.88rem 0.5rem;
+        }
+      }
+    }
+  }
+}