fix(server): sending invite email

CONTRIBUTING.md

@@ -34,7 +34,7 @@ Contributions via pull requests are much appreciated. Once the approach is agree
 ## Contribute to Backend
 
 - Clone the `bigcapital` repository and `cd` into `bigcapital` directory.
-- Install all npm dependencies of the monorepo, you don't have to change directory to the `backend` package. just hit the command on root directory and it will install dependencies of all packages.
+- Install all npm dependencies of the monorepo, you don't have to change directory to the `backend` package. just hit these command on root directory and it will install dependencies of all packages.
 
 ```
 npm install
@@ -47,7 +47,7 @@ npm run bootstrap
 docker-compose up -d
 ```
 
-Wait some seconds, and hit `docker-compose ps` to see the result and you should see the same result below.
+Wait some seconds, and hit `docker-compose ps` and you should see the same result below.
 
 ```
 CONTAINER ID   IMAGE              COMMAND                  CREATED         STATUS        PORTS                               NAMES
@@ -122,7 +122,7 @@ There are many other ways to get involved with the community and to participate
 - Use the product, submitting GitHub issues when a problem is found.
 - Help code review pull requests and participate in issue threads.
 - Submit a new feature request as an issue.
-- Help answer questions on forums such as Stack Overflow and SigNoz Community Slack Channel.
+- Help answer questions on forums such as Bigcapital Community Discord Channel.
 - Tell others about the project on Twitter, your blog, etc.
 
 **[`^top^`](#)**

packages/server/src/before.ts

@@ -4,6 +4,7 @@ import moment from 'moment';
 global.__root_dir = path.join(__dirname, '..');
 global.__resources_dir = path.join(global.__root_dir, 'resources');
 global.__locales_dir = path.join(global.__resources_dir, 'locales');
+global.__views_dir = path.join(global.__root_dir, 'views');
 
 moment.prototype.toMySqlDateTime = function () {
   return this.format('YYYY-MM-DD HH:mm:ss');

packages/server/src/interfaces/User.ts

@@ -1,6 +1,7 @@
 import { AnyObject } from '@casl/ability/dist/types/types';
 import { ITenant } from '@/interfaces';
 import { Model } from 'objection';
+import { Tenant } from '@/system/models';
 
 export interface ISystemUser extends Model {
   id: number;
@@ -54,20 +55,52 @@ export interface IUserInvite {
 
 export interface IInviteUserService {
   acceptInvite(token: string, inviteUserInput: IInviteUserInput): Promise<void>;
+
+  /**
+   * Re-send user invite.
+   * @param {number} tenantId -
+   * @param {string} email    -
+   * @return {Promise<{ invite: IUserInvite }>}
+   */
   resendInvite(
     tenantId: number,
     userId: number,
     authorizedUser: ISystemUser
   ): Promise<{
-    invite: IUserInvite;
+    user: ITenantUser;
   }>;
+
+  /**
+   * Sends invite mail to the given email from the given tenant and user.
+   * @param {number} tenantId -
+   * @param {string} email -
+   * @param {IUser} authorizedUser -
+   * @return {Promise<IUserInvite>}
+   */
   sendInvite(
     tenantId: number,
-    email: string,
+    sendInviteDTO: IUserSendInviteDTO,
     authorizedUser: ISystemUser
   ): Promise<{
-    invite: IUserInvite;
+    invitedUser: ITenantUser;
   }>;
+}
+
+export interface IAcceptInviteUserService {
+  /**
+   * Accept the received invite.
+   * @param {string} token
+   * @param {IInviteUserInput} inviteUserInput
+   * @throws {ServiceErrors}
+   * @returns {Promise<void>}
+   */
+  acceptInvite(token: string, inviteUserDTO: IInviteUserInput): Promise<void>;
+
+  /**
+   * Validate the given invite token.
+   * @param {string} token - the given token string.
+   * @throws {ServiceError}
+   */
   checkInvite(
     token: string
   ): Promise<{ inviteToken: IUserInvite; orgName: object }>;
@@ -121,7 +154,7 @@ export interface IUserInvitedEventPayload {
   tenantId: number;
   user: ITenantUser;
 }
-export interface IUserInviteTenantSyncedEventPayload{
+export interface IUserInviteTenantSyncedEventPayload {
   invite: IUserInvite;
   authorizedUser: ISystemUser;
   tenantId: number;
@@ -143,10 +176,10 @@ export interface IAcceptInviteEventPayload {
 
 export interface ICheckInviteEventPayload {
   inviteToken: IUserInvite;
-  tenant: ITenant
+  tenant: Tenant;
 }
 
 export interface IUserSendInviteDTO {
   email: string;
   roleId: number;
-}
+}

packages/server/src/jobs/UserInviteMail.ts

@@ -1,5 +1,6 @@
 import { Container, Inject } from 'typedi';
 import InviteUserService from '@/services/InviteUsers/AcceptInviteUser';
+import SendInviteUsersMailMessage from '@/services/InviteUsers/SendInviteUsersMailMessage';
 
 export default class UserInviteMailJob {
   /**
@@ -21,24 +22,17 @@ export default class UserInviteMailJob {
    */
   public async handler(job, done: Function): Promise<void> {
     const { invite, authorizedUser, tenantId } = job.attrs.data;
-
-    const Logger = Container.get('logger');
-    const inviteUsersService = Container.get(InviteUserService);
-
-    Logger.info(`Send invite user mail - started: ${job.attrs.data}`);
+    const sendInviteMailMessage = Container.get(SendInviteUsersMailMessage);
 
     try {
-      await inviteUsersService.mailMessages.sendInviteMail(
+      await sendInviteMailMessage.sendInviteMail(
         tenantId,
         authorizedUser,
         invite
       );
-      Logger.info(`Send invite user mail - finished: ${job.attrs.data}`);
       done();
     } catch (error) {
-      Logger.info(
-        `Send invite user mail - error: ${job.attrs.data}, error: ${error}`
-      );
+      console.log(error);
       done(error);
     }
   }

packages/server/src/lib/Mail/index.ts

@@ -109,7 +109,7 @@ export default class Mail {
    * Retrieve view content from the view directory.
    */
   private getViewContent(): string {
-    const filePath = path.join(global.__root_dir, `../views/${this.view}`);
+    const filePath = path.join(global.__views_dir, `/${this.view}`);
     return fs.readFileSync(filePath, 'utf8');
   }
 }

packages/server/src/loaders/eventEmitter.ts

@@ -22,7 +22,7 @@ import SaleInvoiceAutoIncrementSubscriber from '@/subscribers/SaleInvoices/AutoI
 import SaleInvoiceConvertFromEstimateSubscriber from '@/subscribers/SaleInvoices/ConvertFromEstimate';
 import PaymentReceiveAutoSerialSubscriber from '@/subscribers/PaymentReceive/AutoSerialIncrement';
 import SyncSystemSendInvite from '@/services/InviteUsers/SyncSystemSendInvite';
-import InviteSendMainNotification from '@/services/InviteUsers/InviteSendMailNotification';
+import InviteSendMainNotification from '@/services/InviteUsers/InviteSendMailNotificationSubscribe';
 import SyncTenantAcceptInvite from '@/services/InviteUsers/SyncTenantAcceptInvite';
 import SyncTenantUserMutate from '@/services/Users/SyncTenantUserSaved';
 import { SyncTenantUserDelete } from '@/services/Users/SyncTenantUserDeleted';

packages/server/src/services/InviteUsers/AcceptInviteUser.ts

@@ -12,9 +12,12 @@ import {
 } from '@/interfaces';
 import { ERRORS } from './constants';
 import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
+import { IAcceptInviteUserService } from '@/interfaces';
 
 @Service()
-export default class AcceptInviteUserService {
+export default class AcceptInviteUserService
+  implements IAcceptInviteUserService
+{
   @Inject()
   private eventPublisher: EventPublisher;
 

packages/server/src/services/InviteUsers/InviteSendMailNotificationSubscribe.ts

@@ -1,7 +1,4 @@
-import {
-  IUserInvitedEventPayload,
-  IUserInviteTenantSyncedEventPayload,
-} from '@/interfaces';
+import { IUserInviteTenantSyncedEventPayload } from '@/interfaces';
 import events from '@/subscribers/events';
 import { Inject, Service } from 'typedi';
 

packages/server/src/services/InviteUsers/SendInviteUsersMailMessage.ts

@@ -1,12 +1,12 @@
+import path from 'path';
 import { ISystemUser } from '@/interfaces';
-import TenancyService from '@/services/Tenancy/TenancyService';
 import Mail from '@/lib/Mail';
-import { Service, Container } from 'typedi';
-import config from '@/config';
+import { Service } from 'typedi';
 import { Tenant } from '@/system/models';
+import config from '@/config';
 
 @Service()
-export default class InviteUsersMailMessages {
+export default class SendInviteUsersMailMessage {
   /**
    * Sends invite mail to the given email.
    * @param user
@@ -18,7 +18,7 @@ export default class InviteUsersMailMessages {
       .findById(tenantId)
       .withGraphFetched('metadata');
 
-    const root = __dirname + '/../../../views/images/bigcapital.png';
+    const root = path.join(global.__views_dir, '/images/bigcapital.png');
 
     const mail = new Mail()
       .setSubject(`${fromUser.firstName} has invited you to join a Bigcapital`)

packages/server/src/services/InviteUsers/SyncTenantAcceptInvite.ts

@@ -8,7 +8,7 @@ import { IAcceptInviteEventPayload } from '@/interfaces';
 @Service()
 export default class SyncTenantAcceptInvite {
   @Inject()
-  tenancy: HasTenancyService;
+  private tenancy: HasTenancyService;
 
   /**
    * Attaches events with handlers.

packages/server/src/services/InviteUsers/TenantInviteUser.ts

@@ -74,17 +74,15 @@ export default class InviteTenantUserService implements IInviteUserService {
 
   /**
    * Re-send user invite.
-   * @param  {number} tenantId -
-   * @param  {string} email    -
+   * @param {number} tenantId -
+   * @param {string} email -
    * @return {Promise<{ invite: IUserInvite }>}
    */
   public async resendInvite(
     tenantId: number,
     userId: number,
     authorizedUser: ISystemUser
-  ): Promise<{
-    user: ITenantUser;
-  }> {
+  ): Promise<{ user: ITenantUser }> {
     // Retrieve the user by id or throw not found service error.
     const user = await this.getUserByIdOrThrowError(tenantId, userId);