chore: update mysql docker container restart policy

.all-contributorsrc

@@ -42,24 +42,6 @@
       "contributions": [
         "bug"
       ]
-    },
-    {
-      "login": "suhaibaffan",
-      "name": "Suhaib Affan",
-      "avatar_url": "https://avatars.githubusercontent.com/u/18115937?v=4",
-      "profile": "https://github.com/suhaibaffan",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "KalliopiPliogka",
-      "name": "Kalliopi Pliogka",
-      "avatar_url": "https://avatars.githubusercontent.com/u/81677549?v=4",
-      "profile": "https://github.com/KalliopiPliogka",
-      "contributions": [
-        "bug"
-      ]
     }
   ],
   "contributorsPerLine": 7,

.env.example

@@ -47,6 +47,3 @@ AGENDASH_AUTH_PASSWORD=123123
 SIGNUP_DISABLED=false
 SIGNUP_ALLOWED_DOMAINS=
 SIGNUP_ALLOWED_EMAILS=
-
-# API rate limit (points,duration,block duration).
-API_RATE_LIMIT=120,60,600

CHANGELOG.md

@@ -2,17 +2,6 @@
 
 All notable changes to Bigcapital server-side will be in this file.
 
-# [0.9.11] - 23-07-2023
-
-* added: Restart policy to docker compose files. by @suhaibaffan in https://github.com/bigcapitalhq/bigcapital/pull/198
-* fix: Expose and expand the rate limit to the env variables by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/195
-
-# [0.9.10] - 18-07-2023
-
-* feat(e2e): E2E onboarding process by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/176
-* fix(webapp): Show loading message of cost computing job on financial reports by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/196
-* fix(webapp): Change the currency code of sales and purchases transactions with foreign contacts. 
-
 # [0.9.9] - 28-06-2023
 
 * refactor: Customer and vendor select component by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/171
@@ -97,7 +86,7 @@ All notable changes to Bigcapital server-side will be in this file.
 - fix: delete invoice transaction issue.
 
 `@bigcapital/webapp`
-- fix: general, accountant and items preferences.
+- fix: general, accoutant and items preferences.
 - fix: auto-increment sale invoices, estiamtes, credit notes, payments and manual journals.
 - refactor: the setup organization form to use binded Formik components.
 

CONTRIBUTING.md

@@ -7,7 +7,6 @@ Please read through this document before submitting any issues or pull requests
 ## Sections
 
 - [General Instructions](#general-instructions)
-- [Local Setup Prerequisites](#local-setup-prerequisites)
 - [Contribute to Backend](#contribute-to-backend)
 - [Contribute to Frontend](#contribute-to-frontend)
 - [Other Ways to Contribute](#other-ways-to-contribute)
@@ -32,18 +31,9 @@ Contributions via pull requests are much appreciated. Once the approach is agree
 
 ---
 
-## Local Setup Prerequisites
- - The application currently supports **Node.js v14.x**. Please ensure that you are using this version of Node.js when developing. (use [nvm](https://github.com/nvm-sh/nvm#installing-and-updating) to switch between node versions)
-
 ## Contribute to Backend
 
 - Clone the `bigcapital` repository and `cd` into `bigcapital` directory.
-- Create `.env` file by copying `.env.example` file to `.env`. (The ``.env.example`` file has all the necessary values of variables to start development directly).
-
-```
-cp .env.example .env
-```
-
 - Install all npm dependencies of the monorepo, you don't have to change directory to the `backend` package. just hit these command on root directory and it will install dependencies of all packages.
 
 ```

README.md

@@ -69,11 +69,9 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
   <tbody>
     <tr>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/abouolia"><img src="https://avatars.githubusercontent.com/u/2197422?v=4?s=100" width="100px;" alt="Ahmed Bouhuolia"/><br /><sub><b>Ahmed Bouhuolia</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/commits?author=abouolia" title="Code">💻</a></td>
-      <td align="center" valign="top" width="14.28%"><a href="http://ameir.net"><img src="https://avatars.githubusercontent.com/u/374330?v=4?s=100" width="100px;" alt="Ameir Abdeldayem"/><br /><sub><b>Ameir Abdeldayem</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Aameir" title="Bug reports">🐛</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/elforjani13"><img src="https://avatars.githubusercontent.com/u/39470382?v=4?s=100" width="100px;" alt="ElforJani13"/><br /><sub><b>ElforJani13</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/commits?author=elforjani13" title="Code">💻</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="http://ameir.net"><img src="https://avatars.githubusercontent.com/u/374330?v=4?s=100" width="100px;" alt="Ameir Abdeldayem"/><br /><sub><b>Ameir Abdeldayem</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Aameir" title="Bug reports">🐛</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://scheibling.se"><img src="https://avatars.githubusercontent.com/u/24367830?v=4?s=100" width="100px;" alt="Lars Scheibling"/><br /><sub><b>Lars Scheibling</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Ascheibling" title="Bug reports">🐛</a></td>
-      <td align="center" valign="top" width="14.28%"><a href="https://github.com/suhaibaffan"><img src="https://avatars.githubusercontent.com/u/18115937?v=4?s=100" width="100px;" alt="Suhaib Affan"/><br /><sub><b>Suhaib Affan</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/commits?author=suhaibaffan" title="Code">💻</a></td>
-      <td align="center" valign="top" width="14.28%"><a href="https://github.com/KalliopiPliogka"><img src="https://avatars.githubusercontent.com/u/81677549?v=4?s=100" width="100px;" alt="Kalliopi Pliogka"/><br /><sub><b>Kalliopi Pliogka</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3AKalliopiPliogka" title="Bug reports">🐛</a></td>
     </tr>
   </tbody>
 </table>

e2e/items.spec.ts

@@ -1,7 +0,0 @@
-import { test, expect, Page } from '@playwright/test';
-
-test.describe('item', () => {
-  test('should validate all required fields.', () => {});
-  test('should save the item successfully.', () => {});
-  test('should item code be unqiue.', () => {});
-});

packages/server/resources/locales/ar.json

@@ -152,7 +152,7 @@
   "Opening Balance Liabilities": "رصيد الالتزامات الافتتاحي",
   "Loan": "اقراض",
   "Owner A Drawings": "مسحوبات المالك",
-  "An account that holds valuation of products or goods that available for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",
+  "An account that holds valuation of products or goods that availiable for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",
   "Tracks the gain and losses of the exchange differences.": "يسجل مكاسب وخسائر فروق الصرف.",
   "Any bank fees levied is recorded into the bank fees and charges account. A bank account maintenance fee, transaction charges, a late payment fee are some examples.": "يتم تسجيل أي رسوم مصرفية يتم فرضها في حساب الرسوم والمصروفات البنكية. ومن الأمثلة على ذلك رسوم صيانة الحساب المصرفي ورسوم المعاملات ورسوم الدفع المتأخر.",
   "The income activities are not associated to the core business.": "لا ترتبط انشطة الدخل إلى الأعمال الأساسية.",

packages/server/resources/locales/en.json

@@ -151,7 +151,7 @@
   "Opening Balance Liabilities": "Opening Balance Liabilities",
   "Loan": "Loan",
   "Owner A Drawings": "Owner A Drawings",
-  "An account that holds valuation of products or goods that available for sale.": "An account that holds valuation of products or goods that available for sale.",
+  "An account that holds valuation of products or goods that availiable for sale.": "An account that holds valuation of products or goods that availiable for sale.",
   "Tracks the gain and losses of the exchange differences.": "Tracks the gain and losses of the exchange differences.",
   "Any bank fees levied is recorded into the bank fees and charges account. A bank account maintenance fee, transaction charges, a late payment fee are some examples.": "Any bank fees levied is recorded into the bank fees and charges account. A bank account maintenance fee, transaction charges, a late payment fee are some examples.",
   "The income activities are not associated to the core business.": "The income activities are not associated to the core business.",

packages/server/src/api/controllers/FinancialStatements/APAgingSummary.ts

@@ -33,13 +33,10 @@ export default class APAgingSummaryReportController extends BaseFinancialReportC
     return [
       ...this.sheetNumberFormatValidationSchema,
       query('as_date').optional().isISO8601(),
-
-      query('aging_days_before').default(30).isInt({ max: 500 }).toInt(),
-      query('aging_periods').default(3).isInt({ max: 12 }).toInt(),
-
+      query('aging_days_before').optional().isNumeric().toInt(),
+      query('aging_periods').optional().isNumeric().toInt(),
       query('vendors_ids').optional().isArray({ min: 1 }),
       query('vendors_ids.*').isInt({ min: 1 }).toInt(),
-
       query('none_zero').default(true).isBoolean().toBoolean(),
 
       // Filtering by branches.
@@ -56,36 +53,15 @@ export default class APAgingSummaryReportController extends BaseFinancialReportC
     const filter = this.matchedQueryData(req);
 
     try {
-      const accept = this.accepts(req);
-      const acceptType = accept.types(['json', 'application/json+table']);
+      const { data, columns, query, meta } =
+        await this.APAgingSummaryService.APAgingSummary(tenantId, filter);
 
-      switch (acceptType) {
-        case 'application/json+table':
-          const table = await this.APAgingSummaryService.APAgingSummaryTable(
-            tenantId,
-            filter
-          );
-          return res.status(200).send({
-            table: {
-              rows: table.rows,
-              columns: table.columns,
-            },
-            meta: table.meta,
-            query: table.query,
-          });
-          break;
-        default:
-          const { data, columns, query, meta } =
-            await this.APAgingSummaryService.APAgingSummary(tenantId, filter);
-
-          return res.status(200).send({
-            data: this.transfromToResponse(data),
-            columns: this.transfromToResponse(columns),
-            query: this.transfromToResponse(query),
-            meta: this.transfromToResponse(meta),
-          });
-          break;
-      }
+      return res.status(200).send({
+        data: this.transfromToResponse(data),
+        columns: this.transfromToResponse(columns),
+        query: this.transfromToResponse(query),
+        meta: this.transfromToResponse(meta),
+      });
     } catch (error) {
       next(error);
     }

packages/server/src/api/controllers/FinancialStatements/ARAgingSummary.ts

@@ -36,8 +36,8 @@ export default class ARAgingSummaryReportController extends BaseFinancialReportC
 
       query('as_date').optional().isISO8601(),
 
-      query('aging_days_before').default(30).isInt({ max: 500 }).toInt(),
-      query('aging_periods').default(3).isInt({ max: 12 }).toInt(),
+      query('aging_days_before').optional().isInt({ max: 500 }).toInt(),
+      query('aging_periods').optional().isInt({ max: 12 }).toInt(),
 
       query('customers_ids').optional().isArray({ min: 1 }),
       query('customers_ids.*').isInt({ min: 1 }).toInt(),
@@ -58,36 +58,15 @@ export default class ARAgingSummaryReportController extends BaseFinancialReportC
     const filter = this.matchedQueryData(req);
 
     try {
-      const accept = this.accepts(req);
-      const acceptType = accept.types(['json', 'application/json+table']);
+      const { data, columns, query, meta } =
+        await this.ARAgingSummaryService.ARAgingSummary(tenantId, filter);
 
-      switch (acceptType) {
-        case 'application/json+table':
-          const table = await this.ARAgingSummaryService.ARAgingSummaryTable(
-            tenantId,
-            filter
-          );
-          return res.status(200).send({
-            table: {
-              rows: table.rows,
-              columns: table.columns,
-            },
-            meta: table.meta,
-            query: table.query,
-          });
-          break;
-        default:
-          const { data, columns, query, meta } =
-            await this.ARAgingSummaryService.ARAgingSummary(tenantId, filter);
-
-          return res.status(200).send({
-            data: this.transfromToResponse(data),
-            columns: this.transfromToResponse(columns),
-            query: this.transfromToResponse(query),
-            meta: this.transfromToResponse(meta),
-          });
-          break;
-      }
+      return res.status(200).send({
+        data: this.transfromToResponse(data),
+        columns: this.transfromToResponse(columns),
+        query: this.transfromToResponse(query),
+        meta: this.transfromToResponse(meta),
+      });
     } catch (error) {
       console.log(error);
     }

packages/server/src/api/controllers/ManualJournals.ts

@@ -387,7 +387,7 @@ export default class ManualJournalsController extends BaseController {
           errors: [{ type: 'CREDIT.DEBIT.NOT.EQUALS', code: 300 }],
         });
       }
-      if (error.errorType === 'accounts_ids_not_found') {
+      if (error.errorType === 'acccounts_ids_not_found') {
         return res.boom.badRequest(
           'Journal entries some of accounts ids not exists.',
           { errors: [{ type: 'ACCOUNTS.IDS.NOT.FOUND', code: 400 }] }

packages/server/src/api/controllers/Purchases/Bills.ts

@@ -1,27 +1,26 @@
-import { Service, Inject } from 'typedi';
 import { Router, Request, Response, NextFunction } from 'express';
 import { check, param, query } from 'express-validator';
-import {
-  AbilitySubject,
-  BillAction,
-  IBillDTO,
-  IBillEditDTO,
-} from '@/interfaces';
+import { Service, Inject } from 'typedi';
+import { AbilitySubject, BillAction, IBillDTO, IBillEditDTO } from '@/interfaces';
 import asyncMiddleware from '@/api/middleware/asyncMiddleware';
+import BillsService from '@/services/Purchases/Bills';
 import BaseController from '@/api/controllers/BaseController';
 import DynamicListingService from '@/services/DynamicListing/DynamicListService';
 import { ServiceError } from '@/exceptions';
 import CheckPolicies from '@/api/middleware/CheckPolicies';
-import { BillsApplication } from '@/services/Purchases/Bills/BillsApplication';
+import BillPaymentsService from '@/services/Purchases/BillPaymentsService';
 
 @Service()
 export default class BillsController extends BaseController {
   @Inject()
-  private billsApplication: BillsApplication;
+  private billsService: BillsService;
 
   @Inject()
   private dynamicListService: DynamicListingService;
 
+  @Inject()
+  private billPayments: BillPaymentsService;
+
   /**
    * Router constructor.
    */
@@ -98,7 +97,7 @@ export default class BillsController extends BaseController {
   /**
    * Common validation schema.
    */
-  private get billValidationSchema() {
+  get billValidationSchema() {
     return [
       check('bill_number').exists().trim().escape(),
       check('reference_no').optional().trim().escape(),
@@ -143,7 +142,7 @@ export default class BillsController extends BaseController {
   /**
    * Common validation schema.
    */
-  private get billEditValidationSchema() {
+  get billEditValidationSchema() {
     return [
       check('bill_number').optional().trim().escape(),
       check('reference_no').optional().trim().escape(),
@@ -185,14 +184,14 @@ export default class BillsController extends BaseController {
   /**
    * Bill validation schema.
    */
-  private get specificBillValidationSchema() {
+  get specificBillValidationSchema() {
     return [param('id').exists().isNumeric().toInt()];
   }
 
   /**
    * Bills list validation schema.
    */
-  private get billsListingValidationSchema() {
+  get billsListingValidationSchema() {
     return [
       query('view_slug').optional().isString().trim(),
       query('stringified_filter_roles').optional().isJSON(),
@@ -204,7 +203,7 @@ export default class BillsController extends BaseController {
     ];
   }
 
-  private get dueBillsListingValidationSchema() {
+  get dueBillsListingValidationSchema() {
     return [
       query('vendor_id').optional().trim().escape(),
       query('payment_made_id').optional().trim().escape(),
@@ -217,16 +216,17 @@ export default class BillsController extends BaseController {
    * @param {Response} res
    * @param {Function} next
    */
-  private async newBill(req: Request, res: Response, next: NextFunction) {
+  async newBill(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const billDTO: IBillDTO = this.matchedBodyData(req);
 
     try {
-      const storedBill = await this.billsApplication.createBill(
+      const storedBill = await this.billsService.createBill(
         tenantId,
         billDTO,
         user
       );
+
       return res.status(200).send({
         id: storedBill.id,
         message: 'The bill has been created successfully.',
@@ -241,13 +241,13 @@ export default class BillsController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async editBill(req: Request, res: Response, next: NextFunction) {
+  async editBill(req: Request, res: Response, next: NextFunction) {
     const { id: billId } = req.params;
     const { tenantId, user } = req;
     const billDTO: IBillEditDTO = this.matchedBodyData(req);
 
     try {
-      await this.billsApplication.editBill(tenantId, billId, billDTO, user);
+      await this.billsService.editBill(tenantId, billId, billDTO, user);
 
       return res.status(200).send({
         id: billId,
@@ -263,12 +263,12 @@ export default class BillsController extends BaseController {
    * @param {Request} req -
    * @param {Response} res -
    */
-  private async openBill(req: Request, res: Response, next: NextFunction) {
+  async openBill(req: Request, res: Response, next: NextFunction) {
     const { id: billId } = req.params;
     const { tenantId } = req;
 
     try {
-      await this.billsApplication.openBill(tenantId, billId);
+      await this.billsService.openBill(tenantId, billId);
 
       return res.status(200).send({
         id: billId,
@@ -285,12 +285,12 @@ export default class BillsController extends BaseController {
    * @param {Response} res
    * @return {Response}
    */
-  private async getBill(req: Request, res: Response, next: NextFunction) {
+  async getBill(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: billId } = req.params;
 
     try {
-      const bill = await this.billsApplication.getBill(tenantId, billId);
+      const bill = await this.billsService.getBill(tenantId, billId);
 
       return res.status(200).send(this.transfromToResponse({ bill }));
     } catch (error) {
@@ -304,12 +304,12 @@ export default class BillsController extends BaseController {
    * @param {Response} res -
    * @return {Response}
    */
-  private async deleteBill(req: Request, res: Response, next: NextFunction) {
+  async deleteBill(req: Request, res: Response, next: NextFunction) {
     const billId = req.params.id;
     const { tenantId } = req;
 
     try {
-      await this.billsApplication.deleteBill(tenantId, billId);
+      await this.billsService.deleteBill(tenantId, billId);
 
       return res.status(200).send({
         id: billId,
@@ -326,7 +326,7 @@ export default class BillsController extends BaseController {
    * @param {Response} res -
    * @return {Response}
    */
-  private async billsList(req: Request, res: Response, next: NextFunction) {
+  public async billsList(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const filter = {
       page: 1,
@@ -338,7 +338,7 @@ export default class BillsController extends BaseController {
 
     try {
       const { bills, pagination, filterMeta } =
-        await this.billsApplication.getBills(tenantId, filter);
+        await this.billsService.getBills(tenantId, filter);
 
       return res.status(200).send({
         bills: this.transfromToResponse(bills),
@@ -356,13 +356,12 @@ export default class BillsController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async getDueBills(req: Request, res: Response, next: NextFunction) {
+  public async getDueBills(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { vendorId } = this.matchedQueryData(req);
 
     try {
-      const bills = await this.billsApplication.getDueBills(tenantId, vendorId);
-
+      const bills = await this.billsService.getDueBills(tenantId, vendorId);
       return res.status(200).send({ bills });
     } catch (error) {
       next(error);
@@ -375,7 +374,7 @@ export default class BillsController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private getBillPaymentsTransactions = async (
+  public getBillPaymentsTransactions = async (
     req: Request,
     res: Response,
     next: NextFunction
@@ -384,7 +383,7 @@ export default class BillsController extends BaseController {
     const { id: billId } = req.params;
 
     try {
-      const billPayments = await this.billsApplication.getBillPayments(
+      const billPayments = await this.billPayments.getBillPayments(
         tenantId,
         billId
       );

packages/server/src/api/controllers/Purchases/BillsPayments.ts

@@ -4,7 +4,7 @@ import { check, param, query, ValidationChain } from 'express-validator';
 import asyncMiddleware from '@/api/middleware/asyncMiddleware';
 import { ServiceError } from '@/exceptions';
 import BaseController from '@/api/controllers/BaseController';
-import { BillPaymentsApplication } from '@/services/Purchases/BillPayments/BillPaymentsApplication';
+import BillPaymentsService from '@/services/Purchases/BillPayments/BillPayments';
 import BillPaymentsPages from '@/services/Purchases/BillPayments/BillPaymentsPages';
 import DynamicListingService from '@/services/DynamicListing/DynamicListService';
 import CheckPolicies from '@/api/middleware/CheckPolicies';
@@ -17,18 +17,18 @@ import { AbilitySubject, IPaymentMadeAction } from '@/interfaces';
 @Service()
 export default class BillsPayments extends BaseController {
   @Inject()
-  private billPaymentsApplication: BillPaymentsApplication;
+  billPaymentService: BillPaymentsService;
 
   @Inject()
-  private dynamicListService: DynamicListingService;
+  dynamicListService: DynamicListingService;
 
   @Inject()
-  private billPaymentsPages: BillPaymentsPages;
+  billPaymentsPages: BillPaymentsPages;
 
   /**
    * Router constructor.
    */
-  public router() {
+  router() {
     const router = Router();
 
     router.post(
@@ -106,7 +106,7 @@ export default class BillsPayments extends BaseController {
    * Bill payments schema validation.
    * @return {ValidationChain[]}
    */
-  private get billPaymentSchemaValidation(): ValidationChain[] {
+  get billPaymentSchemaValidation(): ValidationChain[] {
     return [
       check('vendor_id').exists().isNumeric().toInt(),
       check('exchange_rate').optional().isFloat({ gt: 0 }).toFloat(),
@@ -129,7 +129,7 @@ export default class BillsPayments extends BaseController {
    * Specific bill payment schema validation.
    * @returns {ValidationChain[]}
    */
-  private get specificBillPaymentValidateSchema(): ValidationChain[] {
+  get specificBillPaymentValidateSchema(): ValidationChain[] {
     return [param('id').exists().isNumeric().toInt()];
   }
 
@@ -137,7 +137,7 @@ export default class BillsPayments extends BaseController {
    * Bills payment list validation schema.
    * @returns {ValidationChain[]}
    */
-  private get listingValidationSchema(): ValidationChain[] {
+  get listingValidationSchema(): ValidationChain[] {
     return [
       query('custom_view_id').optional().isNumeric().toInt(),
       query('stringified_filter_roles').optional().isJSON(),
@@ -154,7 +154,7 @@ export default class BillsPayments extends BaseController {
    * @param {Request} req -
    * @param {Response} res -
    */
-  private async getBillPaymentNewPageEntries(req: Request, res: Response) {
+  async getBillPaymentNewPageEntries(req: Request, res: Response) {
     const { tenantId } = req;
     const { vendorId } = this.matchedQueryData(req);
 
@@ -174,7 +174,7 @@ export default class BillsPayments extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async getBillPaymentEditPage(
+  async getBillPaymentEditPage(
     req: Request,
     res: Response,
     next: NextFunction
@@ -205,19 +205,16 @@ export default class BillsPayments extends BaseController {
    * @param {Response} res
    * @param {Response} res
    */
-  private async createBillPayment(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async createBillPayment(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const billPaymentDTO = this.matchedBodyData(req);
 
     try {
-      const billPayment = await this.billPaymentsApplication.createBillPayment(
+      const billPayment = await this.billPaymentService.createBillPayment(
         tenantId,
         billPaymentDTO
       );
+
       return res.status(200).send({
         id: billPayment.id,
         message: 'Payment made has been created successfully.',
@@ -232,17 +229,13 @@ export default class BillsPayments extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async editBillPayment(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async editBillPayment(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const billPaymentDTO = this.matchedBodyData(req);
     const { id: billPaymentId } = req.params;
 
     try {
-      const paymentMade = await this.billPaymentsApplication.editBillPayment(
+      const paymentMade = await this.billPaymentService.editBillPayment(
         tenantId,
         billPaymentId,
         billPaymentDTO
@@ -263,19 +256,12 @@ export default class BillsPayments extends BaseController {
    * @param {Response} res -
    * @return {Response} res -
    */
-  private async deleteBillPayment(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deleteBillPayment(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: billPaymentId } = req.params;
 
     try {
-      await this.billPaymentsApplication.deleteBillPayment(
-        tenantId,
-        billPaymentId
-      );
+      await this.billPaymentService.deleteBillPayment(tenantId, billPaymentId);
 
       return res.status(200).send({
         id: billPaymentId,
@@ -291,19 +277,16 @@ export default class BillsPayments extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async getBillPayment(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getBillPayment(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: billPaymentId } = req.params;
 
     try {
-      const billPayment = await this.billPaymentsApplication.getBillPayment(
+      const billPayment = await this.billPaymentService.getBillPayment(
         tenantId,
         billPaymentId
       );
+
       return res.status(200).send({
         bill_payment: this.transfromToResponse(billPayment),
       });
@@ -318,16 +301,12 @@ export default class BillsPayments extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async getPaymentBills(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getPaymentBills(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: billPaymentId } = req.params;
 
     try {
-      const bills = await this.billPaymentsApplication.getPaymentBills(
+      const bills = await this.billPaymentService.getPaymentBills(
         tenantId,
         billPaymentId
       );
@@ -343,11 +322,7 @@ export default class BillsPayments extends BaseController {
    * @param {Response} res -
    * @return {Response}
    */
-  private async getBillsPayments(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getBillsPayments(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const billPaymentsFilter = {
       page: 1,
@@ -360,7 +335,7 @@ export default class BillsPayments extends BaseController {
 
     try {
       const { billPayments, pagination, filterMeta } =
-        await this.billPaymentsApplication.getBillPayments(
+        await this.billPaymentService.listBillPayments(
           tenantId,
           billPaymentsFilter
         );
@@ -382,7 +357,7 @@ export default class BillsPayments extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private handleServiceError(
+  handleServiceError(
     error: Error,
     req: Request,
     res: Response,

packages/server/src/api/controllers/Sales/PaymentReceives.ts

@@ -1,29 +1,42 @@
-import { Inject, Service } from 'typedi';
 import { Router, Request, Response, NextFunction } from 'express';
 import { check, param, query, ValidationChain } from 'express-validator';
+import { Inject, Service } from 'typedi';
 import {
   AbilitySubject,
   IPaymentReceiveDTO,
   PaymentReceiveAction,
+  SaleInvoiceAction,
 } from '@/interfaces';
 import BaseController from '@/api/controllers/BaseController';
 import asyncMiddleware from '@/api/middleware/asyncMiddleware';
+import PaymentReceiveService from '@/services/Sales/PaymentReceives/PaymentsReceives';
 import PaymentReceivesPages from '@/services/Sales/PaymentReceives/PaymentReceivesPages';
 import DynamicListingService from '@/services/DynamicListing/DynamicListService';
-import { PaymentReceivesApplication } from '@/services/Sales/PaymentReceives/PaymentReceivesApplication';
-import CheckPolicies from '@/api/middleware/CheckPolicies';
 import { ServiceError } from '@/exceptions';
+import PaymentReceiveNotifyBySms from '@/services/Sales/PaymentReceives/PaymentReceiveSmsNotify';
+import CheckPolicies from '@/api/middleware/CheckPolicies';
+import GetPaymentReceivePdf from '@/services/Sales/PaymentReceives/GetPaymentReeceivePdf';
 
+/**
+ * Payments receives controller.
+ * @service
+ */
 @Service()
 export default class PaymentReceivesController extends BaseController {
   @Inject()
-  private paymentReceiveApplication: PaymentReceivesApplication;
+  paymentReceiveService: PaymentReceiveService;
 
   @Inject()
-  private PaymentReceivesPages: PaymentReceivesPages;
+  PaymentReceivesPages: PaymentReceivesPages;
 
   @Inject()
-  private dynamicListService: DynamicListingService;
+  dynamicListService: DynamicListingService;
+
+  @Inject()
+  paymentReceiveSmsNotify: PaymentReceiveNotifyBySms;
+
+  @Inject()
+  paymentReceivePdf: GetPaymentReceivePdf;
 
   /**
    * Router constructor.
@@ -124,7 +137,7 @@ export default class PaymentReceivesController extends BaseController {
    * Payment receive schema.
    * @return {Array}
    */
-  private get paymentReceiveSchema(): ValidationChain[] {
+  get paymentReceiveSchema(): ValidationChain[] {
     return [
       check('customer_id').exists().isNumeric().toInt(),
       check('exchange_rate').optional().isFloat({ gt: 0 }).toFloat(),
@@ -149,7 +162,7 @@ export default class PaymentReceivesController extends BaseController {
   /**
    * Payment receive list validation schema.
    */
-  private get validatePaymentReceiveList(): ValidationChain[] {
+  get validatePaymentReceiveList(): ValidationChain[] {
     return [
       query('stringified_filter_roles').optional().isJSON(),
 
@@ -168,7 +181,7 @@ export default class PaymentReceivesController extends BaseController {
   /**
    * Validate payment receive parameters.
    */
-  private get paymentReceiveValidation() {
+  get paymentReceiveValidation() {
     return [param('id').exists().isNumeric().toInt()];
   }
 
@@ -176,14 +189,14 @@ export default class PaymentReceivesController extends BaseController {
    * New payment receive validation schema.
    * @return {Array}
    */
-  private get newPaymentReceiveValidation() {
+  get newPaymentReceiveValidation() {
     return [...this.paymentReceiveSchema];
   }
 
   /**
    * Edit payment receive validation.
    */
-  private get editPaymentReceiveValidation() {
+  get editPaymentReceiveValidation() {
     return [
       param('id').exists().isNumeric().toInt(),
       ...this.paymentReceiveSchema,
@@ -196,17 +209,13 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Response} res
    * @return {Response}
    */
-  private async newPaymentReceive(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async newPaymentReceive(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const paymentReceive: IPaymentReceiveDTO = this.matchedBodyData(req);
 
     try {
       const storedPaymentReceive =
-        await this.paymentReceiveApplication.createPaymentReceive(
+        await this.paymentReceiveService.createPaymentReceive(
           tenantId,
           paymentReceive,
           user
@@ -226,18 +235,14 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Response} res
    * @return {Response}
    */
-  private async editPaymentReceive(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async editPaymentReceive(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const { id: paymentReceiveId } = req.params;
 
     const paymentReceive: IPaymentReceiveDTO = this.matchedBodyData(req);
 
     try {
-      await this.paymentReceiveApplication.editPaymentReceive(
+      await this.paymentReceiveService.editPaymentReceive(
         tenantId,
         paymentReceiveId,
         paymentReceive,
@@ -257,20 +262,17 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async deletePaymentReceive(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deletePaymentReceive(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const { id: paymentReceiveId } = req.params;
 
     try {
-      await this.paymentReceiveApplication.deletePaymentReceive(
+      await this.paymentReceiveService.deletePaymentReceive(
         tenantId,
         paymentReceiveId,
         user
       );
+
       return res.status(200).send({
         id: paymentReceiveId,
         message: 'The payment receive has been deleted successfully',
@@ -286,7 +288,7 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async getPaymentReceiveInvoices(
+  async getPaymentReceiveInvoices(
     req: Request,
     res: Response,
     next: NextFunction
@@ -296,7 +298,7 @@ export default class PaymentReceivesController extends BaseController {
 
     try {
       const saleInvoices =
-        await this.paymentReceiveApplication.getPaymentReceiveInvoices(
+        await this.paymentReceiveService.getPaymentReceiveInvoices(
           tenantId,
           paymentReceiveId
         );
@@ -313,11 +315,7 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Response} res
    * @return {Response}
    */
-  private async getPaymentReceiveList(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getPaymentReceiveList(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const filter = {
       sortOrder: 'desc',
@@ -329,10 +327,7 @@ export default class PaymentReceivesController extends BaseController {
 
     try {
       const { paymentReceives, pagination, filterMeta } =
-        await this.paymentReceiveApplication.getPaymentReceives(
-          tenantId,
-          filter
-        );
+        await this.paymentReceiveService.listPaymentReceives(tenantId, filter);
 
       return res.status(200).send({
         payment_receives: this.transfromToResponse(paymentReceives),
@@ -349,7 +344,7 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Request} req - Request.
    * @param {Response} res - Response.
    */
-  private async getPaymentReceiveNewPageEntries(
+  async getPaymentReceiveNewPageEntries(
     req: Request,
     res: Response,
     next: NextFunction
@@ -372,11 +367,11 @@ export default class PaymentReceivesController extends BaseController {
 
   /**
    * Retrieve the given payment receive details.
-   * @async
+   * @asycn
    * @param {Request} req -
    * @param {Response} res -
    */
-  private async getPaymentReceiveEditPage(
+  async getPaymentReceiveEditPage(
     req: Request,
     res: Response,
     next: NextFunction
@@ -407,20 +402,15 @@ export default class PaymentReceivesController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async getPaymentReceive(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getPaymentReceive(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: paymentReceiveId } = req.params;
 
     try {
-      const paymentReceive =
-        await this.paymentReceiveApplication.getPaymentReceive(
-          tenantId,
-          paymentReceiveId
-        );
+      const paymentReceive = await this.paymentReceiveService.getPaymentReceive(
+        tenantId,
+        paymentReceiveId
+      );
 
       const ACCEPT_TYPE = {
         APPLICATION_PDF: 'application/pdf',
@@ -433,11 +423,10 @@ export default class PaymentReceivesController extends BaseController {
           });
         },
         [ACCEPT_TYPE.APPLICATION_PDF]: async () => {
-          const pdfContent =
-            await this.paymentReceiveApplication.getPaymentReceivePdf(
-              tenantId,
-              paymentReceive
-            );
+          const pdfContent = await this.paymentReceivePdf.getPaymentReceivePdf(
+            tenantId,
+            paymentReceive
+          );
           res.set({
             'Content-Type': 'application/pdf',
             'Content-Length': pdfContent.length,
@@ -465,11 +454,10 @@ export default class PaymentReceivesController extends BaseController {
     const { id: paymentReceiveId } = req.params;
 
     try {
-      const paymentReceive =
-        await this.paymentReceiveApplication.notifyPaymentBySms(
-          tenantId,
-          paymentReceiveId
-        );
+      const paymentReceive = await this.paymentReceiveSmsNotify.notifyBySms(
+        tenantId,
+        paymentReceiveId
+      );
       return res.status(200).send({
         id: paymentReceive.id,
         message: 'The payment notification has been sent successfully.',
@@ -494,11 +482,10 @@ export default class PaymentReceivesController extends BaseController {
     const { id: paymentReceiveId } = req.params;
 
     try {
-      const smsDetails =
-        await this.paymentReceiveApplication.getPaymentSmsDetails(
-          tenantId,
-          paymentReceiveId
-        );
+      const smsDetails = await this.paymentReceiveSmsNotify.smsDetails(
+        tenantId,
+        paymentReceiveId
+      );
       return res.status(200).send({
         data: smsDetails,
       });

packages/server/src/api/controllers/Sales/SalesEstimates.ts

@@ -1,17 +1,20 @@
 import { Router, Request, Response, NextFunction } from 'express';
-import { check, param, query } from 'express-validator';
+import { check, param, query, matchedData } from 'express-validator';
 import { Inject, Service } from 'typedi';
 import {
   AbilitySubject,
   ISaleEstimateDTO,
   SaleEstimateAction,
+  SaleInvoiceAction,
 } from '@/interfaces';
 import BaseController from '@/api/controllers/BaseController';
 import asyncMiddleware from '@/api/middleware/asyncMiddleware';
+import SaleEstimateService from '@/services/Sales/SalesEstimate';
 import DynamicListingService from '@/services/DynamicListing/DynamicListService';
 import { ServiceError } from '@/exceptions';
+import SaleEstimatesPdfService from '@/services/Sales/Estimates/SaleEstimatesPdf';
+import SaleEstimateNotifyBySms from '@/services/Sales/Estimates/SaleEstimateSmsNotify';
 import CheckPolicies from '@/api/middleware/CheckPolicies';
-import { SaleEstimatesApplication } from '@/services/Sales/Estimates/SaleEstimatesApplication';
 
 const ACCEPT_TYPE = {
   APPLICATION_PDF: 'application/pdf',
@@ -20,15 +23,21 @@ const ACCEPT_TYPE = {
 @Service()
 export default class SalesEstimatesController extends BaseController {
   @Inject()
-  private saleEstimatesApplication: SaleEstimatesApplication;
+  saleEstimateService: SaleEstimateService;
 
   @Inject()
-  private dynamicListService: DynamicListingService;
+  dynamicListService: DynamicListingService;
+
+  @Inject()
+  saleEstimatesPdf: SaleEstimatesPdfService;
+
+  @Inject()
+  saleEstimateNotifySms: SaleEstimateNotifyBySms;
 
   /**
    * Router constructor.
    */
-  public router() {
+  router() {
     const router = Router();
 
     router.post(
@@ -127,7 +136,7 @@ export default class SalesEstimatesController extends BaseController {
   /**
    * Estimate validation schema.
    */
-  private get estimateValidationSchema() {
+  get estimateValidationSchema() {
     return [
       check('customer_id').exists().isNumeric().toInt(),
       check('estimate_date').exists().isISO8601().toDate(),
@@ -168,14 +177,14 @@ export default class SalesEstimatesController extends BaseController {
   /**
    * Specific sale estimate validation schema.
    */
-  private get validateSpecificEstimateSchema() {
+  get validateSpecificEstimateSchema() {
     return [param('id').exists().isNumeric().toInt()];
   }
 
   /**
    * Sales estimates list validation schema.
    */
-  private get validateEstimateListSchema() {
+  get validateEstimateListSchema() {
     return [
       query('view_slug').optional().isString().trim(),
       query('stringified_filter_roles').optional().isJSON(),
@@ -193,16 +202,15 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Response} res -
    * @return {Response} res -
    */
-  private async newEstimate(req: Request, res: Response, next: NextFunction) {
+  async newEstimate(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const estimateDTO: ISaleEstimateDTO = this.matchedBodyData(req);
 
     try {
-      const storedEstimate =
-        await this.saleEstimatesApplication.createSaleEstimate(
-          tenantId,
-          estimateDTO
-        );
+      const storedEstimate = await this.saleEstimateService.createEstimate(
+        tenantId,
+        estimateDTO
+      );
 
       return res.status(200).send({
         id: storedEstimate.id,
@@ -218,18 +226,19 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async editEstimate(req: Request, res: Response, next: NextFunction) {
+  async editEstimate(req: Request, res: Response, next: NextFunction) {
     const { id: estimateId } = req.params;
     const { tenantId } = req;
     const estimateDTO: ISaleEstimateDTO = this.matchedBodyData(req);
 
     try {
       // Update estimate with associated estimate entries.
-      await this.saleEstimatesApplication.editSaleEstimate(
+      await this.saleEstimateService.editEstimate(
         tenantId,
         estimateId,
         estimateDTO
       );
+
       return res.status(200).send({
         id: estimateId,
         message: 'The sale estimate has been created successfully.',
@@ -244,19 +253,13 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async deleteEstimate(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deleteEstimate(req: Request, res: Response, next: NextFunction) {
     const { id: estimateId } = req.params;
     const { tenantId } = req;
 
     try {
-      await this.saleEstimatesApplication.deleteSaleEstimate(
-        tenantId,
-        estimateId
-      );
+      await this.saleEstimateService.deleteEstimate(tenantId, estimateId);
+
       return res.status(200).send({
         id: estimateId,
         message: 'The sale estimate has been deleted successfully.',
@@ -271,19 +274,13 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async deliverSaleEstimate(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deliverSaleEstimate(req: Request, res: Response, next: NextFunction) {
     const { id: estimateId } = req.params;
     const { tenantId } = req;
 
     try {
-      await this.saleEstimatesApplication.deliverSaleEstimate(
-        tenantId,
-        estimateId
-      );
+      await this.saleEstimateService.deliverSaleEstimate(tenantId, estimateId);
+
       return res.status(200).send({
         id: estimateId,
         message: 'The sale estimate has been delivered successfully.',
@@ -299,19 +296,12 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async approveSaleEstimate(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async approveSaleEstimate(req: Request, res: Response, next: NextFunction) {
     const { id: estimateId } = req.params;
     const { tenantId } = req;
 
     try {
-      await this.saleEstimatesApplication.approveSaleEstimate(
-        tenantId,
-        estimateId
-      );
+      await this.saleEstimateService.approveSaleEstimate(tenantId, estimateId);
 
       return res.status(200).send({
         id: estimateId,
@@ -328,19 +318,12 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async rejectSaleEstimate(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async rejectSaleEstimate(req: Request, res: Response, next: NextFunction) {
     const { id: estimateId } = req.params;
     const { tenantId } = req;
 
     try {
-      await this.saleEstimatesApplication.rejectSaleEstimate(
-        tenantId,
-        estimateId
-      );
+      await this.saleEstimateService.rejectSaleEstimate(tenantId, estimateId);
 
       return res.status(200).send({
         id: estimateId,
@@ -357,12 +340,12 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async getEstimate(req: Request, res: Response, next: NextFunction) {
+  async getEstimate(req: Request, res: Response, next: NextFunction) {
     const { id: estimateId } = req.params;
     const { tenantId } = req;
 
     try {
-      const estimate = await this.saleEstimatesApplication.getSaleEstimate(
+      const estimate = await this.saleEstimateService.getEstimate(
         tenantId,
         estimateId
       );
@@ -374,11 +357,10 @@ export default class SalesEstimatesController extends BaseController {
         },
         // PDF content type.
         [ACCEPT_TYPE.APPLICATION_PDF]: async () => {
-          const pdfContent =
-            await this.saleEstimatesApplication.getSaleEstimatePdf(
-              tenantId,
-              estimate
-            );
+          const pdfContent = await this.saleEstimatesPdf.saleEstimatePdf(
+            tenantId,
+            estimate
+          );
           res.set({
             'Content-Type': 'application/pdf',
             'Content-Length': pdfContent.length,
@@ -396,7 +378,7 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async getEstimates(req: Request, res: Response, next: NextFunction) {
+  async getEstimates(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const filter = {
       sortOrder: 'desc',
@@ -408,7 +390,7 @@ export default class SalesEstimatesController extends BaseController {
 
     try {
       const { salesEstimates, pagination, filterMeta } =
-        await this.saleEstimatesApplication.getSaleEstimates(tenantId, filter);
+        await this.saleEstimateService.estimatesList(tenantId, filter);
 
       res.format({
         [ACCEPT_TYPE.APPLICATION_JSON]: () => {
@@ -426,7 +408,7 @@ export default class SalesEstimatesController extends BaseController {
     }
   }
 
-  private saleEstimateNotifyBySms = async (
+  public saleEstimateNotifyBySms = async (
     req: Request,
     res: Response,
     next: NextFunction
@@ -435,11 +417,10 @@ export default class SalesEstimatesController extends BaseController {
     const { id: estimateId } = req.params;
 
     try {
-      const saleEstimate =
-        await this.saleEstimatesApplication.notifySaleEstimateBySms(
-          tenantId,
-          estimateId
-        );
+      const saleEstimate = await this.saleEstimateNotifySms.notifyBySms(
+        tenantId,
+        estimateId
+      );
       return res.status(200).send({
         id: saleEstimate.id,
         message:
@@ -456,7 +437,7 @@ export default class SalesEstimatesController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private saleEstimateSmsDetails = async (
+  public saleEstimateSmsDetails = async (
     req: Request,
     res: Response,
     next: NextFunction
@@ -465,11 +446,10 @@ export default class SalesEstimatesController extends BaseController {
     const { id: estimateId } = req.params;
 
     try {
-      const estimateSmsDetails =
-        await this.saleEstimatesApplication.getSaleEstimateSmsDetails(
-          tenantId,
-          estimateId
-        );
+      const estimateSmsDetails = await this.saleEstimateNotifySms.smsDetails(
+        tenantId,
+        estimateId
+      );
       return res.status(200).send({
         data: estimateSmsDetails,
       });

packages/server/src/api/controllers/Sales/SalesInvoices.ts

@@ -3,6 +3,7 @@ import { check, param, query } from 'express-validator';
 import { Service, Inject } from 'typedi';
 import BaseController from '../BaseController';
 import asyncMiddleware from '@/api/middleware/asyncMiddleware';
+import SaleInvoiceService from '@/services/Sales/SalesInvoices';
 import DynamicListingService from '@/services/DynamicListing/DynamicListService';
 import { ServiceError } from '@/exceptions';
 import {
@@ -11,8 +12,11 @@ import {
   SaleInvoiceAction,
   AbilitySubject,
 } from '@/interfaces';
+import SaleInvoicePdf from '@/services/Sales/SaleInvoicePdf';
+import SaleInvoiceWriteoff from '@/services/Sales/SaleInvoiceWriteoff';
+import SaleInvoiceNotifyBySms from '@/services/Sales/SaleInvoiceNotifyBySms';
 import CheckPolicies from '@/api/middleware/CheckPolicies';
-import { SaleInvoiceApplication } from '@/services/Sales/Invoices/SaleInvoicesApplication';
+import InvoicePaymentsService from '@/services/Sales/Invoices/InvoicePaymentsService';
 
 const ACCEPT_TYPE = {
   APPLICATION_PDF: 'application/pdf',
@@ -21,15 +25,27 @@ const ACCEPT_TYPE = {
 @Service()
 export default class SaleInvoicesController extends BaseController {
   @Inject()
-  private saleInvoiceApplication: SaleInvoiceApplication;
+  saleInvoiceService: SaleInvoiceService;
 
   @Inject()
-  private dynamicListService: DynamicListingService;
+  dynamicListService: DynamicListingService;
+
+  @Inject()
+  saleInvoicePdf: SaleInvoicePdf;
+
+  @Inject()
+  saleInvoiceWriteoff: SaleInvoiceWriteoff;
+
+  @Inject()
+  saleInvoiceSmsNotify: SaleInvoiceNotifyBySms;
+
+  @Inject()
+  invoicePaymentsSerivce: InvoicePaymentsService;
 
   /**
    * Router constructor.
    */
-  public router() {
+  router() {
     const router = Router();
 
     router.post(
@@ -151,7 +167,7 @@ export default class SaleInvoicesController extends BaseController {
   /**
    * Sale invoice validation schema.
    */
-  private get saleInvoiceValidationSchema() {
+  get saleInvoiceValidationSchema() {
     return [
       check('customer_id').exists().isNumeric().toInt(),
       check('invoice_date').exists().isISO8601().toDate(),
@@ -211,14 +227,14 @@ export default class SaleInvoicesController extends BaseController {
   /**
    * Specific sale invoice validation schema.
    */
-  private get specificSaleInvoiceValidation() {
+  get specificSaleInvoiceValidation() {
     return [param('id').exists().isNumeric().toInt()];
   }
 
   /**
    * Sales invoices list validation schema.
    */
-  private get saleInvoiceListValidationSchema() {
+  get saleInvoiceListValidationSchema() {
     return [
       query('view_slug').optional({ nullable: true }).isString().trim(),
       query('stringified_filter_roles').optional().isJSON(),
@@ -233,7 +249,7 @@ export default class SaleInvoicesController extends BaseController {
   /**
    * Due sale invoice list validation schema.
    */
-  private get dueSalesInvoicesListValidationSchema() {
+  get dueSalesInvoicesListValidationSchema() {
     return [query('customer_id').optional().isNumeric().toInt()];
   }
 
@@ -243,22 +259,17 @@ export default class SaleInvoicesController extends BaseController {
    * @param {Response} res
    * @param {Function} next
    */
-  private async newSaleInvoice(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async newSaleInvoice(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const saleInvoiceDTO: ISaleInvoiceCreateDTO = this.matchedBodyData(req);
 
     try {
       // Creates a new sale invoice with associated entries.
-      const storedSaleInvoice =
-        await this.saleInvoiceApplication.createSaleInvoice(
-          tenantId,
-          saleInvoiceDTO,
-          user
-        );
+      const storedSaleInvoice = await this.saleInvoiceService.createSaleInvoice(
+        tenantId,
+        saleInvoiceDTO,
+        user
+      );
       return res.status(200).send({
         id: storedSaleInvoice.id,
         message: 'The sale invoice has been created successfully.',
@@ -274,18 +285,14 @@ export default class SaleInvoicesController extends BaseController {
    * @param {Response} res
    * @param {Function} next
    */
-  private async editSaleInvoice(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async editSaleInvoice(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const { id: saleInvoiceId } = req.params;
     const saleInvoiceOTD: ISaleInvoiceDTO = this.matchedBodyData(req);
 
     try {
       // Update the given sale invoice details.
-      await this.saleInvoiceApplication.editSaleInvoice(
+      await this.saleInvoiceService.editSaleInvoice(
         tenantId,
         saleInvoiceId,
         saleInvoiceOTD,
@@ -306,16 +313,12 @@ export default class SaleInvoicesController extends BaseController {
    * @param {Response} res -
    * @param {NextFunction} next -
    */
-  private async deliverSaleInvoice(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deliverSaleInvoice(req: Request, res: Response, next: NextFunction) {
     const { tenantId, user } = req;
     const { id: saleInvoiceId } = req.params;
 
     try {
-      await this.saleInvoiceApplication.deliverSaleInvoice(
+      await this.saleInvoiceService.deliverSaleInvoice(
         tenantId,
         saleInvoiceId,
         user
@@ -335,17 +338,13 @@ export default class SaleInvoicesController extends BaseController {
    * @param {Response} res
    * @param {Function} next
    */
-  private async deleteSaleInvoice(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deleteSaleInvoice(req: Request, res: Response, next: NextFunction) {
     const { id: saleInvoiceId } = req.params;
     const { tenantId, user } = req;
 
     try {
       // Deletes the sale invoice with associated entries and journal transaction.
-      await this.saleInvoiceApplication.deleteSaleInvoice(
+      await this.saleInvoiceService.deleteSaleInvoice(
         tenantId,
         saleInvoiceId,
         user
@@ -365,16 +364,12 @@ export default class SaleInvoicesController extends BaseController {
    * @param {Request} req - Request object.
    * @param {Response} res - Response object.
    */
-  private async getSaleInvoice(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getSaleInvoice(req: Request, res: Response, next: NextFunction) {
     const { id: saleInvoiceId } = req.params;
     const { tenantId, user } = req;
 
     try {
-      const saleInvoice = await this.saleInvoiceApplication.getSaleInvoice(
+      const saleInvoice = await this.saleInvoiceService.getSaleInvoice(
         tenantId,
         saleInvoiceId,
         user
@@ -389,7 +384,7 @@ export default class SaleInvoicesController extends BaseController {
         },
         // PDF content type.
         [ACCEPT_TYPE.APPLICATION_PDF]: async () => {
-          const pdfContent = await this.saleInvoiceApplication.saleInvoicePdf(
+          const pdfContent = await this.saleInvoicePdf.saleInvoicePdf(
             tenantId,
             saleInvoice
           );
@@ -425,7 +420,7 @@ export default class SaleInvoicesController extends BaseController {
     };
     try {
       const { salesInvoices, filterMeta, pagination } =
-        await this.saleInvoiceApplication.getSaleInvoices(tenantId, filter);
+        await this.saleInvoiceService.salesInvoicesList(tenantId, filter);
 
       return res.status(200).send({
         sales_invoices: this.transfromToResponse(salesInvoices),
@@ -453,11 +448,10 @@ export default class SaleInvoicesController extends BaseController {
     const { customerId } = this.matchedQueryData(req);
 
     try {
-      const salesInvoices =
-        await this.saleInvoiceApplication.getReceivableSaleInvoices(
-          tenantId,
-          customerId
-        );
+      const salesInvoices = await this.saleInvoiceService.getPayableInvoices(
+        tenantId,
+        customerId
+      );
       return res.status(200).send({
         sales_invoices: this.transfromToResponse(salesInvoices),
       });
@@ -483,7 +477,7 @@ export default class SaleInvoicesController extends BaseController {
     const writeoffDTO = this.matchedBodyData(req);
 
     try {
-      const saleInvoice = await this.saleInvoiceApplication.writeOff(
+      const saleInvoice = await this.saleInvoiceWriteoff.writeOff(
         tenantId,
         invoiceId,
         writeoffDTO
@@ -491,7 +485,7 @@ export default class SaleInvoicesController extends BaseController {
 
       return res.status(200).send({
         id: saleInvoice.id,
-        message: 'The given sale invoice has been written-off successfully.',
+        message: 'The given sale invoice has been writte-off successfully.',
       });
     } catch (error) {
       next(error);
@@ -513,7 +507,7 @@ export default class SaleInvoicesController extends BaseController {
     const { id: invoiceId } = req.params;
 
     try {
-      const saleInvoice = await this.saleInvoiceApplication.cancelWrittenoff(
+      const saleInvoice = await this.saleInvoiceWriteoff.cancelWrittenoff(
         tenantId,
         invoiceId
       );
@@ -544,12 +538,11 @@ export default class SaleInvoicesController extends BaseController {
     const invoiceNotifySmsDTO = this.matchedBodyData(req);
 
     try {
-      const saleInvoice =
-        await this.saleInvoiceApplication.notifySaleInvoiceBySms(
-          tenantId,
-          invoiceId,
-          invoiceNotifySmsDTO.notificationKey
-        );
+      const saleInvoice = await this.saleInvoiceSmsNotify.notifyBySms(
+        tenantId,
+        invoiceId,
+        invoiceNotifySmsDTO.notificationKey
+      );
       return res.status(200).send({
         id: saleInvoice.id,
         message:
@@ -576,12 +569,11 @@ export default class SaleInvoicesController extends BaseController {
     const smsDetailsDTO = this.matchedQueryData(req);
 
     try {
-      const invoiceSmsDetails =
-        await this.saleInvoiceApplication.getSaleInvoiceSmsDetails(
-          tenantId,
-          invoiceId,
-          smsDetailsDTO
-        );
+      const invoiceSmsDetails = await this.saleInvoiceSmsNotify.smsDetails(
+        tenantId,
+        invoiceId,
+        smsDetailsDTO
+      );
       return res.status(200).send({
         data: invoiceSmsDetails,
       });
@@ -607,7 +599,7 @@ export default class SaleInvoicesController extends BaseController {
 
     try {
       const invoicePayments =
-        await this.saleInvoiceApplication.getInvoicePayments(
+        await this.invoicePaymentsSerivce.getInvoicePayments(
           tenantId,
           invoiceId
         );

packages/server/src/api/controllers/Sales/SalesReceipts.ts

@@ -2,26 +2,34 @@ import { Router, Request, Response, NextFunction } from 'express';
 import { check, param, query } from 'express-validator';
 import { Inject, Service } from 'typedi';
 import asyncMiddleware from '@/api/middleware/asyncMiddleware';
+import SaleReceiptService from '@/services/Sales/SalesReceipts';
+import SaleReceiptsPdfService from '@/services/Sales/Receipts/SaleReceiptsPdfService';
 import BaseController from '../BaseController';
 import { ISaleReceiptDTO } from '@/interfaces/SaleReceipt';
 import { ServiceError } from '@/exceptions';
 import DynamicListingService from '@/services/DynamicListing/DynamicListService';
+import SaleReceiptNotifyBySms from '@/services/Sales/SaleReceiptNotifyBySms';
 import CheckPolicies from '@/api/middleware/CheckPolicies';
 import { AbilitySubject, SaleReceiptAction } from '@/interfaces';
-import { SaleReceiptApplication } from '@/services/Sales/Receipts/SaleReceiptApplication';
 
 @Service()
 export default class SalesReceiptsController extends BaseController {
   @Inject()
-  private saleReceiptsApplication: SaleReceiptApplication;
+  saleReceiptService: SaleReceiptService;
 
   @Inject()
-  private dynamicListService: DynamicListingService;
+  saleReceiptsPdf: SaleReceiptsPdfService;
+
+  @Inject()
+  dynamicListService: DynamicListingService;
+
+  @Inject()
+  saleReceiptSmsNotify: SaleReceiptNotifyBySms;
 
   /**
    * Router constructor.
    */
-  public router() {
+  router() {
     const router = Router();
 
     router.post(
@@ -97,7 +105,7 @@ export default class SalesReceiptsController extends BaseController {
    * Sales receipt validation schema.
    * @return {Array}
    */
-  private get salesReceiptsValidationSchema() {
+  get salesReceiptsValidationSchema() {
     return [
       check('customer_id').exists().isNumeric().toInt(),
       check('exchange_rate').optional().isFloat({ gt: 0 }).toFloat(),
@@ -138,14 +146,14 @@ export default class SalesReceiptsController extends BaseController {
   /**
    * Specific sale receipt validation schema.
    */
-  private get specificReceiptValidationSchema() {
+  get specificReceiptValidationSchema() {
     return [param('id').exists().isNumeric().toInt()];
   }
 
   /**
    * List sales receipts validation schema.
    */
-  private get listSalesReceiptsValidationSchema() {
+  get listSalesReceiptsValidationSchema() {
     return [
       query('view_slug').optional().isString().trim(),
       query('stringified_filter_roles').optional().isJSON(),
@@ -162,21 +170,16 @@ export default class SalesReceiptsController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async newSaleReceipt(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async newSaleReceipt(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const saleReceiptDTO: ISaleReceiptDTO = this.matchedBodyData(req);
 
     try {
       // Store the given sale receipt details with associated entries.
-      const storedSaleReceipt =
-        await this.saleReceiptsApplication.createSaleReceipt(
-          tenantId,
-          saleReceiptDTO
-        );
+      const storedSaleReceipt = await this.saleReceiptService.createSaleReceipt(
+        tenantId,
+        saleReceiptDTO
+      );
       return res.status(200).send({
         id: storedSaleReceipt.id,
         message: 'Sale receipt has been created successfully.',
@@ -191,20 +194,13 @@ export default class SalesReceiptsController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async deleteSaleReceipt(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async deleteSaleReceipt(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: saleReceiptId } = req.params;
 
     try {
       // Deletes the sale receipt.
-      await this.saleReceiptsApplication.deleteSaleReceipt(
-        tenantId,
-        saleReceiptId
-      );
+      await this.saleReceiptService.deleteSaleReceipt(tenantId, saleReceiptId);
 
       return res.status(200).send({
         id: saleReceiptId,
@@ -221,18 +217,14 @@ export default class SalesReceiptsController extends BaseController {
    * @param {Request} req -
    * @param {Response} res -
    */
-  private async editSaleReceipt(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async editSaleReceipt(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: saleReceiptId } = req.params;
     const saleReceipt = this.matchedBodyData(req);
 
     try {
       // Update the given sale receipt details.
-      await this.saleReceiptsApplication.editSaleReceipt(
+      await this.saleReceiptService.editSaleReceipt(
         tenantId,
         saleReceiptId,
         saleReceipt
@@ -252,20 +244,13 @@ export default class SalesReceiptsController extends BaseController {
    * @param {Response} res
    * @param {NextFunction} next
    */
-  private async closeSaleReceipt(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async closeSaleReceipt(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const { id: saleReceiptId } = req.params;
 
     try {
       // Update the given sale receipt details.
-      await this.saleReceiptsApplication.closeSaleReceipt(
-        tenantId,
-        saleReceiptId
-      );
+      await this.saleReceiptService.closeSaleReceipt(tenantId, saleReceiptId);
       return res.status(200).send({
         id: saleReceiptId,
         message: 'Sale receipt has been closed successfully.',
@@ -280,11 +265,7 @@ export default class SalesReceiptsController extends BaseController {
    * @param {Request} req
    * @param {Response} res
    */
-  private async getSalesReceipts(
-    req: Request,
-    res: Response,
-    next: NextFunction
-  ) {
+  async getSalesReceipts(req: Request, res: Response, next: NextFunction) {
     const { tenantId } = req;
     const filter = {
       sortOrder: 'desc',
@@ -293,9 +274,10 @@ export default class SalesReceiptsController extends BaseController {
       pageSize: 12,
       ...this.matchedQueryData(req),
     };
+
     try {
       const { data, pagination, filterMeta } =
-        await this.saleReceiptsApplication.getSaleReceipts(tenantId, filter);
+        await this.saleReceiptService.salesReceiptsList(tenantId, filter);
 
       const response = this.transfromToResponse({
         data,
@@ -319,10 +301,11 @@ export default class SalesReceiptsController extends BaseController {
     const { tenantId } = req;
 
     try {
-      const saleReceipt = await this.saleReceiptsApplication.getSaleReceipt(
+      const saleReceipt = await this.saleReceiptService.getSaleReceipt(
         tenantId,
         saleReceiptId
       );
+
       res.format({
         'application/json': () => {
           return res
@@ -330,11 +313,10 @@ export default class SalesReceiptsController extends BaseController {
             .send(this.transfromToResponse({ saleReceipt }));
         },
         'application/pdf': async () => {
-          const pdfContent =
-            await this.saleReceiptsApplication.getSaleReceiptPdf(
-              tenantId,
-              saleReceipt
-            );
+          const pdfContent = await this.saleReceiptsPdf.saleReceiptPdf(
+            tenantId,
+            saleReceipt
+          );
           res.set({
             'Content-Type': 'application/pdf',
             'Content-Length': pdfContent.length,
@@ -362,11 +344,10 @@ export default class SalesReceiptsController extends BaseController {
     const { id: receiptId } = req.params;
 
     try {
-      const saleReceipt =
-        await this.saleReceiptsApplication.saleReceiptNotifyBySms(
-          tenantId,
-          receiptId
-        );
+      const saleReceipt = await this.saleReceiptSmsNotify.notifyBySms(
+        tenantId,
+        receiptId
+      );
       return res.status(200).send({
         id: saleReceipt.id,
         message:
@@ -392,11 +373,10 @@ export default class SalesReceiptsController extends BaseController {
     const { id: receiptId } = req.params;
 
     try {
-      const smsDetails =
-        await this.saleReceiptsApplication.getSaleReceiptSmsDetails(
-          tenantId,
-          receiptId
-        );
+      const smsDetails = await this.saleReceiptSmsNotify.smsDetails(
+        tenantId,
+        receiptId
+      );
       return res.status(200).send({
         data: smsDetails,
       });

packages/server/src/api/controllers/Sales/index.ts

@@ -1,10 +1,10 @@
 import { Router } from 'express';
 import { Container, Service } from 'typedi';
-import SalesInvoices from './SalesInvoices'
 import SalesEstimates from './SalesEstimates';
 import SalesReceipts from './SalesReceipts';
-import CreditNotes from './CreditNotes';
+import SalesInvoices from './SalesInvoices'
 import PaymentReceives from './PaymentReceives';
+import CreditNotes from './CreditNotes';
 @Service()
 export default class SalesController {
   /**

packages/server/src/config/index.ts

@@ -1,12 +1,9 @@
 import dotenv from 'dotenv';
 import path from 'path';
-import { toInteger } from 'lodash';
 import { castCommaListEnvVarToArray, parseBoolean } from '@/utils';
 
 dotenv.config();
 
-const API_RATE_LIMIT = process.env.API_RATE_LIMIT?.split(',') || [];
-
 module.exports = {
   /**
    * Your favorite port
@@ -100,7 +97,7 @@ module.exports = {
   jwtSecret: process.env.JWT_SECRET,
 
   /**
-   *
+   * 
    */
   resetPasswordSeconds: 600,
 
@@ -133,9 +130,9 @@ module.exports = {
       blockDuration: 60 * 15,
     },
     requests: {
-      points: API_RATE_LIMIT[0] ? toInteger(API_RATE_LIMIT[0]) : 120,
-      duration: API_RATE_LIMIT[1] ? toInteger(API_RATE_LIMIT[1]) : 60,
-      blockDuration: API_RATE_LIMIT[2] ? toInteger(API_RATE_LIMIT[2]) : 60 * 10,
+      points: 60,
+      duration: 60,
+      blockDuration: 60 * 10,
     },
   },
 

packages/server/src/database/seeds/data/accounts.js

@@ -81,7 +81,7 @@ export default [
     parent_account_id: null,
     index: 1,
     active: 1,
-    description:'An account that holds valuation of products or goods that available for sale.',
+    description:'An account that holds valuation of products or goods that availiable for sale.',
   },
 
   // Libilities

packages/server/src/interfaces/APAgingSummaryReport.ts

@@ -1,36 +1,51 @@
 import {
   IAgingPeriod,
   IAgingPeriodTotal,
-  IAgingAmount,
-  IAgingSummaryQuery,
-  IAgingSummaryTotal,
-  IAgingSummaryContact,
-  IAgingSummaryData,
+  IAgingAmount
 } from './AgingReport';
-import { INumberFormatQuery } from './FinancialStatements';
+import {
+  INumberFormatQuery
+} from './FinancialStatements';
 
-export interface IAPAgingSummaryQuery extends IAgingSummaryQuery {
+export interface IAPAgingSummaryQuery {
+  asDate: Date | string;
+  agingDaysBefore: number;
+  agingPeriods: number;
+  numberFormat: INumberFormatQuery;
   vendorsIds: number[];
+  noneZero: boolean;
+
+  branchesIds?: number[]
 }
 
-export interface IAPAgingSummaryVendor extends IAgingSummaryContact {
-  vendorName: string;
-}
+export interface IAPAgingSummaryVendor {
+  vendorName: string,
+  current: IAgingAmount,
+  aging: IAgingPeriodTotal[],
+  total: IAgingAmount,
+};
 
-export interface IAPAgingSummaryTotal extends IAgingSummaryTotal {}
+export interface IAPAgingSummaryTotal {
+  current: IAgingAmount,
+  aging: IAgingPeriodTotal[],
+  total: IAgingAmount,
+};
 
-export interface IAPAgingSummaryData extends IAgingSummaryData {
-  vendors: IAPAgingSummaryVendor[];
-}
+export interface IAPAgingSummaryData {
+  vendors: IAPAgingSummaryVendor[],
+  total: IAPAgingSummaryTotal,
+};
 
 export type IAPAgingSummaryColumns = IAgingPeriod[];
 
+
 export interface IARAgingSummaryMeta {
-  baseCurrency: string;
-  organizationName: string;
+  baseCurrency: string,
+  organizationName: string,
 }
 
+
 export interface IAPAgingSummaryMeta {
-  baseCurrency: string;
-  organizationName: string;
-}
+  baseCurrency: string,
+  organizationName: string,
+}

packages/server/src/interfaces/ARAgingSummaryReport.ts

@@ -1,28 +1,37 @@
-import {
-  IAgingPeriod,
-  IAgingSummaryQuery,
-  IAgingSummaryTotal,
-  IAgingSummaryContact,
-  IAgingSummaryData,
-} from './AgingReport';
+import { IAgingPeriod, IAgingPeriodTotal, IAgingAmount } from './AgingReport';
+import { INumberFormatQuery } from './FinancialStatements';
 
-export interface IARAgingSummaryQuery extends IAgingSummaryQuery {
+export interface IARAgingSummaryQuery {
+  asDate: Date | string;
+  agingDaysBefore: number;
+  agingPeriods: number;
+  numberFormat: INumberFormatQuery;
   customersIds: number[];
+  branchesIds: number[];
+  noneZero: boolean;
 }
 
-export interface IARAgingSummaryCustomer extends IAgingSummaryContact {
+export interface IARAgingSummaryCustomer {
   customerName: string;
+  current: IAgingAmount;
+  aging: IAgingPeriodTotal[];
+  total: IAgingAmount;
 }
 
-export interface IARAgingSummaryTotal extends IAgingSummaryTotal {}
+export interface IARAgingSummaryTotal {
+  current: IAgingAmount;
+  aging: IAgingPeriodTotal[];
+  total: IAgingAmount;
+}
 
-export interface IARAgingSummaryData extends IAgingSummaryData {
+export interface IARAgingSummaryData {
   customers: IARAgingSummaryCustomer[];
+  total: IARAgingSummaryTotal;
 }
 
 export type IARAgingSummaryColumns = IAgingPeriod[];
 
 export interface IARAgingSummaryMeta {
-  organizationName: string;
-  baseCurrency: string;
-}
+  organizationName: string,
+  baseCurrency: string,
+}

packages/server/src/interfaces/Account.ts

@@ -58,7 +58,6 @@ export interface IAccountTransaction {
   date: string | Date;
 
   referenceType: string;
-  referenceTypeFormatted: string;
   referenceId: number;
 
   referenceNumber?: string;

packages/server/src/interfaces/AgingReport.ts

@@ -1,9 +1,6 @@
-
-import { INumberFormatQuery } from './FinancialStatements';
-
 export interface IAgingPeriodTotal extends IAgingPeriod {
   total: IAgingAmount;
-}
+};
 
 export interface IAgingAmount {
   amount: number;
@@ -23,22 +20,3 @@ export interface IAgingSummaryContact {
   aging: IAgingPeriodTotal[];
   total: IAgingAmount;
 }
-
-export interface IAgingSummaryQuery {
-  asDate: Date | string;
-  agingDaysBefore: number;
-  agingPeriods: number;
-  numberFormat: INumberFormatQuery;
-  branchesIds: number[];
-  noneZero: boolean;
-}
-
-export interface IAgingSummaryTotal {
-  current: IAgingAmount;
-  aging: IAgingPeriodTotal[];
-  total: IAgingAmount;
-}
-
-export interface IAgingSummaryData {
-  total: IAgingSummaryTotal;
-}

packages/server/src/interfaces/Bill.ts

@@ -1,7 +1,7 @@
 import { Knex } from 'knex';
 import { IDynamicListFilterDTO } from './DynamicFilter';
 import { IItemEntry, IItemEntryDTO } from './ItemEntry';
-import { IBillLandedCost } from './LandedCost';
+import { IBillLandedCost } from './LandedCost'; 
 export interface IBillDTO {
   vendorId: number;
   billNumber: string;
@@ -99,17 +99,17 @@ export interface IBillCreatedPayload {
   trx: Knex.Transaction;
 }
 
-export interface IBillCreatingPayload {
+export interface IBillCreatingPayload{
   tenantId: number;
   billDTO: IBillDTO;
-  trx: Knex.Transaction;
+  trx: Knex.Transaction; 
 }
 
 export interface IBillEditingPayload {
   tenantId: number;
   oldBill: IBill;
   billDTO: IBillEditDTO;
-  trx: Knex.Transaction;
+  trx: Knex.Transaction; 
 }
 export interface IBillEditedPayload {
   tenantId: number;
@@ -129,7 +129,7 @@ export interface IBIllEventDeletedPayload {
 export interface IBillEventDeletingPayload {
   tenantId: number;
   oldBill: IBill;
-  trx: Knex.Transaction;
+  trx: Knex.Transaction; 
 }
 export enum BillAction {
   Create = 'Create',
@@ -138,16 +138,3 @@ export enum BillAction {
   View = 'View',
   NotifyBySms = 'NotifyBySms',
 }
-
-export interface IBillOpeningPayload {
-  trx: Knex.Transaction;
-  tenantId: number;
-  oldBill: IBill;
-}
-
-export interface IBillOpenedPayload {
-  trx: Knex.Transaction;
-  bill: IBill;
-  oldBill: IBill;
-  tenantId: number;
-}

packages/server/src/interfaces/CashFlow.ts

@@ -41,7 +41,7 @@ export interface ICashFlowStatementAccountMeta {
   code: string;
   total: ICashFlowStatementTotal;
   accountType: string;
-  adjustmentType: string;
+  adjusmentType: string;
   sectionType: ICashFlowStatementSectionType.ACCOUNT;
 }
 

packages/server/src/interfaces/PaymentReceive.ts

@@ -1,5 +1,6 @@
-import { Knex } from 'knex';
 import { ISystemUser } from '@/interfaces';
+import { Knex } from 'knex';
+import { pick } from 'lodash';
 import { ILedgerEntry } from './Ledger';
 import { ISaleInvoice } from './SaleInvoice';
 

packages/server/src/interfaces/SaleInvoice.ts

@@ -156,7 +156,6 @@ export interface ISaleInvoiceEventDeliveredPayload {
   tenantId: number;
   saleInvoiceId: number;
   saleInvoice: ISaleInvoice;
-  trx: Knex.Transaction;
 }
 
 export interface ISaleInvoiceDeliveringPayload {

packages/server/src/jobs/WriteInvoicesJEntries.ts

@@ -1,7 +1,7 @@
 import { Container } from 'typedi';
 import events from '@/subscribers/events';
+import SalesInvoicesCost from '@/services/Sales/SalesInvoicesCost';
 import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
-import { SaleInvoicesCost } from '@/services/Sales/Invoices/SalesInvoicesCost';
 
 export default class WriteInvoicesJournalEntries {
   eventPublisher: EventPublisher;
@@ -26,7 +26,7 @@ export default class WriteInvoicesJournalEntries {
    */
   public async handler(job, done: Function): Promise<void> {
     const { startingDate, tenantId } = job.attrs.data;
-    const salesInvoicesCost = Container.get(SaleInvoicesCost);
+    const salesInvoicesCost = Container.get(SalesInvoicesCost);
 
     try {
       await salesInvoicesCost.writeCostLotsGLEntries(tenantId, startingDate);

packages/server/src/lib/DynamicFilter/DynamicFilter.ts

@@ -1,8 +1,8 @@
 import { forEach, uniqBy } from 'lodash';
-import DynamicFilterAbstractor from './DynamicFilterAbstractor';
+import DynamicFilterAbstructor from './DynamicFilterAbstructor';
 import { IDynamicFilter, IFilterRole, IModel } from '@/interfaces';
 
-export default class DynamicFilter extends DynamicFilterAbstractor{
+export default class DynamicFilter extends DynamicFilterAbstructor{
   private model: IModel;
   private tableName: string;
   private dynamicFilters: IDynamicFilter[];

packages/server/src/lib/DynamicFilter/DynamicFilterAbstructor.ts

@@ -1,5 +1,5 @@
 
-export default class DynamicFilterAbstractor {
+export default class DynamicFilterAbstructor {
   /**
    * Extract relation table name from relation.
    * @param {String} column -

packages/server/src/lib/DynamicFilter/DynamicFilterFilterRoles.ts

@@ -1,7 +1,7 @@
-import DynamicFilterRoleAbstractor from './DynamicFilterRoleAbstractor';
+import DynamicFilterRoleAbstructor from './DynamicFilterRoleAbstructor';
 import { IFilterRole } from '@/interfaces';
 
-export default class FilterRoles extends DynamicFilterRoleAbstractor {
+export default class FilterRoles extends DynamicFilterRoleAbstructor {
   private filterRoles: IFilterRole[];
 
   /**

packages/server/src/lib/DynamicFilter/DynamicFilterRoleAbstructor.ts

@@ -6,7 +6,7 @@ import DynamicFilterQueryParser from './DynamicFilterQueryParser';
 import { Lexer } from '../LogicEvaluation/Lexer';
 import { COMPARATOR_TYPE, FIELD_TYPE } from './constants';
 
-export default abstract class DynamicFilterAbstractor
+export default abstract class DynamicFilterAbstructor
   implements IDynamicFilter
 {
   protected filterRoles: IFilterRole[] = [];

packages/server/src/lib/DynamicFilter/DynamicFilterSortBy.ts

@@ -1,4 +1,4 @@
-import DynamicFilterRoleAbstractor from '@/lib/DynamicFilter/DynamicFilterRoleAbstractor';
+import DynamicFilterRoleAbstructor from '@/lib/DynamicFilter/DynamicFilterRoleAbstructor';
 import { FIELD_TYPE } from './constants';
 
 interface ISortRole {
@@ -6,7 +6,7 @@ interface ISortRole {
   order: string;
 }
 
-export default class DynamicFilterSortBy extends DynamicFilterRoleAbstractor {
+export default class DynamicFilterSortBy extends DynamicFilterRoleAbstructor {
   private sortRole: ISortRole = {};
 
   /**

packages/server/src/lib/DynamicFilter/DynamicFilterViews.ts

@@ -1,8 +1,8 @@
 import { omit } from 'lodash';
 import { IView, IViewRole } from '@/interfaces';
-import DynamicFilterRoleAbstractor from './DynamicFilterRoleAbstractor';
+import DynamicFilterRoleAbstructor from './DynamicFilterRoleAbstructor';
 
-export default class DynamicFilterViews extends DynamicFilterRoleAbstractor {
+export default class DynamicFilterViews extends DynamicFilterRoleAbstructor {
   private viewSlug: string;
   private logicExpression: string;
   private filterRoles: IViewRole[];

packages/server/src/lib/ViewRolesBuilder/FilterRolesDynamicFilter.js

@@ -1,10 +1,10 @@
-import DynamicFilterRoleAbstractor from '@/lib/DynamicFilter/DynamicFilterRoleAbstractor';
+import DynamicFilterRoleAbstructor from '@/lib/DynamicFilter/DynamicFilterRoleAbstructor';
 import {
   validateViewRoles,
   buildFilterQuery,
 } from '@/lib/ViewRolesBuilder';
 
-export default class ViewRolesDynamicFilter extends DynamicFilterRoleAbstractor {
+export default class ViewRolesDynamicFilter extends DynamicFilterRoleAbstructor {
   /**
    * Constructor method.
    * @param {*} filterRoles -

packages/server/src/loaders/eventEmitter.ts

@@ -1,16 +1,17 @@
 import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
 
+import ItemSubscriber from '@/subscribers/Items/ItemSubscriber';
 import InventoryAdjustmentsSubscriber from '@/subscribers/Inventory/InventoryAdjustment';
 import BillWriteInventoryTransactionsSubscriber from '@/subscribers/Bills/WriteInventoryTransactions';
 import PaymentSyncBillBalance from '@/subscribers/PaymentMades/PaymentSyncBillBalance';
 import SaleReceiptInventoryTransactionsSubscriber from '@/subscribers/SaleReceipt/WriteInventoryTransactions';
 import SaleInvoiceWriteInventoryTransactions from '@/subscribers/SaleInvoices/WriteInventoryTransactions';
 import SaleInvoiceWriteGLEntriesSubscriber from '@/subscribers/SaleInvoices/WriteJournalEntries';
-import SaleReceiptWriteGLEntriesSubscriber from '@/subscribers/SaleReceipt/WriteJournalEntries';
 import PaymentReceiveSyncInvoices from '@/subscribers/PaymentReceive/PaymentReceiveSyncInvoices';
 import CashflowTransactionSubscriber from '@/services/Cashflow/CashflowTransactionSubscriber';
 import PaymentReceivesWriteGLEntriesSubscriber from '@/subscribers/PaymentReceive/WriteGLEntries';
 import InventorySubscriber from '@/subscribers/Inventory/Inventory';
+import SaleReceiptWriteGLEntriesSubscriber from '@/subscribers/SaleReceipt/WriteJournalEntries';
 import { CustomerWriteGLOpeningBalanceSubscriber } from '@/services/Contacts/Customers/Subscribers/CustomerGLEntriesSubscriber';
 import { VendorsWriteGLOpeningSubscriber } from '@/services/Contacts/Vendors/Subscribers/VendorGLEntriesSubscriber';
 import SaleEstimateAutoSerialSubscriber from '@/subscribers/SaleEstimate/AutoIncrementSerial';
@@ -34,7 +35,7 @@ import PurgeAuthorizedUserOnceRoleMutate from '@/services/Roles/PurgeAuthorizedU
 import SendSmsNotificationToCustomer from '@/subscribers/SaleInvoices/SendSmsNotificationToCustomer';
 import SendSmsNotificationSaleReceipt from '@/subscribers/SaleReceipt/SendSmsNotificationToCustomer';
 import SendSmsNotificationPaymentReceive from '@/subscribers/PaymentReceive/SendSmsNotificationToCustomer';
-import SaleInvoiceWriteoffSubscriber from '@/services/Sales/Invoices/SaleInvoiceWriteoffSubscriber';
+import SaleInvoiceWriteoffSubscriber from '@/services/Sales/SaleInvoiceWriteoffSubscriber';
 import LandedCostSyncCostTransactionsSubscriber from '@/services/Purchases/LandedCost/LandedCostSyncCostTransactionsSubscriber';
 import LandedCostInventoryTransactionsSubscriber from '@/services/Purchases/LandedCost/LandedCostInventoryTransactionsSubscriber';
 import CreditNoteGLEntriesSubscriber from '@/services/CreditNotes/CreditNoteGLEntriesSubscriber';
@@ -65,6 +66,7 @@ import { ActivateWarehousesSubscriber } from '@/services/Warehouses/ActivateWare
 import { ManualJournalWriteGLSubscriber } from '@/services/ManualJournals/ManualJournalGLEntriesSubscriber';
 import { BillGLEntriesSubscriber } from '@/services/Purchases/Bills/BillGLEntriesSubscriber';
 import { PaymentWriteGLEntriesSubscriber } from '@/services/Purchases/BillPayments/BillPaymentGLEntriesSubscriber';
+
 import BranchesIntegrationsSubscribers from '@/services/Branches/EventsProvider';
 import WarehousesIntegrationsSubscribers from '@/services/Warehouses/EventsProvider';
 import { WarehouseTransferAutoIncrementSubscriber } from '@/services/Warehouses/WarehousesTransfers/WarehouseTransferAutoIncrementSubscriber';
@@ -86,6 +88,7 @@ export default () => {
 
 export const susbcribers = () => {
   return [
+    ItemSubscriber,
     InventoryAdjustmentsSubscriber,
     BillWriteInventoryTransactionsSubscriber,
     PaymentSyncBillBalance,

packages/server/src/locales/ar.json

@@ -152,7 +152,7 @@
   "Opening Balance Liabilities": "رصيد الالتزامات الافتتاحي",
   "Loan": "اقراض",
   "Owner A Drawings": "مسحوبات المالك",
-  "An account that holds valuation of products or goods that available for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",
+  "An account that holds valuation of products or goods that availiable for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",
   "Tracks the gain and losses of the exchange differences.": "يسجل مكاسب وخسائر فروق الصرف.",
   "Any bank fees levied is recorded into the bank fees and charges account. A bank account maintenance fee, transaction charges, a late payment fee are some examples.": "يتم تسجيل أي رسوم مصرفية يتم فرضها في حساب الرسوم والمصروفات البنكية. ومن الأمثلة على ذلك رسوم صيانة الحساب المصرفي ورسوم المعاملات ورسوم الدفع المتأخر.",
   "The income activities are not associated to the core business.": "لا ترتبط انشطة الدخل إلى الأعمال الأساسية.",

packages/server/src/locales/en.json

@@ -151,7 +151,7 @@
   "Opening Balance Liabilities": "Opening Balance Liabilities",
   "Loan": "Loan",
   "Owner A Drawings": "Owner A Drawings",
-  "An account that holds valuation of products or goods that available for sale.": "An account that holds valuation of products or goods that available for sale.",
+  "An account that holds valuation of products or goods that availiable for sale.": "An account that holds valuation of products or goods that availiable for sale.",
   "Tracks the gain and losses of the exchange differences.": "Tracks the gain and losses of the exchange differences.",
   "Any bank fees levied is recorded into the bank fees and charges account. A bank account maintenance fee, transaction charges, a late payment fee are some examples.": "Any bank fees levied is recorded into the bank fees and charges account. A bank account maintenance fee, transaction charges, a late payment fee are some examples.",
   "The income activities are not associated to the core business.": "The income activities are not associated to the core business.",

packages/server/src/models/Account.ts

@@ -127,7 +127,7 @@ export default class Account extends mixin(TenantModel, [
       },
       filterAccountTypes(query, typesIds) {
         if (typesIds.length > 0) {
-          query.whereIn('account_types.account_type_id', typesIds);
+          query.whereIn('account_types.accoun_type_id', typesIds);
         }
       },
       viewRolesBuilder(query, conditionals, expression) {

packages/server/src/models/AccountTransaction.ts

@@ -2,11 +2,8 @@ import { Model, raw } from 'objection';
 import moment from 'moment';
 import { isEmpty, castArray } from 'lodash';
 import TenantModel from 'models/TenantModel';
-import { getTransactionTypeLabel } from '@/utils/transactions-types';
 
 export default class AccountTransaction extends TenantModel {
-  referenceType: string;
-
   /**
    * Table name
    */
@@ -33,7 +30,40 @@ export default class AccountTransaction extends TenantModel {
    * @return {string}
    */
   get referenceTypeFormatted() {
-    return getTransactionTypeLabel(this.referenceType);
+    return AccountTransaction.getReferenceTypeFormatted(this.referenceType);
+  }
+
+  /**
+   * Reference type formatted.
+   */
+  static getReferenceTypeFormatted(referenceType) {
+    const mapped = {
+      SaleInvoice: 'Sale invoice',
+      SaleReceipt: 'Sale receipt',
+      PaymentReceive: 'Payment receive',
+      Bill: 'Bill',
+      BillPayment: 'Payment made',
+      VendorOpeningBalance: 'Vendor opening balance',
+      CustomerOpeningBalance: 'Customer opening balance',
+      InventoryAdjustment: 'Inventory adjustment',
+      ManualJournal: 'Manual journal',
+      Journal: 'Manual journal',
+      Expense: 'Expense',
+      OwnerContribution: 'Owner contribution',
+      TransferToAccount: 'Transfer to account',
+      TransferFromAccount: 'Transfer from account',
+      OtherIncome: 'Other income',
+      OtherExpense: 'Other expense',
+      OwnerDrawing: 'Owner drawing',
+      InvoiceWriteOff: 'Invoice write-off',
+
+      CreditNote: 'transaction_type.credit_note',
+      VendorCredit: 'transaction_type.vendor_credit',
+
+      RefundCreditNote: 'transaction_type.refund_credit_note',
+      RefundVendorCredit: 'transaction_type.refund_vendor_credit',
+    };
+    return mapped[referenceType] || '';
   }
 
   /**
@@ -59,9 +89,15 @@ export default class AccountTransaction extends TenantModel {
         }
       },
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD';
-        const fromDate = moment(startDate).startOf(type).format(dateFormat);
-        const toDate = moment(endDate).endOf(type).format(dateFormat);
+        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
+        const fromDate = moment(startDate)
+          .utcOffset(0)
+          .startOf(type)
+          .format(dateFormat);
+        const toDate = moment(endDate)
+          .utcOffset(0)
+          .endOf(type)
+          .format(dateFormat);
 
         if (startDate) {
           query.where('date', '>=', fromDate);
@@ -105,6 +141,7 @@ export default class AccountTransaction extends TenantModel {
         query.modify('filterDateRange', null, toDate);
         query.modify('sumationCreditDebit');
       },
+
       contactsOpeningBalance(
         query,
         openingDate,

packages/server/src/models/Bill.ts

@@ -5,7 +5,7 @@ import TenantModel from 'models/TenantModel';
 import BillSettings from './Bill.Settings';
 import ModelSetting from './ModelSetting';
 import CustomViewBaseModel from './CustomViewBaseModel';
-import { DEFAULT_VIEWS } from '@/services/Purchases/Bills/constants';
+import { DEFAULT_VIEWS } from '@/services/Purchases/constants';
 import ModelSearchable from './ModelSearchable';
 
 export default class Bill extends mixin(TenantModel, [

packages/server/src/models/Branch.ts

@@ -97,7 +97,7 @@ export default class Branch extends TenantModel {
       },
 
       /**
-       * Branch may belongs to associated bills.
+       * Branch may belongs to assocaited bills.
        */
       bills: {
         relation: Model.HasManyRelation,

packages/server/src/models/CashflowTransaction.ts

@@ -121,7 +121,7 @@ export default class CashflowTransaction extends TenantModel {
       },
 
       /**
-       * Cashflow transaction may has associated cashflow account.
+       * Cashflow transaction may has assocaited cashflow account.
        */
       cashflowAccount: {
         relation: Model.BelongsToOneRelation,

packages/server/src/models/InventoryCostLotTracker.ts

@@ -33,7 +33,7 @@ export default class InventoryCostLotTracker extends TenantModel {
         query.groupBy('item_id');
       },
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD';
+        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
         const fromDate = moment(startDate).startOf(type).format(dateFormat);
         const toDate = moment(endDate).endOf(type).format(dateFormat);
 

packages/server/src/models/InventoryTransaction.ts

@@ -1,13 +1,9 @@
 import { Model, raw } from 'objection';
-import { castArray } from 'lodash';
+import { castArray, isEmpty } from 'lodash';
 import moment from 'moment';
 import TenantModel from 'models/TenantModel';
-import { getTransactionTypeLabel } from '@/utils/transactions-types';
 
 export default class InventoryTransaction extends TenantModel {
-  transactionId: number;
-  transactionType: string;
-
   /**
    * Table name
    */
@@ -27,7 +23,27 @@ export default class InventoryTransaction extends TenantModel {
    * @return {string}
    */
   get transcationTypeFormatted() {
-    return getTransactionTypeLabel(this.transactionType);
+    return InventoryTransaction.getReferenceTypeFormatted(this.transactionType);
+  }
+
+  /**
+   * Reference type formatted.
+   */
+  static getReferenceTypeFormatted(referenceType) {
+    const mapped = {
+      SaleInvoice: 'Sale invoice',
+      SaleReceipt: 'Sale receipt',
+      PaymentReceive: 'Payment receive',
+      Bill: 'Bill',
+      BillPayment: 'Payment made',
+      VendorOpeningBalance: 'Vendor opening balance',
+      CustomerOpeningBalance: 'Customer opening balance',
+      InventoryAdjustment: 'Inventory adjustment',
+      ManualJournal: 'Manual journal',
+      Journal: 'Manual journal',
+      LandedCost: 'transaction_type.landed_cost',
+    };
+    return mapped[referenceType] || '';
   }
 
   /**
@@ -36,7 +52,7 @@ export default class InventoryTransaction extends TenantModel {
   static get modifiers() {
     return {
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD';
+        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
         const fromDate = moment(startDate).startOf(type).format(dateFormat);
         const toDate = moment(endDate).endOf(type).format(dateFormat);
 

packages/server/src/models/SaleInvoice.ts

@@ -5,7 +5,7 @@ import TenantModel from 'models/TenantModel';
 import ModelSetting from './ModelSetting';
 import SaleInvoiceMeta from './SaleInvoice.Settings';
 import CustomViewBaseModel from './CustomViewBaseModel';
-import { DEFAULT_VIEWS } from '@/services/Sales/Invoices/constants';
+import { DEFAULT_VIEWS } from '@/services/Sales/constants';
 import ModelSearchable from './ModelSearchable';
 
 export default class SaleInvoice extends mixin(TenantModel, [
@@ -176,7 +176,7 @@ export default class SaleInvoice extends mixin(TenantModel, [
        * Filters the invoices between the given date range.
        */
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD';
+        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
         const fromDate = moment(startDate).startOf(type).format(dateFormat);
         const toDate = moment(endDate).endOf(type).format(dateFormat);
 

packages/server/src/models/Warehouse.ts

@@ -84,7 +84,7 @@ export default class Warehouse extends TenantModel {
       },
 
       /**
-       * Warehouse may belongs to associated bills.
+       * Warehouse may belongs to assocaited bills.
        */
       bills: {
         relation: Model.HasManyRelation,

packages/server/src/services/Accounting/AccountsTransactionsWarehousesSubscribe.ts

@@ -1,6 +1,6 @@
 import { Service, Inject } from 'typedi';
 import events from '@/subscribers/events';
-import { InventoryTransactionsWarehouses } from './AccountsTransactionsWarehouses';
+import { InventoryTransactionsWarehouses } from './AcountsTransactionsWarehouses';
 import { IBranchesActivatedPayload } from '@/interfaces';
 
 @Service()

packages/server/src/services/Accounting/JournalPoster.ts

@@ -79,7 +79,7 @@ export default class JournalPoster implements IJournalPoster {
   }
 
   /**
-   * Async initialize accounts dependency graph.
+   * Async initialize acccounts dependency graph.
    * @private
    * @returns {Promise<void>}
    */

packages/server/src/services/Accounting/LedgerContactStorage.ts

@@ -66,14 +66,14 @@ export class LedgerContactsBalanceStorage {
   ): Promise<(entry: ILedgerEntry) => boolean> => {
     const { Account } = this.tenancy.models(tenantId);
 
-    const ARAPAccounts = await Account.query(trx).whereIn('accountType', [
+    const ARAPAcounts = await Account.query(trx).whereIn('accountType', [
       ACCOUNT_TYPE.ACCOUNTS_RECEIVABLE,
       ACCOUNT_TYPE.ACCOUNTS_PAYABLE,
     ]);
-    const ARAPAccountsIds = ARAPAccounts.map((a) => a.id);
+    const ARAPAcountsIds = ARAPAcounts.map((a) => a.id);
 
     return (entry: ILedgerEntry) => {
-      return ARAPAccountsIds.indexOf(entry.accountId) !== -1;
+      return ARAPAcountsIds.indexOf(entry.accountId) !== -1;
     };
   };
 

packages/server/src/services/Accounting/LedgerStorageService.ts

@@ -35,7 +35,7 @@ export default class LedgerStorageService {
       // Saves the ledger entries.
       this.ledgerEntriesService.saveEntries(tenantId, ledger, trx),
 
-      // Mutates the associated accounts balances.
+      // Mutates the assocaited accounts balances.
       this.ledgerAccountsBalance.saveAccountsBalance(tenantId, ledger, trx),
 
       // Mutates the associated contacts balances.
@@ -60,7 +60,7 @@ export default class LedgerStorageService {
       // Deletes the ledger entries.
       this.ledgerEntriesService.deleteEntries(tenantId, ledger, trx),
 
-      // Mutates the associated accounts balances.
+      // Mutates the assocaited accounts balances.
       this.ledgerAccountsBalance.saveAccountsBalance(tenantId, ledger, trx),
 
       // Mutates the associated contacts balances.

packages/server/src/services/Accounting/LedgetAccountStorage.ts

@@ -108,7 +108,7 @@ export class LedegrAccountsStorage {
     const { Account } = this.tenancy.models(tenantId);
     const account = await Account.query(trx).findById(accountId);
 
-    // Filters the ledger entries by the current account.
+    // Filters the ledger entries by the current acount.
     const accountLedger = ledger.whereAccountId(accountId);
 
     // Retrieves the given tenant metadata.

packages/server/src/services/Accounts/AccountTransactionTransformer.ts

@@ -46,7 +46,7 @@ export default class AccountTransactionTransformer extends Transformer {
    * @returns {string}
    */
   public transactionTypeFormatted(transaction: IAccountTransaction) {
-    return this.context.i18n.__(transaction.referenceTypeFormatted);
+    return transaction.referenceTypeFormatted;
   }
 
   /**

packages/server/src/services/Accounts/DeleteAccount.ts

@@ -77,7 +77,7 @@ export class DeleteAccount {
     // Authorize before delete account.
     await this.authorize(tenantId, accountId, oldAccount);
 
-    // Deletes the account and associated transactions under UOW envirement.
+    // Deletes the account and assocaited transactions under UOW envirement.
     return this.uow.withTransaction(tenantId, async (trx: Knex.Transaction) => {
       // Triggers `onAccountDelete` event.
       await this.eventPublisher.emitAsync(events.accounts.onDelete, {

packages/server/src/services/Accounts/GetAccounts.ts

@@ -23,6 +23,15 @@ export class GetAccounts {
   @Inject()
   private transformer: TransformerInjectable;
 
+  /**
+   * Parsees accounts list filter DTO.
+   * @param filterDTO
+   * @returns
+   */
+  private parseListFilterDTO(filterDTO) {
+    return R.compose(this.dynamicListService.parseStringifiedFilter)(filterDTO);
+  }
+
   /**
    * Retrieve accounts datatable list.
    * @param {number} tenantId
@@ -66,13 +75,4 @@ export class GetAccounts {
       filterMeta: dynamicList.getResponseMeta(),
     };
   };
-
-  /**
-   * Parsees accounts list filter DTO.
-   * @param filterDTO
-   * @returns
-   */
-  private parseListFilterDTO(filterDTO) {
-    return R.compose(this.dynamicListService.parseStringifiedFilter)(filterDTO);
-  }
 }

packages/server/src/services/AccountsReceivable/AccountsReceivableRepository.ts

@@ -0,0 +1,9 @@
+
+
+export class AccountsReceivableRepository {
+
+
+  findOrCreateAccount = (currencyCode?: string) => {
+    
+  };
+}

packages/server/src/services/Branches/DeleteBranch.ts

@@ -8,7 +8,6 @@ import { IBranchDeletedPayload, IBranchDeletePayload } from '@/interfaces';
 import { CURDBranch } from './CRUDBranch';
 import { BranchValidator } from './BranchValidate';
 import { ERRORS } from './constants';
-
 @Service()
 export class DeleteBranch extends CURDBranch {
   @Inject()

packages/server/src/services/Branches/Integrations/ValidateBranchExistance.ts

@@ -14,8 +14,8 @@ export class ValidateBranchExistance {
 
   /**
    * Validate transaction branch id when the feature is active.
-   * @param   {number} tenantId
-   * @param   {number} branchId
+   * @param   {number} tenantId 
+   * @param   {number} branchId 
    * @returns {Promise<void>}
    */
   public validateTransactionBranchWhenActive = async (
@@ -32,16 +32,18 @@ export class ValidateBranchExistance {
 
   /**
    * Validate transaction branch id existance.
-   * @param  {number} tenantId
-   * @param  {number} branchId
+   * @param  {number} tenantId 
+   * @param  {number} branchId 
    * @return {Promise<void>}
    */
   public validateTransactionBranch = async (
     tenantId: number,
     branchId: number | null
   ) => {
+    //
     this.validateBranchIdExistance(branchId);
 
+    //
     await this.validateBranchExistance(tenantId, branchId);
   };
 
@@ -60,10 +62,7 @@ export class ValidateBranchExistance {
    * @param tenantId
    * @param branchId
    */
-  public validateBranchExistance = async (
-    tenantId: number,
-    branchId: number
-  ) => {
+  public validateBranchExistance = async (tenantId: number, branchId: number) => {
     const { Branch } = this.tenancy.models(tenantId);
 
     const branch = await Branch.query().findById(branchId);

packages/server/src/services/Branches/Subscribers/Activate/index.ts

@@ -1,4 +1,4 @@
-export * from './CashflowBranchesActivateSubscriber';
+export * from './CashflowBranchesActviateSubscriber';
 export * from './CreditNoteBranchesActivateSubscriber';
 export * from './PaymentMadeBranchesActivateSubscriber';
 export * from './PaymentReceiveBranchesActivateSubscriber';

packages/server/src/services/Cashflow/CommandCasflowValidator.ts

@@ -1,12 +1,17 @@
-import { Service } from 'typedi';
-import { includes, camelCase, upperFirst } from 'lodash';
-import { IAccount } from '@/interfaces';
+import { Service, Inject } from 'typedi';
+import { includes, difference, camelCase, upperFirst } from 'lodash';
+import { ACCOUNT_TYPE } from '@/data/AccountTypes';
+import { IAccount, ICashflowTransactionLine } from '@/interfaces';
 import { getCashflowTransactionType } from './utils';
 import { ServiceError } from '@/exceptions';
 import { CASHFLOW_TRANSACTION_TYPE, ERRORS } from './constants';
+import HasTenancyService from '@/services/Tenancy/TenancyService';
 
 @Service()
 export class CommandCashflowValidator {
+  @Inject()
+  private tenancy: HasTenancyService;
+
   /**
    * Validates the lines accounts type should be cash or bank account.
    * @param {IAccount} accounts -

packages/server/src/services/Cashflow/CommandCashflowTransaction.ts

@@ -0,0 +1,14 @@
+import { difference, includes } from 'lodash';
+import { ICashflowTransactionLine } from '@/interfaces';
+import { ServiceError } from '@/exceptions';
+import { Inject, Service } from 'typedi';
+import { CASHFLOW_TRANSACTION_TYPE, ERRORS } from './constants';
+import { IAccount } from '@/interfaces';
+import HasTenancyService from '@/services/Tenancy/TenancyService';
+
+@Service()
+export default class CommandCashflowTransaction {
+  @Inject()
+  private tenancy: HasTenancyService;
+
+}

packages/server/src/services/Cashflow/utils.ts

@@ -6,7 +6,7 @@ import {
 } from './constants';
 
 /**
- * Ensures the given transaction type to transformed to appropriate format.
+ * Ensures the given transaction type to transformed to properiate format.
  * @param {string} type 
  * @returns {string}
  */

packages/server/src/services/CreditNotes/CreateCreditNote.ts

@@ -16,16 +16,16 @@ import BaseCreditNotes from './CreditNotes';
 @Service()
 export default class CreateCreditNote extends BaseCreditNotes {
   @Inject()
-  private uow: UnitOfWork;
+  uow: UnitOfWork;
 
   @Inject()
-  private itemsEntriesService: ItemsEntriesService;
+  itemsEntriesService: ItemsEntriesService;
 
   @Inject()
-  private tenancy: HasTenancyService;
+  tenancy: HasTenancyService;
 
   @Inject()
-  private eventPublisher: EventPublisher;
+  eventPublisher: EventPublisher;
 
   /**
    * Creates a new credit note.

packages/server/src/services/CreditNotes/CreditNoteApplySyncInvoicesSubscriber.ts

@@ -1,4 +1,5 @@
 import { Service, Inject } from 'typedi';
+import HasTenancyService from '@/services/Tenancy/TenancyService';
 import events from '@/subscribers/events';
 import {
   IApplyCreditToInvoicesCreatedPayload,
@@ -9,12 +10,15 @@ import CreditNoteApplySyncInvoicesCreditedAmount from './CreditNoteApplySyncInvo
 @Service()
 export default class CreditNoteApplySyncInvoicesCreditedAmountSubscriber {
   @Inject()
-  private syncInvoicesWithCreditNote: CreditNoteApplySyncInvoicesCreditedAmount;
+  tenancy: HasTenancyService;
+
+  @Inject()
+  syncInvoicesWithCreditNote: CreditNoteApplySyncInvoicesCreditedAmount;
 
   /**
    * Attaches events with handlers.
    */
-  public attach(bus) {
+  attach(bus) {
     bus.subscribe(
       events.creditNote.onApplyToInvoicesCreated,
       this.incrementAppliedInvoicesOnceCreditCreated

packages/server/src/services/CreditNotes/CreditNoteApplyToInvoices.ts

@@ -1,5 +1,5 @@
 import { Service, Inject } from 'typedi';
-import { Knex } from 'knex';
+import Knex from 'knex';
 import { sumBy } from 'lodash';
 import {
   ICreditNote,
@@ -8,31 +8,27 @@ import {
   ISaleInvoice,
 } from '@/interfaces';
 import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
+import PaymentReceiveService from '@/services/Sales/PaymentReceives/PaymentsReceives';
 import UnitOfWork from '@/services/UnitOfWork';
-import { PaymentReceiveValidators } from '../Sales/PaymentReceives/PaymentReceiveValidators';
+import events from '@/subscribers/events';
 import BaseCreditNotes from './CreditNotes';
 import {
   IApplyCreditToInvoicesDTO,
   IApplyCreditToInvoicesCreatedPayload,
 } from '@/interfaces';
 import { ServiceError } from '@/exceptions';
-import events from '@/subscribers/events';
 import { ERRORS } from './constants';
-import HasTenancyService from '../Tenancy/TenancyService';
 
 @Service()
 export default class CreditNoteApplyToInvoices extends BaseCreditNotes {
-  @Inject()
-  private tenancy: HasTenancyService;
+  @Inject('PaymentReceives')
+  paymentReceive: PaymentReceiveService;
 
   @Inject()
-  private paymentReceiveValidators: PaymentReceiveValidators;
+  uow: UnitOfWork;
 
   @Inject()
-  private uow: UnitOfWork;
-
-  @Inject()
-  private eventPublisher: EventPublisher;
+  eventPublisher: EventPublisher;
 
   /**
    * Apply credit note to the given invoices.
@@ -54,7 +50,7 @@ export default class CreditNoteApplyToInvoices extends BaseCreditNotes {
     );
     // Retrieve the applied invoices that associated to the credit note customer.
     const appliedInvoicesEntries =
-      await this.paymentReceiveValidators.validateInvoicesIDsExistance(
+      await this.paymentReceive.validateInvoicesIDsExistance(
         tenantId,
         creditNote.customerId,
         applyCreditToInvoicesDTO.entries

packages/server/src/services/CreditNotes/CreditNoteInventoryTransactionsSubscriber.ts

@@ -15,7 +15,7 @@ export default class CreditNoteInventoryTransactionsSubscriber {
   /**
    * Attaches events with publisher.
    */
-  public attach(bus) {
+  attach(bus) {
     bus.subscribe(
       events.creditNote.onCreated,
       this.writeInventoryTranscationsOnceCreated
@@ -37,7 +37,6 @@ export default class CreditNoteInventoryTransactionsSubscriber {
   /**
    * Writes inventory transactions once credit note created.
    * @param {ICreditNoteCreatedPayload} payload -
-   * @returns {Promise<void>}
    */
   public writeInventoryTranscationsOnceCreated = async ({
     tenantId,
@@ -45,8 +44,9 @@ export default class CreditNoteInventoryTransactionsSubscriber {
     trx,
   }: ICreditNoteCreatedPayload) => {
     // Can't continue if the credit note is open yet.
-    if (!creditNote.isOpen) return;
-
+    if (!creditNote.isOpen) {
+      return;
+    }
     await this.inventoryTransactions.createInventoryTransactions(
       tenantId,
       creditNote,
@@ -57,7 +57,6 @@ export default class CreditNoteInventoryTransactionsSubscriber {
   /**
    * Rewrites inventory transactions once credit note edited.
    * @param {ICreditNoteEditedPayload} payload -
-   * @returns {Promise<void>}
    */
   public rewriteInventoryTransactionsOnceEdited = async ({
     tenantId,
@@ -66,8 +65,9 @@ export default class CreditNoteInventoryTransactionsSubscriber {
     trx,
   }: ICreditNoteEditedPayload) => {
     // Can't continue if the credit note is open yet.
-    if (!creditNote.isOpen) return;
-
+    if (!creditNote.isOpen) {
+      return;
+    }
     await this.inventoryTransactions.editInventoryTransactions(
       tenantId,
       creditNoteId,
@@ -87,8 +87,9 @@ export default class CreditNoteInventoryTransactionsSubscriber {
     trx,
   }: ICreditNoteDeletedPayload) => {
     // Can't continue if the credit note is open yet.
-    if (!oldCreditNote.isOpen) return;
-
+    if (!oldCreditNote.isOpen) {
+      return;
+    }
     await this.inventoryTransactions.deleteInventoryTransactions(
       tenantId,
       creditNoteId,

packages/server/src/services/CreditNotes/CreditNotesInventoryTransactions.ts

@@ -49,7 +49,7 @@ export default class CreditNoteInventoryTransactions {
   };
 
   /**
-   * Edits vendor credit associated inventory transactions.
+   * Edits vendor credit assocaited inventory transactions.
    * @param {number} tenantId
    * @param {number} creditNoteId
    * @param {ICreditNote} creditNote

packages/server/src/services/CreditNotes/DeleteCreditNoteApplyToInvoices.ts

@@ -1,24 +1,24 @@
 import { Service, Inject } from 'typedi';
-import { Knex } from 'knex';
+import Knex from 'knex';
 import { IApplyCreditToInvoicesDeletedPayload } from '@/interfaces';
 import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
+import PaymentReceiveService from '@/services/Sales/PaymentReceives/PaymentsReceives';
 import UnitOfWork from '@/services/UnitOfWork';
 import events from '@/subscribers/events';
 import BaseCreditNotes from './CreditNotes';
 import { ServiceError } from '@/exceptions';
 import { ERRORS } from './constants';
-import HasTenancyService from '../Tenancy/TenancyService';
 
 @Service()
 export default class DeletreCreditNoteApplyToInvoices extends BaseCreditNotes {
-  @Inject()
-  private uow: UnitOfWork;
+  @Inject('PaymentReceives')
+  paymentReceive: PaymentReceiveService;
 
   @Inject()
-  private eventPublisher: EventPublisher;
+  uow: UnitOfWork;
 
   @Inject()
-  private tenancy: HasTenancyService;
+  eventPublisher: EventPublisher;
 
   /**
    * Apply credit note to the given invoices.

packages/server/src/services/CreditNotes/DeleteCustomerLinkedCreditSubscriber.ts

@@ -29,7 +29,7 @@ export default class DeleteCustomerLinkedCreditSubscriber {
   };
 
   /**
-   * Validate vendor has no associated credit transaction once the vendor deleting.
+   * Validate vendor has no assocaited credit transaction once the vendor deleting.
    * @param {IVendorEventDeletingPayload} payload -
    */
   public validateCustomerHasNoLinkedCreditsOnDeleting = async ({

packages/server/src/services/DynamicListing/DynamicListAbstract.ts

@@ -1,6 +0,0 @@
-
-
-
-export default class DynamicListAbstract {
-    
-}

packages/server/src/services/DynamicListing/DynamicListAbstruct.ts

@@ -0,0 +1,6 @@
+
+
+
+export default class DynamicListAbstruct {
+    
+}

packages/server/src/services/DynamicListing/DynamicListCustomView.ts

@@ -1,5 +1,5 @@
 import { Inject, Service } from 'typedi';
-import DynamicListAbstract from './DynamicListAbstract';
+import DynamicListAbstruct from './DynamicListAbstruct';
 import DynamicFilterViews from '@/lib/DynamicFilter/DynamicFilterViews';
 import { ServiceError } from '@/exceptions';
 import HasTenancyService from '@/services/Tenancy/TenancyService';
@@ -7,7 +7,7 @@ import { ERRORS } from './constants';
 import { IModel } from '@/interfaces';
 
 @Service()
-export default class DynamicListCustomView extends DynamicListAbstract {
+export default class DynamicListCustomView extends DynamicListAbstruct {
   @Inject()
   tenancy: HasTenancyService;
 

packages/server/src/services/DynamicListing/DynamicListFilterRoles.ts

@@ -2,13 +2,13 @@ import { Service } from 'typedi';
 import * as R from 'ramda';
 import validator from 'is-my-json-valid';
 import { IFilterRole, IModel } from '@/interfaces';
-import DynamicListAbstract from './DynamicListAbstract';
+import DynamicListAbstruct from './DynamicListAbstruct';
 import DynamicFilterAdvancedFilter from '@/lib/DynamicFilter/DynamicFilterAdvancedFilter';
 import { ERRORS } from './constants';
 import { ServiceError } from '@/exceptions';
 
 @Service()
-export default class DynamicListFilterRoles extends DynamicListAbstract {
+export default class DynamicListFilterRoles extends DynamicListAbstruct {
   /**
    * Validates filter roles schema.
    * @param {IFilterRole[]} filterRoles - Filter roles.

packages/server/src/services/DynamicListing/DynamicListSearch.ts

@@ -1,11 +1,11 @@
 import { Service } from 'typedi';
 import { IFilterRole, IModel } from '@/interfaces';
-import DynamicListAbstract from './DynamicListAbstract';
+import DynamicListAbstruct from './DynamicListAbstruct';
 import DynamicFilterFilterRoles from '@/lib/DynamicFilter/DynamicFilterFilterRoles';
 import DynamicFilterSearch from '@/lib/DynamicFilter/DynamicFilterSearch';
 
 @Service()
-export default class DynamicListSearch extends DynamicListAbstract {
+export default class DynamicListSearch extends DynamicListAbstruct {
   /**
    * Dynamic list filter roles.
    * @param {IModel} model

packages/server/src/services/DynamicListing/DynamicListSortBy.ts

@@ -1,12 +1,12 @@
 import { Service } from 'typedi';
-import DynamicListAbstract from './DynamicListAbstract';
+import DynamicListAbstruct from './DynamicListAbstruct';
 import DynamicFilterSortBy from '@/lib/DynamicFilter/DynamicFilterSortBy';
 import { IModel, ISortOrder } from '@/interfaces';
 import { ServiceError } from '@/exceptions';
 import { ERRORS } from './constants';
 
 @Service()
-export default class DynamicListSortBy extends DynamicListAbstract {
+export default class DynamicListSortBy extends DynamicListAbstruct {
   /**
    * Dynamic list sort by.
    * @param {IModel} model

packages/server/src/services/Expenses/ExpenseGLEntriesSubscriber.ts

@@ -21,7 +21,7 @@ export class ExpensesWriteGLSubscriber {
    * Attaches events with handlers.
    * @param bus
    */
-  public attach(bus) {
+  attach(bus) {
     bus.subscribe(
       events.expenses.onCreated,
       this.handleWriteGLEntriesOnceCreated

packages/server/src/services/Features/FeaturesManager.ts

@@ -34,7 +34,7 @@ export class FeaturesManager {
   }
 
   /**
-   * Detarmines the given feature name is accessible.
+   * Detarmines the given feature name is accessiable.
    * @param   {number} tenantId
    * @param   {string} feature
    * @returns {Promise<void>}

packages/server/src/services/Features/FeaturesSettingsDriver.ts

@@ -33,7 +33,7 @@ export class FeaturesSettingsDriver {
   }
 
   /**
-   * Detarmines the given feature name is accessible.
+   * Detarmines the given feature name is accessiable.
    * @param   {number} tenantId
    * @param   {string} feature
    * @returns {Promise<boolean|null|undefined>}

packages/server/src/services/FinancialStatements/AgingSummary/APAgingSummaryService.ts

@@ -5,7 +5,6 @@ import TenancyService from '@/services/Tenancy/TenancyService';
 import APAgingSummarySheet from './APAgingSummarySheet';
 import { Tenant } from '@/system/models';
 import { isEmpty } from 'lodash';
-import APAgingSummaryTable from './APAgingSummaryTable';
 
 @Service()
 export default class PayableAgingSummaryService {
@@ -85,7 +84,7 @@ export default class PayableAgingSummaryService {
 
     // Common query.
     const commonQuery = (query) => {
-      if (!isEmpty(filter.branchesIds)) {
+      if (isEmpty(filter.branchesIds)) {
         query.modify('filterByBranches', filter.branchesIds);
       }
     };
@@ -119,21 +118,4 @@ export default class PayableAgingSummaryService {
       meta: this.reportMetadata(tenantId),
     };
   }
-
-  /**
-   * Retrieves A/P aging summary in table format.
-   * @param {number} tenantId
-   * @param {IAPAgingSummaryQuery} query
-   */
-  async APAgingSummaryTable(tenantId: number, query: IAPAgingSummaryQuery) {
-    const report = await this.APAgingSummary(tenantId, query);
-    const table = new APAgingSummaryTable(report.data, query, {});
-
-    return {
-      columns: table.tableColumns(),
-      rows: table.tableRows(),
-      meta: report.meta,
-      query: report.query,
-    };
-  }
 }

packages/server/src/services/FinancialStatements/AgingSummary/APAgingSummarySheet.ts

@@ -91,7 +91,7 @@ export default class APAgingSummarySheet extends AgingSummaryReport {
 
     return {
       vendorName: vendor.displayName,
-      current: this.formatAmount(currentTotal),
+      current: this.formatTotalAmount(currentTotal),
       aging: agingPeriods,
       total: this.formatTotalAmount(amount),
     };

packages/server/src/services/FinancialStatements/AgingSummary/APAgingSummaryTable.ts

@@ -1,46 +0,0 @@
-import {
-  IAPAgingSummaryData,
-  IAgingSummaryQuery,
-  ITableColumn,
-  ITableColumnAccessor,
-  ITableRow,
-} from '@/interfaces';
-import AgingSummaryTable from './AgingSummaryTable';
-
-export default class APAgingSummaryTable extends AgingSummaryTable {
-  readonly report: IAPAgingSummaryData;
-
-  /**
-   * Constructor method.
-   * @param {IARAgingSummaryData} data
-   * @param {IAgingSummaryQuery} query
-   * @param {any} i18n
-   */
-  constructor(data: IAPAgingSummaryData, query: IAgingSummaryQuery, i18n: any) {
-    super(data, query, i18n);
-  }
-
-  /**
-   * Retrieves the contacts table rows.
-   * @returns {ITableRow[]}
-   */
-  get contactsRows(): ITableRow[] {
-    return this.contactsNodes(this.report.vendors);
-  }
-
-  /**
-   * Contact name node accessor.
-   * @returns {ITableColumnAccessor}
-   */
-  get contactNameNodeAccessor(): ITableColumnAccessor {
-    return { key: 'vendor_name', accessor: 'vendorName' };
-  }
-
-  /**
-   * Retrieves the contact name table column.
-   * @returns {ITableColumn}
-   */
-  contactNameTableColumn = (): ITableColumn => {
-    return { label: 'Vendor name', key: 'vendor_name' };
-  };
-}

packages/server/src/services/FinancialStatements/AgingSummary/ARAgingSummaryService.ts

@@ -5,7 +5,6 @@ import { IARAgingSummaryQuery, IARAgingSummaryMeta } from '@/interfaces';
 import TenancyService from '@/services/Tenancy/TenancyService';
 import ARAgingSummarySheet from './ARAgingSummarySheet';
 import { Tenant } from '@/system/models';
-import ARAgingSummaryTable from './ARAgingSummaryTable';
 
 @Service()
 export default class ARAgingSummaryService {
@@ -90,12 +89,12 @@ export default class ARAgingSummaryService {
     };
     // Retrieve all overdue sale invoices.
     const overdueSaleInvoices = await SaleInvoice.query()
-      .modify('overdueInvoicesFromDate', filter.asDate)
+      .modify('dueInvoicesFromDate', filter.asDate)
       .onBuild(commonQuery);
 
     // Retrieve all due sale invoices.
     const currentInvoices = await SaleInvoice.query()
-      .modify('dueInvoicesFromDate', filter.asDate)
+      .modify('overdueInvoicesFromDate', filter.asDate)
       .onBuild(commonQuery);
 
     // AR aging summary report instance.
@@ -118,21 +117,4 @@ export default class ARAgingSummaryService {
       meta: this.reportMetadata(tenantId),
     };
   }
-
-  /**
-   * Retrieves A/R aging summary in table format.
-   * @param {number} tenantId
-   * @param {IARAgingSummaryQuery} query
-   */
-  async ARAgingSummaryTable(tenantId: number, query: IARAgingSummaryQuery) {
-    const report = await this.ARAgingSummary(tenantId, query);
-    const table = new ARAgingSummaryTable(report.data, query, {});
-
-    return {
-      columns: table.tableColumns(),
-      rows: table.tableRows(),
-      meta: report.meta,
-      query,
-    };
-  }
 }

packages/server/src/services/FinancialStatements/AgingSummary/ARAgingSummarySheet.ts

@@ -1,4 +1,4 @@
-import { Dictionary, groupBy, isEmpty, sum } from 'lodash';
+import { groupBy, isEmpty, sum } from 'lodash';
 import * as R from 'ramda';
 import {
   ICustomer,
@@ -54,6 +54,7 @@ export default class ARAgingSummarySheet extends AgingSummaryReport {
       currentSaleInvoices,
       'customerId'
     );
+
     // Initializes the aging periods.
     this.agingPeriods = this.agingRangePeriods(
       this.query.asDate,
@@ -188,7 +189,7 @@ export default class ARAgingSummarySheet extends AgingSummaryReport {
   };
 
   /**
-   * Retrieve A/R aging summary report columns.
+   * Retrieve AR aging summary report columns.
    * @return {IARAgingSummaryColumns}
    */
   public reportColumns(): IARAgingSummaryColumns {

packages/server/src/services/FinancialStatements/AgingSummary/ARAgingSummaryTable.ts

@@ -1,38 +0,0 @@
-import {
-  IARAgingSummaryData,
-  IAgingSummaryData,
-  IAgingSummaryQuery,
-  ITableColumnAccessor,
-  ITableRow,
-} from '@/interfaces';
-import AgingSummaryTable from './AgingSummaryTable';
-
-export default class ARAgingSummaryTable extends AgingSummaryTable {
-  readonly report: IARAgingSummaryData;
-
-  /**
-   * Constructor method.
-   * @param {IARAgingSummaryData} data
-   * @param {IAgingSummaryQuery} query
-   * @param {any} i18n
-   */
-  constructor(data: IARAgingSummaryData, query: IAgingSummaryQuery, i18n: any) {
-    super(data, query, i18n);
-  }
-
-  /**
-   * Retrieves the contacts table rows.
-   * @returns {ITableRow[]}
-   */
-  get contactsRows(): ITableRow[] {
-    return this.contactsNodes(this.report.customers);
-  }
-
-  /**
-   * Contact name node accessor.
-   * @returns {ITableColumnAccessor}
-   */
-  get contactNameNodeAccessor(): ITableColumnAccessor {
-    return { key: 'customer_name', accessor: 'customerName' };
-  }
-}

packages/server/src/services/FinancialStatements/AgingSummary/AgingSummaryTable.ts

@@ -1,211 +0,0 @@
-import * as R from 'ramda';
-import {
-  IAgingPeriod,
-  IAgingSummaryContact,
-  IAgingSummaryData,
-  IAgingSummaryQuery,
-  IAgingSummaryTotal,
-  ITableColumn,
-  ITableColumnAccessor,
-  ITableRow,
-} from '@/interfaces';
-import { tableRowMapper } from '@/utils';
-import AgingReport from './AgingReport';
-import { AgingSummaryRowType } from './_constants';
-import { FinancialTable } from '../FinancialTable';
-import { FinancialSheetStructure } from '../FinancialSheetStructure';
-
-export default abstract class AgingSummaryTable extends R.compose(
-  FinancialSheetStructure,
-  FinancialTable
-)(AgingReport) {
-  protected readonly report: IAgingSummaryData;
-  protected readonly query: IAgingSummaryQuery;
-  protected readonly agingPeriods: IAgingPeriod[];
-  protected readonly i18n: any;
-
-  /**
-   * Constructor method.
-   * @param {IARAgingSummaryData} data
-   * @param {IAgingSummaryQuery} query
-   * @param {any} i18n
-   */
-  constructor(data: IAgingSummaryData, query: IAgingSummaryQuery, i18n: any) {
-    super();
-
-    this.report = data;
-    this.i18n = i18n;
-    this.query = query;
-
-    this.agingPeriods = this.agingRangePeriods(
-      this.query.asDate,
-      this.query.agingDaysBefore,
-      this.query.agingPeriods
-    );
-  }
-
-  // -------------------------
-  // # Accessors.
-  // -------------------------
-  /**
-   * Aging accessors of contact and total nodes.
-   * @param {IAgingSummaryContact | IAgingSummaryTotal} node
-   * @returns {ITableColumnAccessor[]}
-   */
-  protected agingNodeAccessors = (
-    node: IAgingSummaryContact | IAgingSummaryTotal
-  ): ITableColumnAccessor[] => {
-    return node.aging.map((aging, index) => ({
-      key: 'aging',
-      accessor: `aging[${index}].total.formattedAmount`,
-    }));
-  };
-
-  /**
-   * Contact name node accessor.
-   * @returns {ITableColumnAccessor}
-   */
-  protected get contactNameNodeAccessor(): ITableColumnAccessor {
-    return { key: 'customer_name', accessor: 'customerName' };
-  }
-
-  /**
-   * Retrieves the common columns for all report nodes.
-   * @param {IAgingSummaryContact}
-   * @returns {ITableColumnAccessor[]}
-   */
-  protected contactNodeAccessors = (
-    node: IAgingSummaryContact
-  ): ITableColumnAccessor[] => {
-    return R.compose(
-      R.concat([
-        this.contactNameNodeAccessor,
-        { key: 'current', accessor: 'current.formattedAmount' },
-        ...this.agingNodeAccessors(node),
-        { key: 'total', accessor: 'total.formattedAmount' },
-      ])
-    )([]);
-  };
-
-  /**
-   * Retrieves the contact name table row.
-   * @param {IAgingSummaryContact} node -
-   * @return {ITableRow}
-   */
-  protected contactNameNode = (node: IAgingSummaryContact): ITableRow => {
-    const columns = this.contactNodeAccessors(node);
-    const meta = {
-      rowTypes: [AgingSummaryRowType.Contact],
-    };
-    return tableRowMapper(node, columns, meta);
-  };
-
-  /**
-   * Maps the customers nodes to table rows.
-   * @param {IAgingSummaryContact[]} nodes
-   * @returns {ITableRow[]}
-   */
-  protected contactsNodes = (nodes: IAgingSummaryContact[]): ITableRow[] => {
-    return nodes.map(this.contactNameNode);
-  };
-
-  /**
-   * Retrieves the common columns for all report nodes.
-   * @param {IAgingSummaryTotal}
-   * @returns {ITableColumnAccessor[]}
-   */
-  protected totalNodeAccessors = (
-    node: IAgingSummaryTotal
-  ): ITableColumnAccessor[] => {
-    return R.compose(
-      R.concat([
-        { key: 'blank', value: '' },
-        { key: 'current', accessor: 'current.formattedAmount' },
-        ...this.agingNodeAccessors(node),
-        { key: 'total', accessor: 'total.formattedAmount' },
-      ])
-    )([]);
-  };
-
-  /**
-   * Retrieves the total row of the given report total node.
-   * @param {IAgingSummaryTotal} node
-   * @returns {ITableRow}
-   */
-  protected totalNode = (node: IAgingSummaryTotal): ITableRow => {
-    const columns = this.totalNodeAccessors(node);
-    const meta = {
-      rowTypes: [AgingSummaryRowType.Total],
-    };
-    return tableRowMapper(node, columns, meta);
-  };
-
-  // -------------------------
-  // # Computed Rows.
-  // -------------------------
-  /**
-   * Retrieves the contacts table rows.
-   * @returns {ITableRow[]}
-   */
-  protected get contactsRows(): ITableRow[] {
-    return [];
-  }
-
-  /**
-   * Table total row.
-   * @returns {ITableRow}
-   */
-  protected get totalRow(): ITableRow {
-    return this.totalNode(this.report.total);
-  }
-
-  /**
-   * Retrieves the table rows.
-   * @returns {ITableRow[]}
-   */
-  public tableRows = (): ITableRow[] => {
-    return R.compose(
-      R.unless(R.isEmpty, R.append(this.totalRow)),
-      R.concat(this.contactsRows)
-    )([]);
-  };
-
-  // -------------------------
-  // # Columns.
-  // -------------------------
-  /**
-   * Retrieves the aging table columns.
-   * @returns {ITableColumn[]}
-   */
-  protected agingTableColumns = (): ITableColumn[] => {
-    return this.agingPeriods.map((agingPeriod) => {
-      return {
-        label: `${agingPeriod.beforeDays} - ${
-          agingPeriod.toDays || 'And Over'
-        }`,
-        key: 'aging_period',
-      };
-    });
-  };
-
-  /**
-   * Retrieves the contact name table column.
-   * @returns {ITableColumn}
-   */
-  protected contactNameTableColumn = (): ITableColumn => {
-    return { label: 'Customer name', key: 'customer_name' };
-  };
-
-  /**
-   * Retrieves the report columns.
-   * @returns {ITableColumn}
-   */
-  public tableColumns = (): ITableColumn[] => {
-    return R.compose(this.tableColumnsCellIndexing)([
-      this.contactNameTableColumn(),
-      { label: 'Current', key: 'current' },
-      ...this.agingTableColumns(),
-      { label: 'Total', key: 'total' },
-    ]);
-  };
-}

packages/server/src/services/FinancialStatements/AgingSummary/_constants.ts

@@ -1,4 +0,0 @@
-export enum AgingSummaryRowType {
-  Contact = 'contact',
-  Total = 'total',
-}

packages/server/src/services/FinancialStatements/BalanceSheet/BalanceSheetService.ts

@@ -37,7 +37,7 @@ export default class BalanceSheetStatementService
       displayColumnsBy: 'month',
 
       fromDate: moment().startOf('year').format('YYYY-MM-DD'),
-      toDate: moment().format('YYYY-MM-DD'),
+      toDate: moment().endOf('year').format('YYYY-MM-DD'),
 
       numberFormat: {
         precision: 2,

packages/server/src/services/FinancialStatements/CashFlow/CashFlow.ts

@@ -197,7 +197,7 @@ export default class CashFlowStatement extends compose(
       code: account.code,
       label: account.name,
       accountType: account.accountType,
-      adjustmentType: relation.direction,
+      adjusmentType: relation.direction,
       total: this.getAmountMeta(closingBalance),
       sectionType: ICashFlowStatementSectionType.ACCOUNT,
     };
@@ -362,14 +362,14 @@ export default class CashFlowStatement extends compose(
   /**
    * Retrieve the total section from the eqauation parser.
    * @param   {ICashFlowSchemaTotalSection} sectionSchema
-   * @param   {ICashFlowSchemaSection[]} accumulatedSections
+   * @param   {ICashFlowSchemaSection[]} accumlatedSections
    * @returns {ICashFlowStatementTotalSection}
    */
   private totalEquationSectionParser = (
-    accumulatedSections: ICashFlowSchemaSection[],
+    accumlatedSections: ICashFlowSchemaSection[],
     sectionSchema: ICashFlowSchemaTotalSection
   ): ICashFlowStatementTotalSection => {
-    const mappedSectionsById = this.transformSectionsToMap(accumulatedSections);
+    const mappedSectionsById = this.transformSectionsToMap(accumlatedSections);
     const nodesTotalById = this.sectionsMapToTotal(mappedSectionsById);
 
     const total = this.evaluateEquation(sectionSchema.equation, nodesTotalById);
@@ -421,7 +421,7 @@ export default class CashFlowStatement extends compose(
       code: account.code,
       label: account.name,
       accountType: account.accountType,
-      adjustmentType: relation.direction,
+      adjusmentType: relation.direction,
       total: this.getAmountMeta(closingBalance),
       sectionType: ICashFlowStatementSectionType.ACCOUNT,
     };
@@ -524,7 +524,7 @@ export default class CashFlowStatement extends compose(
    * @param   {ICashFlowSchemaSection | ICashFlowStatementSection} section
    * @param   {number} key
    * @param   {ICashFlowSchemaSection[]} parentValue
-   * @param   {(ICashFlowSchemaSection | ICashFlowStatementSection)[]} accumulatedSections
+   * @param   {(ICashFlowSchemaSection | ICashFlowStatementSection)[]} accumlatedSections
    * @returns {ICashFlowSchemaSection}
    */
   private schemaSectionTotalParser = (
@@ -532,13 +532,13 @@ export default class CashFlowStatement extends compose(
     key: number,
     parentValue: ICashFlowSchemaSection[],
     context,
-    accumulatedSections: (ICashFlowSchemaSection | ICashFlowStatementSection)[]
+    accumlatedSections: (ICashFlowSchemaSection | ICashFlowStatementSection)[]
   ): ICashFlowSchemaSection | ICashFlowStatementSection => {
     return R.compose(
       // Total equation section.
       R.when(
         this.isSchemaSectionType(ICashFlowStatementSectionType.TOTAL),
-        R.curry(this.totalEquationSectionParser)(accumulatedSections)
+        R.curry(this.totalEquationSectionParser)(accumlatedSections)
       )
     )(section);
   };

packages/server/src/services/FinancialStatements/CashFlow/CashFlowDatePeriods.ts

@@ -165,7 +165,7 @@ export const CashFlowStatementDatePeriods = (Base) =>
         .whereAccountId(node.id)
         .getClosingBalance();
 
-      return this.amountAdjustment(node.adjustmentType, closingBalance);
+      return this.amountAdjustment(node.adjusmentType, closingBalance);
     };
 
     /**
@@ -322,7 +322,7 @@ export const CashFlowStatementDatePeriods = (Base) =>
     // Cash at beginning ----------------------
 
     /**
-     * Retrieve the date preioods of the given node and accumulated function.
+     * Retrieve the date preioods of the given node and accumlated function.
      * @param {} node
      * @param {}
      * @return {}

packages/server/src/services/FinancialStatements/CashFlow/CashFlowService.ts

@@ -40,7 +40,7 @@ export default class CashFlowStatementService
       displayColumnsType: 'total',
       displayColumnsBy: 'day',
       fromDate: moment().startOf('year').format('YYYY-MM-DD'),
-      toDate: moment().format('YYYY-MM-DD'),
+      toDate: moment().endOf('year').format('YYYY-MM-DD'),
       numberFormat: {
         precision: 2,
         divideOn1000: false,

packages/server/src/services/FinancialStatements/CashflowAccountTransactions/CashflowAccountTransactionsService.ts

@@ -41,7 +41,7 @@ export default class CashflowAccountTransactionsService extends FinancialSheet {
   }
 
   /**
-   * Retrieve the cashflow account transactions report data.
+   * Retrieve the cashflow accouynt transactions report data.
    * @param {number} tenantId -
    * @param {ICashflowAccountTransactionsQuery} query -
    * @return {Promise<IInvetoryItemDetailDOO>}

packages/server/src/services/FinancialStatements/FinancialDatePeriods.ts

@@ -64,7 +64,7 @@ export const FinancialDatePeriods = (Base) =>
     };
 
     /**
-     * Retrieve the date preioods of the given node and accumulated function.
+     * Retrieve the date preioods of the given node and accumlated function.
      * @param  {IBalanceSheetAccountNode} node
      * @param  {(fromDate: Date, toDate: Date, index: number) => any}
      * @return {}

packages/server/src/services/FinancialStatements/FinancialTable.ts

@@ -12,7 +12,7 @@ export const FinancialTable = (Base) =>
      * @param   {ITableColumn[]} columns
      * @returns {ITableColumn[]}
      */
-    public tableColumnsCellIndexing = (
+    protected tableColumnsCellIndexing = (
       columns: ITableColumn[]
     ): ITableColumn[] => {
       const cellIndex = increment(-1);

packages/server/src/services/FinancialStatements/GeneralLedger/GeneralLedgerService.ts

@@ -31,8 +31,8 @@ export default class GeneralLedgerService {
    */
   get defaultQuery() {
     return {
-      fromDate: moment().startOf('month').format('YYYY-MM-DD'),
-      toDate: moment().format('YYYY-MM-DD'),
+      fromDate: moment().startOf('year').format('YYYY-MM-DD'),
+      toDate: moment().endOf('year').format('YYYY-MM-DD'),
       basis: 'cash',
       numberFormat: {
         noCents: false,

packages/server/src/services/FinancialStatements/InventoryDetails/InventoryDetails.ts

@@ -126,7 +126,7 @@ export default class InventoryDetails extends FinancialSheet {
   );
 
   /**
-   * Accumulate and mapping running quantity on transactions.
+   * Accumlate and mapping running quantity on transactions.
    * @param {IInventoryDetailsItemTransaction[]} transactions
    * @returns {IInventoryDetailsItemTransaction[]}
    */
@@ -150,7 +150,7 @@ export default class InventoryDetails extends FinancialSheet {
   }
 
   /**
-   * Accumulate and mapping running valuation on transactions.
+   * Accumlate and mapping running valuation on transactions.
    * @param {IInventoryDetailsItemTransaction[]} transactions
    * @returns {IInventoryDetailsItemTransaction}
    */
@@ -160,8 +160,8 @@ export default class InventoryDetails extends FinancialSheet {
     const initial = this.getNumberMeta(0);
 
     const mapAccumAppender = (a, b) => {
-      const adjustment = b.direction === 'OUT' ? -1 : 1;
-      const total = a.runningValuation.number + b.cost.number * adjustment;
+      const adjusmtent = b.direction === 'OUT' ? -1 : 1;
+      const total = a.runningValuation.number + b.cost.number * adjusmtent;
       const totalMeta = this.getNumberMeta(total, { excerptZero: false });
       const accum = { ...b, runningValuation: totalMeta };
 

packages/server/src/services/FinancialStatements/InventoryDetails/InventoryDetailsService.ts

@@ -16,13 +16,13 @@ import { Tenant } from '@/system/models';
 @Service()
 export default class InventoryDetailsService extends FinancialSheet {
   @Inject()
-  private tenancy: TenancyService;
+  tenancy: TenancyService;
 
   @Inject()
-  private reportRepo: InventoryDetailsRepository;
+  reportRepo: InventoryDetailsRepository;
 
   @Inject()
-  private inventoryService: InventoryService;
+  inventoryService: InventoryService;
 
   /**
    * Defaults balance sheet filter query.
@@ -30,8 +30,8 @@ export default class InventoryDetailsService extends FinancialSheet {
    */
   private get defaultQuery(): IInventoryDetailsQuery {
     return {
-      fromDate: moment().startOf('month').format('YYYY-MM-DD'),
-      toDate: moment().format('YYYY-MM-DD'),
+      fromDate: moment().startOf('year').format('YYYY-MM-DD'),
+      toDate: moment().endOf('year').format('YYYY-MM-DD'),
       itemsIds: [],
       numberFormat: {
         precision: 2,

packages/server/src/services/FinancialStatements/InventoryValuationSheet/InventoryValuationSheetService.ts

@@ -27,7 +27,7 @@ export default class InventoryValuationSheetService {
    */
   get defaultQuery(): IInventoryValuationReportQuery {
     return {
-      asDate: moment().format('YYYY-MM-DD'),
+      asDate: moment().endOf('year').format('YYYY-MM-DD'),
       itemsIds: [],
       numberFormat: {
         precision: 2,