fix(AlteredSliceTag): not display undefined filter value for chart change record (#38883)

Signed-off-by: hainenber <dotronghai96@gmail.com>
This commit is contained in:
Đỗ Trọng Hải
2026-03-31 20:38:22 +07:00
committed by GitHub
parent f1cd1ae710
commit 11f2140c37
2 changed files with 28 additions and 1 deletions

View File

@@ -52,7 +52,7 @@ export const formatValueHandler = (
v.comparator && v.comparator.constructor === Array
? `[${v.comparator.join(', ')}]`
: v.comparator;
return `${v.subject} ${v.operator} ${filterVal}`;
return filterVal ? `${v.subject} ${v.operator} ${filterVal}` : `${v.subject} ${v.operator}`;
})
.join(', ');
}

View File

@@ -258,6 +258,33 @@ describe('formatValueHandler', () => {
expect(result).toEqual(expected);
});
test('formats unary filter', () => {
const filters = [
{
expressionType: 'SIMPLE',
operator: 'IS NULL',
subject: 'a',
},
{
clause: 'WHERE',
comparator: ['hu', 'ho', 'ha'],
expressionType: 'SIMPLE',
operator: 'NOT IN',
subject: 'b',
},
];
const key = 'adhoc_filters';
const expected = 'a IS NULL, b NOT IN [hu, ho, ha]';
const formattedValue: string | number = formatValueHandler(
filters,
key,
controlsMap,
);
expect(formattedValue).toEqual(expected);
});
});
// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks