QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-21 15:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(SqlLab): retry fetchQueryResults when resultsKey changes

Browse Source 
Replaces the one-shot hasRunInitialEffect mount guard in TabbedSqlEditors
with a fetchedResultsKeyRef that records the last persisted resultsKey
fetched. The old guard permanently blocked the effect once it ran, so when
activeQueryEditor was unavailable on first render (common when tabHistory
hydrates asynchronously), persisted results were never fetched. Tracking
resultsKey lets the effect retry when it resolves and dedupes repeats.

Addresses codeant-ai review on PR #39461.
This commit is contained in:
Evan Rusackas
2026-04-22 16:02:55 -07:00
committed by Claude
parent 37538a81a4
commit 26fcd6bcbb
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx
View File

@@ -114,21 +114,23 @@ function TabbedSqlEditors({
return queryEditors.find(qe => qe.id === qeid) || null;
}, [tabHistory, queryEditors]);
// Track whether the initial mount effect has run
const hasRunInitialEffect = useRef(false);
// Track the last persisted resultsKey we fetched, so the effect retries when
// the active query editor resolves after mount (or its latest query changes)
// but dedupes when the same resultsKey has already been fetched.
const fetchedResultsKeyRef = useRef<string | null>(null);
// Fetch query results on initial mount if needed (equivalent to componentDidMount)
// Fetch query results for the active editor's latest query when its
// persisted resultsKey changes (equivalent to componentDidMount, but resilient
// to async hydration of activeQueryEditor).
useEffect(() => {
if (hasRunInitialEffect.current) {
return;
}
hasRunInitialEffect.current = true;
const latestQuery = queries[activeQueryEditor?.latestQueryId || ''];
const resultsKey = latestQuery?.resultsKey;
if (
isFeatureEnabled(FeatureFlag.SqllabBackendPersistence) &&
latestQuery?.resultsKey
resultsKey &&
fetchedResultsKeyRef.current !== resultsKey
) {
fetchedResultsKeyRef.current = resultsKey;
// when results are not stored in localStorage they need to be
// fetched from the results backend (if configured)
actions.fetchQueryResults(latestQuery, displayLimit);