QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-25 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove fetch results button for async queries (#2084)

Browse Source
This commit is contained in:
vera-liu
2017-01-31 17:25:06 -08:00
committed by GitHub
parent 8da371e324
commit 27aeac6859
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
superset/assets/javascripts/SqlLab/components/ResultSet.jsx
View File

@@ -46,6 +46,10 @@ class ResultSet extends React.PureComponent {
this.clearQueryResults(nextProps.query) this.clearQueryResults(nextProps.query)
); );
} }
if (nextProps.query.resultsKey
&& nextProps.query.resultsKey !== this.props.query.resultsKey) {
this.fetchResults(nextProps.query);
}
} }
getControls() { getControls() {
if (this.props.search || this.props.visualize || this.props.csv) { if (this.props.search || this.props.visualize || this.props.csv) {
@@ -197,20 +201,6 @@ class ResultSet extends React.PureComponent {
</div> </div>
</div> </div>
); );
} else if (query.resultsKey) {
if (results && data && data.length === 0) {
// if fetched result contains zero rows of data
return <Alert bsStyle="warning">The asynchronous query returned no data</Alert>;
}
return (
<div>
<Alert bsStyle="warning">This query was run asynchronously &nbsp;
<Button bsSize="sm" onClick={this.fetchResults.bind(this, query)}>
Fetch results
</Button>
</Alert>
</div>
);
} }
} }
if (query.cached) { if (query.cached) {