QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Convert alert and report cypress tests to component tests (#33696)

Browse Source
This commit is contained in:
Joe Li
2025-06-12 17:04:33 -07:00
committed by GitHub
parent d7d7b7c0e6
commit 2b1d4a02b0
3 changed files with 41 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
superset-frontend/cypress-base/cypress/e2e/alerts_and_reports/alerts.test.ts
View File

@@ -1,38 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { ALERT_LIST } from 'cypress/utils/urls';
describe('Alert list view', () => {
before(() => {
cy.visit(ALERT_LIST);
});
it('should load alert lists', () => {
cy.getBySel('listview-table').should('be.visible');
cy.getBySel('sort-header').eq(1).contains('Last run');
cy.getBySel('sort-header').eq(2).contains('Name');
cy.getBySel('sort-header').eq(3).contains('Schedule');
cy.getBySel('sort-header').eq(4).contains('Notification method');
cy.getBySel('sort-header').eq(5).contains('Owners');
cy.getBySel('sort-header').eq(6).contains('Last modified');
cy.getBySel('sort-header').eq(7).contains('Active');
// TODO Cypress won't recognize the Actions column
// cy.getBySel('sort-header').eq(9).contains('Actions');
});
});

38
superset-frontend/cypress-base/cypress/e2e/alerts_and_reports/reports.test.ts
View File

@@ -1,38 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { REPORT_LIST } from 'cypress/utils/urls';
describe('Report list view', () => {
before(() => {
cy.visit(REPORT_LIST);
});
it('should load report lists', () => {
cy.getBySel('listview-table').should('be.visible');
cy.getBySel('sort-header').eq(1).contains('Last run');
cy.getBySel('sort-header').eq(2).contains('Name');
cy.getBySel('sort-header').eq(3).contains('Schedule');
cy.getBySel('sort-header').eq(4).contains('Notification method');
cy.getBySel('sort-header').eq(5).contains('Owners');
cy.getBySel('sort-header').eq(6).contains('Last modified');
cy.getBySel('sort-header').eq(7).contains('Active');
// TODO Cypress won't recognize the Actions column
// cy.getBySel('sort-header').eq(9).contains('Actions');
});
});

41
superset-frontend/src/pages/AlertReportList/AlertReportList.test.jsx
View File

@@ -232,4 +232,45 @@ describe('AlertList', () => {
'filters:!((col:type,opr:eq,value:Report))',
);
}, 15000);
it('renders listview table correctly', async () => {
renderAlertList();
await screen.findByTestId('alerts-list-view');
const table = await screen.findByTestId('listview-table');
expect(table).toBeInTheDocument();
expect(table).toBeVisible();
}, 15000);
it('renders correct column headers for alerts', async () => {
renderAlertList();
await screen.findByTestId('alerts-list-view');
expect(screen.getByText('Last run')).toBeInTheDocument();
expect(
screen.getByRole('columnheader', { name: /name/i }),
).toBeInTheDocument();
expect(screen.getByText('Schedule')).toBeInTheDocument();
expect(screen.getByText('Notification method')).toBeInTheDocument();
expect(screen.getByText('Owners')).toBeInTheDocument();
expect(screen.getByText('Last modified')).toBeInTheDocument();
expect(screen.getByText('Active')).toBeInTheDocument();
expect(screen.getByText('Actions')).toBeInTheDocument();
}, 15000);
it('renders correct column headers for reports', async () => {
renderAlertList({ isReportEnabled: true });
await screen.findByTestId('alerts-list-view');
expect(screen.getByText('Last run')).toBeInTheDocument();
expect(
screen.getByRole('columnheader', { name: /name/i }),
).toBeInTheDocument();
expect(screen.getByText('Schedule')).toBeInTheDocument();
expect(screen.getByText('Notification method')).toBeInTheDocument();
expect(screen.getByText('Owners')).toBeInTheDocument();
expect(screen.getByText('Last modified')).toBeInTheDocument();
expect(screen.getByText('Active')).toBeInTheDocument();
expect(screen.getByText('Actions')).toBeInTheDocument();
}, 15000);
});