QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(dashboard): strengthen fontWeightStrong assertion for markdown bold (#35872)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Joe Li
2025-10-28 17:23:02 -07:00
committed by GitHub
parent 514d56d1ae
commit 2db19008fb
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/src/dashboard/components/gridComponents/Markdown/Markdown.test.tsx
View File

@@ -426,10 +426,11 @@ test('should have fontWeightStrong in theme for bold markdown rendering', async
},
});
// CRITICAL: Verify fontWeightStrong exists in the theme
// CRITICAL: Verify fontWeightStrong exists in the theme with adequate weight
// If it's missing from allowedAntdTokens, GlobalStyles.tsx:66 will set
// font-weight: undefined on <strong> tags, breaking bold markdown rendering
// Ant Design default is 600, backend config sets 500, either is acceptable
// Must be >= 600 (semibold) to show a true visual difference when bolded
// Values < 600 (like 500/medium) are too subtle and appear similar to normal (400)
expect(supersetTheme.fontWeightStrong).toBeDefined();
expect(supersetTheme.fontWeightStrong).toBeGreaterThan(400);
expect(supersetTheme.fontWeightStrong).toBeGreaterThanOrEqual(600);
});