mirror of
https://github.com/apache/superset.git
synced 2026-04-19 16:14:52 +00:00
fix: error_parsing (#21946)
This commit is contained in:
@@ -322,7 +322,6 @@ class BaseReportState:
|
||||
"chart_id": chart_id,
|
||||
"dashboard_id": dashboard_id,
|
||||
"owners": self._report_schedule.owners,
|
||||
"error_text": None,
|
||||
}
|
||||
return log_data
|
||||
|
||||
@@ -354,7 +353,6 @@ class BaseReportState:
|
||||
if not csv_data:
|
||||
error_text = "Unexpected missing csv file"
|
||||
if error_text:
|
||||
header_data["error_text"] = error_text
|
||||
return NotificationContent(
|
||||
name=self._report_schedule.name,
|
||||
text=error_text,
|
||||
@@ -434,7 +432,6 @@ class BaseReportState:
|
||||
:raises: NotificationError
|
||||
"""
|
||||
header_data = self._get_log_data()
|
||||
header_data["error_text"] = message
|
||||
logger.info(
|
||||
"header_data in notifications for alerts and reports %s, taskid, %s",
|
||||
header_data,
|
||||
|
||||
@@ -197,7 +197,6 @@ class HeaderDataType(TypedDict):
|
||||
notification_source: Optional[str]
|
||||
chart_id: Optional[int]
|
||||
dashboard_id: Optional[int]
|
||||
error_text: Optional[str]
|
||||
|
||||
|
||||
class DatasourceDict(TypedDict):
|
||||
|
||||
@@ -110,4 +110,4 @@ def test_report_with_header_data(
|
||||
assert header_data.get("notification_format") == report_schedule.report_format
|
||||
assert header_data.get("notification_source") == ReportSourceFormat.DASHBOARD
|
||||
assert header_data.get("notification_type") == report_schedule.type
|
||||
assert len(send_email_smtp_mock.call_args.kwargs["header_data"]) == 7
|
||||
assert len(send_email_smtp_mock.call_args.kwargs["header_data"]) == 6
|
||||
|
||||
@@ -41,7 +41,6 @@ def test_render_description_with_html() -> None:
|
||||
"notification_source": None,
|
||||
"chart_id": None,
|
||||
"dashboard_id": None,
|
||||
"error_text": None,
|
||||
},
|
||||
)
|
||||
email_body = (
|
||||
|
||||
Reference in New Issue
Block a user