fix: error_parsing (#21946)

This commit is contained in:
AAfghahi
2022-10-28 19:43:37 -04:00
committed by GitHub
parent d1807db041
commit 33fc57854d
4 changed files with 1 additions and 6 deletions

View File

@@ -322,7 +322,6 @@ class BaseReportState:
"chart_id": chart_id,
"dashboard_id": dashboard_id,
"owners": self._report_schedule.owners,
"error_text": None,
}
return log_data
@@ -354,7 +353,6 @@ class BaseReportState:
if not csv_data:
error_text = "Unexpected missing csv file"
if error_text:
header_data["error_text"] = error_text
return NotificationContent(
name=self._report_schedule.name,
text=error_text,
@@ -434,7 +432,6 @@ class BaseReportState:
:raises: NotificationError
"""
header_data = self._get_log_data()
header_data["error_text"] = message
logger.info(
"header_data in notifications for alerts and reports %s, taskid, %s",
header_data,

View File

@@ -197,7 +197,6 @@ class HeaderDataType(TypedDict):
notification_source: Optional[str]
chart_id: Optional[int]
dashboard_id: Optional[int]
error_text: Optional[str]
class DatasourceDict(TypedDict):

View File

@@ -110,4 +110,4 @@ def test_report_with_header_data(
assert header_data.get("notification_format") == report_schedule.report_format
assert header_data.get("notification_source") == ReportSourceFormat.DASHBOARD
assert header_data.get("notification_type") == report_schedule.type
assert len(send_email_smtp_mock.call_args.kwargs["header_data"]) == 7
assert len(send_email_smtp_mock.call_args.kwargs["header_data"]) == 6

View File

@@ -41,7 +41,6 @@ def test_render_description_with_html() -> None:
"notification_source": None,
"chart_id": None,
"dashboard_id": None,
"error_text": None,
},
)
email_body = (