QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make margin width based on container width instead of slice width (#4487)

Browse Source 
* Make width based on container width instead of slice width

* fix const var name and add comment

* Actually 30 looks good too
This commit is contained in:
Jeffrey Wang
2018-02-28 18:48:15 -05:00
committed by Grace Guo
parent 764a92cd10
commit 3a58dc7ecf
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/assets/visualizations/nvd3_vis.js
View File

@@ -18,6 +18,8 @@ import './nvd3_vis.css';
import { VIZ_TYPES } from './main';
const minBarWidth = 15;
// Limit on how large axes margins can grow as the chart window is resized
const maxMarginPad = 30;
const animationTime = 1000;
const BREAKPOINTS = {
@@ -463,7 +465,9 @@ function nvd3Vis(slice, payload) {
if (chart.yAxis !== undefined || chart.yAxis2 !== undefined) {
// Hack to adjust y axis left margin to accommodate long numbers
const marginPad = isExplore ? width * 0.01 : width * 0.03;
const containerWidth = slice.container.width();
const marginPad = Math.min(isExplore ? containerWidth * 0.01 : containerWidth * 0.03,
maxMarginPad);
const maxYAxisLabelWidth = chart.yAxis2 ? getMaxLabelSize(slice.container, 'nv-y1')
: getMaxLabelSize(slice.container, 'nv-y');
const maxXAxisLabelHeight = getMaxLabelSize(slice.container, 'nv-x');