QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-06 16:34:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: refactor SliceAdder for react 17 and react 18 (#23009)

Browse Source
This commit is contained in:
Lily Kuang
2023-02-07 13:38:32 -08:00
committed by GitHub
parent 183c5f9589
commit 493181c977
3 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
superset-frontend/package-lock.json generated
View File

@@ -127,6 +127,7 @@
"react-transition-group": "^2.5.3",
"react-ultimate-pagination": "^1.3.0",
"react-virtualized": "9.19.1",
"react-virtualized-auto-sizer": "^1.0.7",
"react-window": "^1.8.8",
"redux": "^4.0.5",
"redux-localstorage": "^0.4.1",
@@ -49951,6 +49952,18 @@
"react-dom": "^15.3.0 || ^16.0.0-alpha"
}
},
"node_modules/react-virtualized-auto-sizer": {
"version": "1.0.7",
"resolved": "https://registry.npmjs.org/react-virtualized-auto-sizer/-/react-virtualized-auto-sizer-1.0.7.tgz",
"integrity": "sha512-Mxi6lwOmjwIjC1X4gABXMJcKHsOo0xWl3E3ugOgufB8GJU+MqrtY35aBuvCYv/razQ1Vbp7h1gWJjGjoNN5pmA==",
"engines": {
"node": ">8.0.0"
},
"peerDependencies": {
"react": "^15.3.0 || ^16.0.0-alpha || ^17.0.0 || ^18.0.0-rc",
"react-dom": "^15.3.0 || ^16.0.0-alpha || ^17.0.0 || ^18.0.0-rc"
}
},
"node_modules/react-window": {
"version": "1.8.8",
"resolved": "https://registry.npmjs.org/react-window/-/react-window-1.8.8.tgz",
@@ -100105,6 +100118,12 @@
"react-lifecycles-compat": "^3.0.4"
}
},
"react-virtualized-auto-sizer": {
"version": "1.0.7",
"resolved": "https://registry.npmjs.org/react-virtualized-auto-sizer/-/react-virtualized-auto-sizer-1.0.7.tgz",
"integrity": "sha512-Mxi6lwOmjwIjC1X4gABXMJcKHsOo0xWl3E3ugOgufB8GJU+MqrtY35aBuvCYv/razQ1Vbp7h1gWJjGjoNN5pmA==",
"requires": {}
},
"react-window": {
"version": "1.8.8",
"resolved": "https://registry.npmjs.org/react-window/-/react-window-1.8.8.tgz",

1
superset-frontend/package.json
View File

@@ -191,6 +191,7 @@
"react-transition-group": "^2.5.3",
"react-ultimate-pagination": "^1.3.0",
"react-virtualized": "9.19.1",
"react-virtualized-auto-sizer": "^1.0.7",
"react-window": "^1.8.8",
"redux": "^4.0.5",
"redux-localstorage": "^0.4.1",

12
superset-frontend/src/dashboard/components/SliceAdder.jsx
View File

@@ -19,7 +19,8 @@
/* eslint-env browser */
import React from 'react';
import PropTypes from 'prop-types';
import { List, AutoSizer } from 'react-virtualized';
import AutoSizer from 'react-virtualized-auto-sizer';
import { FixedSizeList as List } from 'react-window';
import { createFilter } from 'react-search-input';
import {
t,
@@ -333,13 +334,14 @@ class SliceAdder extends React.Component {
<List
width={width}
height={height}
rowCount={this.state.filteredSlices.length}
rowHeight={DEFAULT_CELL_HEIGHT}
rowRenderer={this.rowRenderer}
itemCount={this.state.filteredSlices.length}
itemSize={DEFAULT_CELL_HEIGHT}
searchTerm={this.state.searchTerm}
sortBy={this.state.sortBy}
selectedSliceIds={this.props.selectedSliceIds}
/>
>
{this.rowRenderer}
</List>
)}
</AutoSizer>
</ChartList>