QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[filter_box] Fix ; separated filter_box default values (#8949)

Browse Source
This commit is contained in:
Grace Guo
2020-01-13 20:35:33 -08:00
committed by GitHub
parent b5e51ead29
commit 50f21cb7db
2 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
superset/assets/spec/javascripts/dashboard/util/getFilterConfigsFromFormdata_spec.js
View File

@@ -62,7 +62,26 @@ describe('getFilterConfigsFromFormdata', () => {
show_sqla_time_column: true,
});
expect(result.columns).toMatchObject({
state: 'CA',
state: ['CA'],
});
});
it('should read multi values from form_data', () => {
const result = getFilterConfigsFromFormdata({
...testFormdata,
filter_configs: [
{
asc: true,
clearable: true,
column: 'state',
defaultValue: 'CA;NY',
key: 'fvwncPjUf',
multiple: true,
},
],
});
expect(result.columns).toMatchObject({
state: ['CA', 'NY'],
});
});
});

8
superset/assets/src/dashboard/util/getFilterConfigsFromFormdata.js
View File

@@ -31,9 +31,15 @@ export default function getFilterConfigsFromFormdata(form_data = {}) {
} = form_data;
let configs = filter_configs.reduce(
({ columns, labels }, config) => {
let defaultValues = config.defaultValue;
// defaultValue could be ; separated values,
// could be null or ''
if (config.defaultValue) {
defaultValues = config.defaultValue.split(';');
}
const updatedColumns = {
...columns,
[config.column]: config.vals || config.defaultValue,
[config.column]: config.vals || defaultValues,
};
const updatedLabels = {
...labels,