fix: CommandInvalidError had invalid init (#11635)

This commit is contained in:
Beto Dealmeida
2020-11-10 07:41:03 -08:00
committed by GitHub
parent 4d41cf900d
commit 51712bf7ce
2 changed files with 27 additions and 1 deletions

View File

@@ -38,7 +38,7 @@ class CommandInvalidError(CommandException):
def __init__(self, message: str = "") -> None:
self._invalid_exceptions: List[ValidationError] = []
super().__init__(self.message)
super().__init__(message)
def add(self, exception: ValidationError) -> None:
self._invalid_exceptions.append(exception)

26
tests/commands_test.py Normal file
View File

@@ -0,0 +1,26 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# pylint: disable=no-self-use
from superset.commands.exceptions import CommandInvalidError
from tests.base_tests import SupersetTestCase
class TestCommandsExceptions(SupersetTestCase):
def test_command_invalid_error(self):
exception = CommandInvalidError("A test")
assert str(exception) == "A test"