QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-01 05:39:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: navigate to SQL Lab due to router api updates (#34569)

Browse Source
This commit is contained in:
JUST.in DO IT
2025-08-06 07:54:10 -07:00
committed by GitHub
parent 5a004590e0
commit 53e9cf6d17
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/src/explore/components/controls/ViewQuery.test.tsx
View File

@@ -154,7 +154,8 @@ test('navigates to SQL Lab when View in SQL Lab button is clicked', () => {
const viewInSQLLabButton = screen.getByText('View in SQL Lab');
fireEvent.click(viewInSQLLabButton);
expect(mockHistoryPush).toHaveBeenCalledWith('/sqllab', {
expect(mockHistoryPush).toHaveBeenCalledWith({
pathname: '/sqllab',
state: {
requestedQuery: {
datasourceKey: mockProps.datasource,
@@ -174,7 +175,7 @@ test('opens SQL Lab in a new tab when View in SQL Lab button is clicked with met
const { datasource, sql } = mockProps;
expect(window.open).toHaveBeenCalledWith(
`/sqllab?datasourceKey=${datasource}&sql=${sql}`,
`/sqllab?datasourceKey=${datasource}&sql=${encodeURIComponent(sql)}`,
'_blank',
);
});

4
superset-frontend/src/explore/components/controls/ViewQuery.tsx
View File

@@ -125,11 +125,11 @@ const ViewQuery: FC<ViewQueryProps> = props => {
if (domEvent.metaKey || domEvent.ctrlKey) {
domEvent.preventDefault();
window.open(
`/sqllab?datasourceKey=${datasource}&sql=${currentSQL}`,
`/sqllab?datasourceKey=${datasource}&sql=${encodeURIComponent(currentSQL)}`,
'_blank',
);
} else {
history.push('/sqllab', { state: { requestedQuery } });
history.push({ pathname: '/sqllab', state: { requestedQuery } });
}
},
[history, datasource, currentSQL],