chore(node): bumping Superset to Node 18 (#27198)

.github/workflows/embedded-sdk-release.yml

@@ -31,8 +31,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: "16"
-          registry-url: "https://registry.npmjs.org"
+          node-version: "18"
+          registry-url: 'https://registry.npmjs.org'
       - run: npm ci
       - run: npm run ci:release
         env:

.github/workflows/embedded-sdk-test.yml

@@ -21,7 +21,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: "16"
+          node-version: "18"
           registry-url: 'https://registry.npmjs.org'
       - run: npm ci
       - run: npm test

.github/workflows/release.yml

@@ -29,7 +29,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16]
+        node-version: [18]
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/superset-applitool-cypress.yml

@@ -26,7 +26,7 @@ jobs:
       fail-fast: false
       matrix:
         browser: ["chrome"]
-        node: [16]
+        node: [18]
     env:
       SUPERSET_ENV: development
       SUPERSET_CONFIG: tests.integration_tests.superset_test_config

.github/workflows/superset-applitools-storybook.yml

@@ -30,7 +30,7 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        node: [16]
+        node: [18]
     steps:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@v4

.github/workflows/superset-docs-deploy.yml

@@ -36,10 +36,10 @@ jobs:
         with:
           persist-credentials: false
           submodules: recursive
-      - name: Set up Node.js 16
+      - name: Set up Node.js 18
         uses: actions/setup-node@v4
         with:
-          node-version: "16"
+          node-version: '18'
       - name: yarn install
         run: |
           yarn install --check-cache

.github/workflows/superset-docs-verify.yml

@@ -24,10 +24,10 @@ jobs:
         with:
           persist-credentials: false
           submodules: recursive
-      - name: Set up Node.js 16
+      - name: Set up Node.js 18
         uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '18'
       - name: yarn install
         run: |
           yarn install --check-cache

.github/workflows/superset-frontend.yml

@@ -39,7 +39,7 @@ jobs:
         if: steps.check.outcome == 'failure'
         uses: actions/setup-node@v4
         with:
-          node-version: "16"
+          node-version: "18"
       - name: Install dependencies
         if: steps.check.outcome == 'failure'
         uses: ./.github/actions/cached-dependencies

.github/workflows/superset-translations.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "16"
+          node-version:  '18'
       - name: Install dependencies
         uses: ./.github/actions/cached-dependencies
         with:

.github/workflows/tech-debt.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "16"
+          node-version: '18'
 
       - name: Install Dependencies
         run: npm install

.github/workflows/update-monorepo-lockfiles.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '18'
 
       - name: Install Dependencies and Update Lock File
         run: |

CONTRIBUTING.md

@@ -584,8 +584,8 @@ Frontend assets (TypeScript, JavaScript, CSS, and images) must be compiled in or
 
 First, be sure you are using the following versions of Node.js and npm:
 
-- `Node.js`: Version 16
-- `npm`: Version 7
+- `Node.js`: Version 18
+- `npm`: Version 10
 
 We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment:
 

Dockerfile

@@ -22,7 +22,7 @@ ARG PY_VER=3.10-slim-bookworm
 
 # if BUILDPLATFORM is null, set it to 'amd64' (or leave as is otherwise).
 ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64}
-FROM --platform=${BUILDPLATFORM} node:16-bookworm-slim AS superset-node
+FROM --platform=${BUILDPLATFORM} node:18-bullseye-slim AS superset-node
 
 ARG NPM_BUILD_CMD="build"
 

docker-compose.yml

@@ -126,7 +126,7 @@ services:
       disable: true
 
   superset-node:
-    image: node:16
+    image: node:18
     environment:
       # set this to false if you have perf issues running the npm i; npm run dev in-docker
       # if you do so, you have to run this manually on the host, which should perform better!

superset-frontend/package-lock.json

@@ -288,8 +288,8 @@
         "xdm": "^3.4.0"
       },
       "engines": {
-        "node": "^16.20.2",
-        "npm": "^8.19.4"
+        "node": "^18.19.1",
+        "npm": "^10.2.4"
       }
     },
     "buildtools/eslint-plugin-theme-colors": {

superset-frontend/package.json

@@ -354,8 +354,8 @@
     "xdm": "^3.4.0"
   },
   "engines": {
-    "node": "^16.20.2",
-    "npm": "^8.19.4"
+    "node": "^18.19.1",
+    "npm": "^10.2.4"
   },
   "overrides": {
     "d3-color": "^3.1.0",