QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 15:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor sql_json view endpoint: separate validate the query concern into ad hod method (#16647)

Browse Source
This commit is contained in:
ofekisr
2021-09-09 17:11:17 +03:00
committed by GitHub
parent 3d0ebd5abc
commit 62637f275f
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
superset/views/core.py
View File

@@ -2596,17 +2596,8 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
)
query = execution_context.create_query()
self._save_new_query(query, session)
logger.info("Triggering query_id: %i", query.id)
try:
query.raise_for_access()
except SupersetSecurityException as ex:
query.set_extra_json_key("errors", [dataclasses.asdict(ex.error)])
query.status = QueryStatus.FAILED
query.error_message = ex.error.message
session.commit()
raise SupersetErrorException(ex.error, status=403) from ex
self._validate_access(query, session)
try:
template_processor = get_template_processor(
@@ -2677,6 +2668,18 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
session, rendered_query, query, expand_data, log_params
)
def _validate_access( # pylint: disable=no-self-use
self, query: Query, session: Session
) -> None:
try:
query.raise_for_access()
except SupersetSecurityException as ex:
query.set_extra_json_key("errors", [dataclasses.asdict(ex.error)])
query.status = QueryStatus.FAILED
query.error_message = ex.error.message
session.commit()
raise SupersetErrorException(ex.error, status=403) from ex
def _save_new_query( # pylint: disable=no-self-use
self, query: Query, session: Session
) -> None: