QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): column data type tooltip format (#30588)

Browse Source
This commit is contained in:
Maxime Beauchemin
2024-10-29 18:47:20 -07:00
committed by GitHub
parent eb14c762af
commit 73768f6313
2 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx
View File

@@ -55,8 +55,7 @@ const TooltipSection = ({
text: ReactNode;
}) => (
<TooltipSectionWrapper>
<TooltipSectionLabel>{label}</TooltipSectionLabel>
<span>{text}</span>
<TooltipSectionLabel>{label}</TooltipSectionLabel>: <span>{text}</span>
</TooltipSectionWrapper>
);
@@ -71,12 +70,7 @@ export const getColumnTypeTooltipNode = (column: ColumnMeta): ReactNode => {
return null;
}
return (
<TooltipSection
label={t('Column datatype')}
text={column.type.toLowerCase()}
/>
);
return <TooltipSection label={t('Column type')} text={column.type} />;
};
export const getColumnTooltipNode = (

2
superset-frontend/packages/superset-ui-chart-controls/test/components/labelUtils.test.tsx
View File

@@ -90,7 +90,7 @@ test('should get column datatype rendered as tooltip when column has a type', ()
</>,
);
expect(screen.getByText('Column datatype')).toBeVisible();
expect(screen.getByText('Column type')).toBeVisible();
expect(screen.getByText('text')).toBeVisible();
});