QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115)

Browse Source 
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
This commit is contained in:
Kamil Gabryjelski
2021-08-06 17:59:22 +02:00
committed by GitHub
parent b80f018691
commit 772da8de63
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
View File

@@ -66,9 +66,7 @@ export const DndColumnSelect = (props: LabelProps) => {
) {
onChange(optionSelectorValues);
}
// when options change, that means that the dataset has changed
// so we have to check if values are still applicable.
}, [options, value, optionSelector]);
}, [JSON.stringify(value), JSON.stringify(optionSelector.getValues())]);
// useComponentDidUpdate to avoid running this for the first render, to avoid
// calling onChange when the initial value is not valid for the dataset