QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-21 15:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(playwright): standardize delete-modal wait and clarify count-vs-visibility comments

Browse Source 
Use waitForVisible() on the dashboard single-delete site to match the other four
delete flows; fillConfirmationInput already auto-waits for the input, so the
lone waitForReady() added no extra signal.

Rewrite "(deleted rows leave the DOM)" — "leave" is ambiguous in English (depart
vs remain) — to spell out that the row is removed and that's why these
assertions use toHaveCount(0) instead of not.toBeVisible().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Joe Li
2026-05-14 10:28:09 -07:00
parent 57b3ec368b
commit 77fead8f4c
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/playwright/tests/chart/chart-list.spec.ts
View File

@@ -89,7 +89,7 @@ test('should delete a chart with confirmation', async ({
const toast = new Toast(page);
await expect(toast.getSuccess()).toBeVisible();
// Verify chart is removed from list (deleted rows leave the DOM)
// Verify chart is removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
await expect(chartListPage.getChartRow(chartName)).toHaveCount(0);
// Backend verification: API returns 404
@@ -248,7 +248,7 @@ test('should bulk delete multiple charts', async ({
const toast = new Toast(page);
await expect(toast.getSuccess()).toBeVisible();
// Verify both charts are removed from list (deleted rows leave the DOM)
// Verify both charts are removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
await expect(chartListPage.getChartRow(chart1.name)).toHaveCount(0);
await expect(chartListPage.getChartRow(chart2.name)).toHaveCount(0);

6
superset-frontend/playwright/tests/dashboard/dashboard-list.spec.ts
View File

@@ -79,7 +79,7 @@ test('should delete a dashboard with confirmation', async ({
// Delete confirmation modal should appear
const deleteModal = new DeleteConfirmationModal(page);
await deleteModal.waitForReady();
await deleteModal.waitForVisible();
// Type "DELETE" to confirm
await deleteModal.fillConfirmationInput('DELETE');
@@ -197,7 +197,7 @@ test('should bulk delete multiple dashboards', async ({
const toast = new Toast(page);
await expect(toast.getSuccess()).toBeVisible();
// Verify both dashboards are removed from list (deleted rows leave the DOM)
// Verify both dashboards are removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
await expect(dashboardListPage.getDashboardRow(dashboard1.name)).toHaveCount(
0,
);
@@ -308,7 +308,7 @@ test.describe('import dashboard', () => {
label: `Dashboard ${dashboardId}`,
});
// Refresh to confirm dashboard is no longer in the list (deleted rows leave the DOM)
// Refresh to confirm dashboard is no longer in the list (deleted rows are removed from the DOM, so assert count rather than visibility)
await dashboardListPage.goto();
await dashboardListPage.waitForTableLoad();
await expect(dashboardListPage.getDashboardRow(dashboardName)).toHaveCount(

6
superset-frontend/playwright/tests/dataset/dataset-list.spec.ts
View File

@@ -134,7 +134,7 @@ test('should delete a dataset with confirmation', async ({
await expect(toast.getSuccess()).toBeVisible();
await expect(toast.getMessage()).toContainText('Deleted');
// Verify dataset is removed from list (deleted rows leave the DOM)
// Verify dataset is removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
await expect(datasetListPage.getDatasetRow(datasetName)).toHaveCount(0);
// Verify via API that dataset no longer exists (404)
@@ -440,7 +440,7 @@ test('should bulk delete multiple datasets', async ({
const toast = new Toast(page);
await expect(toast.getSuccess()).toBeVisible();
// Verify both datasets are removed from list (deleted rows leave the DOM)
// Verify both datasets are removed from list (deleted rows are removed from the DOM, so assert count rather than visibility)
await expect(datasetListPage.getDatasetRow(dataset1.name)).toHaveCount(0);
await expect(datasetListPage.getDatasetRow(dataset2.name)).toHaveCount(0);
@@ -487,7 +487,7 @@ test.describe('import dataset', () => {
label: `Dataset ${datasetId}`,
});
// Refresh to confirm dataset is no longer in the list (deleted rows leave the DOM)
// Refresh to confirm dataset is no longer in the list (deleted rows are removed from the DOM, so assert count rather than visibility)
await datasetListPage.goto();
await datasetListPage.waitForTableLoad();
await expect(datasetListPage.getDatasetRow(datasetName)).toHaveCount(0);