QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ThemeController): replace fetch with SupersetClient for proper auth (#35794)

Browse Source
This commit is contained in:
Mehmet Salih Yavuz
2025-10-22 19:54:28 +03:00
committed by GitHub
parent d9dcbb68b7
commit 7f0c0aea94
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
superset-frontend/src/theme/ThemeController.ts
View File

@@ -22,6 +22,7 @@ import {
type ThemeControllerOptions,
type ThemeStorage,
isThemeConfigDark,
makeApi,
Theme,
ThemeMode,
themeObject as supersetThemeObject,
@@ -225,14 +226,14 @@ export class ThemeController {
return this.dashboardThemes.get(themeId)!;
}
// Fetch theme config from API
const response = await fetch(`/api/v1/theme/${themeId}`);
if (!response.ok) {
throw new Error(`HTTP ${response.status}: ${response.statusText}`);
}
// Fetch theme config from API using SupersetClient for proper auth
const getTheme = makeApi<void, { result: { json_data: string } }>({
method: 'GET',
endpoint: `/api/v1/theme/${themeId}`,
});
const data = await response.json();
const themeConfig = JSON.parse(data.result.json_data);
const { result } = await getTheme();
const themeConfig = JSON.parse(result.json_data);
if (themeConfig) {
// Controller creates and owns the dashboard theme
@@ -861,13 +862,14 @@ export class ThemeController {
themeId: string,
): Promise<AnyThemeConfig | null> {
try {
const response = await fetch(`/api/v1/theme/${themeId}`);
if (!response.ok) {
throw new Error(`HTTP ${response.status}: ${response.statusText}`);
}
// Use SupersetClient for proper authentication handling
const getTheme = makeApi<void, { result: { json_data: string } }>({
method: 'GET',
endpoint: `/api/v1/theme/${themeId}`,
});
const data = await response.json();
const themeConfig = JSON.parse(data.result.json_data);
const { result } = await getTheme();
const themeConfig = JSON.parse(result.json_data);
return themeConfig;
} catch (error) {