QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: show nice error page in prod (#16695)

Browse Source
This commit is contained in:
Beto Dealmeida
2021-09-14 16:56:25 -07:00
committed by GitHub
parent 540277ebb1
commit 7f804d62d1
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset/views/base.py
View File

@@ -439,6 +439,10 @@ def show_http_exception(ex: HTTPException) -> FlaskResponse:
@superset_app.errorhandler(CommandException)
def show_command_errors(ex: CommandException) -> FlaskResponse:
logger.warning(ex)
if "text/html" in request.accept_mimetypes and not config["DEBUG"]:
path = resource_filename("superset", "static/assets/500.html")
return send_file(path), 500
extra = ex.normalized_messages() if isinstance(ex, CommandInvalidError) else {}
return json_errors_response(
errors=[
@@ -457,6 +461,10 @@ def show_command_errors(ex: CommandException) -> FlaskResponse:
@superset_app.errorhandler(Exception)
def show_unexpected_exception(ex: Exception) -> FlaskResponse:
logger.exception(ex)
if "text/html" in request.accept_mimetypes and not config["DEBUG"]:
path = resource_filename("superset", "static/assets/500.html")
return send_file(path), 500
return json_errors_response(
errors=[
SupersetError(