QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-13 18:25:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(dashboard): cover combined edit+standalone URL params

Browse Source 
Adds the React-side analogue of the legacy `?edit=true&standalone=true`
Cypress mount, asserting the two URL params remain orthogonal:
standalone=2 hides DashboardHeader while editMode still drives the
`dashboard--editing` wrapper class. Satisfies sc-107447 task 3.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joe Li
2026-06-09 16:42:28 -07:00
parent 63e60bc331
commit 8230b7efa5
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx
View File

@@ -181,6 +181,26 @@ describe('DashboardBuilder', () => {
}
});
test('should apply editing class and hide header when both edit and standalone params are set', () => {
// Combined-params analogue of the legacy `?edit=true&standalone=true` Cypress
// mount. The two URL params are orthogonal on the React side: standalone=2
// suppresses DashboardHeader regardless of editMode, while editMode still
// drives the `dashboard--editing` class on the wrapper.
const originalHref = window.location.href;
window.history.replaceState({}, '', '/?edit=true&standalone=2');
try {
const { getByTestId, queryByTestId } = setup({
dashboardState: { ...mockState.dashboardState, editMode: true },
});
expect(getByTestId('dashboard-content-wrapper')).toHaveClass(
'dashboard dashboard--editing',
);
expect(queryByTestId('dashboard-header-container')).not.toBeInTheDocument();
} finally {
window.history.replaceState({}, '', originalHref);
}
});
test('should render a Sticky top-level Tabs if the dashboard has tabs', async () => {
const { findAllByTestId } = setup({
dashboardLayout: undoableDashboardLayoutWithTabs,