QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: do_ping takes a connection, not engine (#39013)

Browse Source
This commit is contained in:
Beto Dealmeida
2026-04-15 11:10:24 -04:00
committed by GitHub
parent ddcb9be9a7
commit 84f7b4a973
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset/commands/database/utils.py
View File

@@ -47,7 +47,8 @@ def ping(engine: Engine) -> bool:
except (sqlite3.ProgrammingError, RuntimeError):
# SQLite can't run on a separate thread, so ``utils.timeout`` fails
# RuntimeError catches the equivalent error from duckdb.
return engine.dialect.do_ping(engine)
with closing(engine.raw_connection()) as conn:
return engine.dialect.do_ping(conn)
def add_permissions(database: Database) -> None:

6
tests/unit_tests/commands/databases/utils_test.py
View File

@@ -77,7 +77,7 @@ def test_ping_sqlite_exception(mocker: MockerFixture, mock_engine: MockerFixture
assert result is True
mock_dialect.do_ping.assert_has_calls(
[mocker.call(mock_connection), mocker.call(mock_engine)]
[mocker.call(mock_connection), mocker.call(mock_connection)]
)
@@ -85,7 +85,7 @@ def test_ping_runtime_exception(mocker: MockerFixture, mock_engine: MockerFixtur
"""
Test the ``ping`` method when a RuntimeError is raised.
"""
mock_engine, _, mock_dialect = mock_engine
mock_engine, mock_connection, mock_dialect = mock_engine
mock_timeout = mocker.patch("superset.commands.database.utils.timeout")
mock_timeout.side_effect = RuntimeError("timeout")
mock_dialect.do_ping.return_value = True
@@ -93,7 +93,7 @@ def test_ping_runtime_exception(mocker: MockerFixture, mock_engine: MockerFixtur
result = ping(mock_engine)
assert result is True
mock_dialect.do_ping.assert_called_once_with(mock_engine)
mock_dialect.do_ping.assert_called_once_with(mock_connection)
@pytest.fixture