QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-07 08:54:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

taking care of PR comments

Browse Source
This commit is contained in:
alexandrusoare
2026-05-06 11:28:03 +03:00
parent 81d6fc26e2
commit 879b1c2255
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/mcp_service/chart/tool/get_chart_data.py
View File

@@ -800,7 +800,7 @@ async def get_chart_data( # noqa: C901
# Use SQL-derived GenericDataType when available,
# fall back to Python isinstance heuristic
data_type = "string"
if idx < len(coltypes):
if coltypes:
data_type = _GENERIC_TYPE_MAP.get(coltypes[idx], "string")
elif sample_values:
if all(isinstance(v, bool) for v in sample_values):

5
tests/unit_tests/mcp_service/chart/tool/test_get_chart_data.py
View File

@@ -30,12 +30,14 @@ from superset.mcp_service.chart.schemas import (
PerformanceMetadata,
)
from superset.mcp_service.chart.tool.get_chart_data import (
_GENERIC_TYPE_MAP,
_MAX_RECOMMENDATIONS,
_recommend_visualizations,
_sanitize_chart_data_for_llm_context,
)
from superset.mcp_service.utils import sanitize_for_llm_context
from superset.mcp_service.utils.sanitization import LLM_CONTEXT_ESCAPED_CLOSE_DELIMITER
from superset.utils.core import GenericDataType
def _collect_groupby_extras(
@@ -1099,9 +1101,6 @@ def test_recommend_single_numeric_high_cardinality_suggests_histogram():
def test_coltypes_populates_data_type():
"""Verify that GenericDataType values from coltypes are mapped correctly."""
from superset.mcp_service.chart.tool.get_chart_data import _GENERIC_TYPE_MAP
from superset.utils.core import GenericDataType
assert _GENERIC_TYPE_MAP[GenericDataType.NUMERIC] == "numeric"
assert _GENERIC_TYPE_MAP[GenericDataType.STRING] == "string"
assert _GENERIC_TYPE_MAP[GenericDataType.TEMPORAL] == "temporal"