QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-27 17:12:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(chart-echarts): drop white textBorder from Funnel segment labels (#40468)

Browse Source 
(cherry picked from commit c73106b7a2)
This commit is contained in:
jesperct
2026-05-28 03:59:51 -03:00
committed by Joe Li
parent c53e38e566
commit 8caa35c2cf
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
View File

@@ -238,8 +238,6 @@ export default function transformProps(
formatter,
show: showLabels,
color: theme.colorText,
textBorderColor: theme.colorBgBase,
textBorderWidth: 1,
};
const series: FunnelSeriesOption[] = [

9
superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts
View File

@@ -75,6 +75,15 @@ describe('Funnel transformProps', () => {
}),
);
});
test('does not apply a text border to segment labels', () => {
// A white textBorder washes out the dark text on light-colored segments.
const result = transformProps(chartProps as EchartsFunnelChartProps);
const { label } = (result.echartOptions.series as any)[0];
expect(label.color).toBe(supersetTheme.colorText);
expect(label.textBorderColor).toBeUndefined();
expect(label.textBorderWidth).toBeUndefined();
});
});
describe('formatFunnelLabel', () => {