QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-07 08:54:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address comments

Browse Source
This commit is contained in:
Beto Dealmeida
2026-03-18 12:39:03 -04:00
parent d6d8e09445
commit 9fb29accc7
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset/daos/semantic_layer.py
View File

@@ -21,6 +21,8 @@ from __future__ import annotations
from typing import Any
from sqlalchemy.exc import StatementError
from superset_core.semantic_layers.daos import (
AbstractSemanticLayerDAO,
AbstractSemanticViewDAO,
@@ -46,12 +48,14 @@ class SemanticLayerDAO(AbstractSemanticLayerDAO):
.filter(SemanticLayer.uuid == uuid_str)
.one_or_none()
)
except ValueError:
except (ValueError, StatementError):
return None
@classmethod
def find_all(cls, skip_base_filter: bool = False) -> list[SemanticLayer]:
return db.session.query(SemanticLayer).all()
query = db.session.query(SemanticLayer)
query = cls._apply_base_filter(query, skip_base_filter)
return query.all()
@classmethod
def validate_uniqueness(cls, name: str) -> bool:

6
superset/semantic_layers/api.py
View File

@@ -163,6 +163,8 @@ class SemanticLayerRestApi(BaseSupersetApi):
class_permission_name = "SemanticLayer"
method_permission_name = MODEL_API_RW_METHOD_PERMISSION_MAP
openapi_spec_tag = "Semantic Layers"
add_model_schema = SemanticLayerPostSchema()
edit_model_schema = SemanticLayerPutSchema()
@expose("/types", methods=("GET",))
@protect()
@@ -320,7 +322,7 @@ class SemanticLayerRestApi(BaseSupersetApi):
$ref: '#/components/responses/422'
"""
try:
item = SemanticLayerPostSchema().load(request.json)
item = self.add_model_schema.load(request.json)
except ValidationError as error:
return self.response_400(message=error.messages)
@@ -380,7 +382,7 @@ class SemanticLayerRestApi(BaseSupersetApi):
$ref: '#/components/responses/422'
"""
try:
item = SemanticLayerPutSchema().load(request.json)
item = self.edit_model_schema.load(request.json)
except ValidationError as error:
return self.response_400(message=error.messages)