QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): support input undo when editing chart title (#18137)

Browse Source
This commit is contained in:
Stephen Liu
2022-01-27 14:53:46 +08:00
committed by GitHub
parent e6bb0fc7ad
commit a2bad7551e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/dashboard/components/UndoRedoKeyListeners/index.jsx
View File

@@ -45,8 +45,10 @@ class UndoRedoKeyListeners extends React.PureComponent {
const isYChar = event.key === 'y' || event.keyCode === 89;
const isEditingMarkdown =
document && document.querySelector('.dashboard-markdown--editing');
const isEditingTitle =
document && document.querySelector('.editable-title--editing');
if (!isEditingMarkdown && (isZChar || isYChar)) {
if (!isEditingMarkdown && !isEditingTitle && (isZChar || isYChar)) {
event.preventDefault();
const func = isZChar ? this.props.onUndo : this.props.onRedo;
func();