QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-26 18:25:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: update comment since it's not really verbatim

Browse Source
This commit is contained in:
Joe Li
2026-05-19 15:09:41 -07:00
committed by GitHub
parent 9f65966193
commit b4c7459890
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/unit_tests/sql/parse_tests.py
View File

@@ -1195,12 +1195,13 @@ def test_with_clause_containing_union_is_not_mutating(engine: str) -> None:
def test_with_clause_containing_union_all_is_not_mutating_oracle() -> None:
"""
Companion to test_with_clause_containing_union_is_not_mutating: the
original bug report (#25659) used the exact Oracle-flavored shape below
(``SYSDATE FROM DUAL`` is the Oracle no-op for "now"). Pinning the
verbatim repro guards against a future dialect-specific regression that
a generic ``SELECT 1`` test might miss.
"""
Companion to test_with_clause_containing_union_is_not_mutating: exercises
UNION ALL (a sibling of UNION whose per-dialect sqlglot AST shape can
diverge) on the Oracle-flavored ``SYSDATE FROM DUAL`` form from #25659.
UNION is covered by the parametrized test above; this guards against a
UNION-ALL-specific or Oracle-shape-specific regression that a generic
``SELECT 1 UNION SELECT 2`` test might miss.
"""
sql = """
WITH SET1 AS (SELECT SYSDATE FROM DUAL UNION ALL SELECT SYSDATE FROM DUAL),
SET2 AS (SELECT * FROM SET1)