QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a safety check before getting clientHeight (#6923)

Browse Source 
Seeing an intermittent repro of the `current` nodes of the sql editor and south pane refs returning null. Adding a safety check for both nodes.
This commit is contained in:
Christine Chambers
2019-02-20 14:31:28 -08:00
committed by GitHub
parent 25ec00b3c6
commit c04c0cd8f0
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/src/SqlLab/components/SouthPane.jsx
View File

@@ -64,7 +64,7 @@ export class SouthPane extends React.PureComponent {
}
// One layer of abstraction for easy spying in unit tests
getSouthPaneHeight() {
return this.southPaneRef.current.clientHeight;
return this.southPaneRef.current ? this.southPaneRef.current.clientHeight : 0;
}
switchTab(id) {
this.props.actions.setActiveSouthPaneTab(id);

2
superset/assets/src/SqlLab/components/SqlEditor.jsx
View File

@@ -122,7 +122,7 @@ class SqlEditor extends React.PureComponent {
}
// One layer of abstraction for easy spying in unit tests
getSqlEditorHeight() {
return this.sqlEditorRef.current.clientHeight;
return this.sqlEditorRef.current ? this.sqlEditorRef.current.clientHeight : 0;
}
// Return the heights for the ace editor and the south pane as an object
// given the height of the sql editor, north pane percent and south pane percent.