mirror of
https://github.com/apache/superset.git
synced 2026-04-19 16:14:52 +00:00
Revert "[sqllab] fix, strip comments before parsing statements" (#9862)
This reverts commit 949c4eae28.
Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
@@ -82,10 +82,7 @@ class ParsedQuery:
|
||||
self._limit: Optional[int] = None
|
||||
|
||||
logger.debug("Parsing with sqlparse statement: %s", self.sql)
|
||||
self._parsed = sqlparse.parse(
|
||||
sqlparse.format(self.stripped(), strip_comments=True)
|
||||
)
|
||||
|
||||
self._parsed = sqlparse.parse(self.stripped())
|
||||
for statement in self._parsed:
|
||||
self._limit = _extract_limit_from_query(statement)
|
||||
|
||||
|
||||
@@ -534,17 +534,6 @@ class SupersetTestCase(unittest.TestCase):
|
||||
expected = ["SELECT * FROM birth_names", "SELECT * FROM birth_names LIMIT 1"]
|
||||
self.assertEqual(statements, expected)
|
||||
|
||||
def test_comment_breakdown_statements(self):
|
||||
multi_sql = """
|
||||
SELECT * FROM birth_names;
|
||||
-- some comment
|
||||
"""
|
||||
parsed = ParsedQuery(multi_sql)
|
||||
statements = parsed.get_statements()
|
||||
self.assertEqual(len(statements), 1)
|
||||
expected = ["SELECT * FROM birth_names"]
|
||||
self.assertEqual(statements, expected)
|
||||
|
||||
def test_messy_breakdown_statements(self):
|
||||
multi_sql = """
|
||||
SELECT 1;\t\n\n\n \t
|
||||
|
||||
Reference in New Issue
Block a user