QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-02 14:19:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[sqllab] fix, strip comments before parsing statements" (#9862)

Browse Source 
This reverts commit 949c4eae28.

Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley
2020-05-20 09:54:17 -07:00
committed by GitHub
parent 5aad12d783
commit c691a07948
2 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/sql_parse_tests.py
View File

@@ -534,17 +534,6 @@ class SupersetTestCase(unittest.TestCase):
expected = ["SELECT * FROM birth_names", "SELECT * FROM birth_names LIMIT 1"]
self.assertEqual(statements, expected)
def test_comment_breakdown_statements(self):
multi_sql = """
SELECT * FROM birth_names;
-- some comment
"""
parsed = ParsedQuery(multi_sql)
statements = parsed.get_statements()
self.assertEqual(len(statements), 1)
expected = ["SELECT * FROM birth_names"]
self.assertEqual(statements, expected)
def test_messy_breakdown_statements(self):
multi_sql = """
SELECT 1;\t\n\n\n \t