QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-02 22:29:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: rename variable for clarity (#12159)

Browse Source
This commit is contained in:
Beto Dealmeida
2020-12-21 13:39:13 -08:00
committed by GitHub
parent 2f0add3aec
commit ce1abc98df
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx
View File

@@ -79,14 +79,14 @@ function ParameterErrorMessage({
([undefinedParameter, templateKeys]) => (
<li>
{tn(
'%(suggestion)s instead of "%(undefined)s?"',
'%(first_suggestions)s or %(last_suggestion)s instead of "%(undefined)s"?',
'%(suggestion)s instead of "%(undefinedParameter)s?"',
'%(firstSuggestions)s or %(lastSuggestion)s instead of "%(undefinedParameter)s"?',
templateKeys.length,
{
suggestion: templateKeys.join(', '),
first_suggestions: templateKeys.slice(0, -1).join(', '),
last_suggestion: templateKeys[templateKeys.length - 1],
undefined: undefinedParameter,
firstSuggestions: templateKeys.slice(0, -1).join(', '),
lastSuggestion: templateKeys[templateKeys.length - 1],
undefinedParameter,
},
)}
</li>

10
superset/views/core.py
View File

@@ -2521,21 +2521,21 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
# pylint: disable=protected-access
ast = template_processor._env.parse(rendered_query)
undefined = find_undeclared_variables(ast) # type: ignore
if undefined:
undefined_parameters = find_undeclared_variables(ast) # type: ignore
if undefined_parameters:
query.status = QueryStatus.FAILED
session.commit()
raise SupersetTemplateParamsErrorException(
message=ngettext(
"The parameter %(parameters)s in your query is undefined.",
"The following parameters in your query are undefined: %(parameters)s.",
len(undefined),
parameters=utils.format_list(undefined),
len(undefined_parameters),
parameters=utils.format_list(undefined_parameters),
)
+ " "
+ PARAMETER_MISSING_ERR,
extra={
"undefined_parameters": list(undefined),
"undefined_parameters": list(undefined_parameters),
"template_parameters": template_params,
},
)