QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-21 15:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(charts): use discriminating timestamp pair for #27500 regression

Browse Source 
Per @codeant-ai's review: the original now/2-days pair would let a string-
based sort pass the assertion, since 'n' > '2' lexically. Switched to
"3 hours ago" vs "5 hours ago" — lexical desc puts "5..." first while
timestamp desc must put "3..." first, so the two orderings actually
disagree and a regression to string-based sorting would fail the test.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Claude Code
2026-05-18 17:15:05 -05:00
parent 6b42ba410f
commit ce5d12225e
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/integration_tests/charts/api_tests.py
View File

@@ -1255,9 +1255,16 @@ class TestChartApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCase):
chart_newer = self.insert_chart(
"regression_27500_newer", [admin.id], 1, description="z"
)
# Use timestamps whose humanized strings sort DIFFERENTLY from their
# real timestamps under a naive lexical sort. "3 hours ago" vs
# "5 hours ago": lexical-desc puts "5..." first (older), but
# timestamp-desc must put "3..." first (newer). If the API ever
# accidentally sorts by the humanized text instead of the column,
# this test fails. (Pairs like "now"/"2 days ago" don't discriminate
# because 'n' > '2' lexically agrees with newest-first.)
now = datetime.utcnow()
chart_older.changed_on = now - timedelta(days=2)
chart_newer.changed_on = now
chart_older.changed_on = now - timedelta(hours=5)
chart_newer.changed_on = now - timedelta(hours=3)
db.session.commit()
try: