QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(playwright): Download dashboard correctly (#35484)

Browse Source 
Co-authored-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi>
This commit is contained in:
Erkka Tahvanainen
2025-10-20 17:57:01 +03:00
committed by GitHub
parent 0b3fe3d60c
commit d089a96163
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
superset/utils/webdriver.py
View File

@@ -216,6 +216,13 @@ class WebDriverPlaywright(WebDriverProxy):
return error_messages
@staticmethod
def _get_screenshot(page: Page, element: Locator, element_name: str) -> bytes:
if element_name == "standalone":
return page.screenshot(full_page=True)
else:
return element.screenshot()
def get_screenshot( # pylint: disable=too-many-locals, too-many-statements # noqa: C901
self, url: str, element_name: str, user: User
) -> bytes | None:
@@ -363,11 +370,18 @@ class WebDriverPlaywright(WebDriverProxy):
"falling back to standard screenshot"
)
)
img = element.screenshot()
img = WebDriverPlaywright._get_screenshot(
page, element, element_name
)
else:
img = element.screenshot()
img = WebDriverPlaywright._get_screenshot(
page, element, element_name
)
else:
img = element.screenshot()
img = WebDriverPlaywright._get_screenshot(
page, element, element_name
)
except PlaywrightTimeout:
# raise again for the finally block, but handled above
pass