QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix auto select override pre-selected value bug (#2745)

Browse Source 
auto select should only apply to cases where select control doesn't have pre-selected value prop. If select control has pre-selected value (passed in from value prop), auto select first avaliable options should not apply.
This commit is contained in:
Grace Guo
2017-05-10 17:27:43 -07:00
committed by GitHub
parent 3208a014ff
commit d5e9d5d045
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/javascripts/components/AsyncSelect.jsx
View File

@@ -41,7 +41,7 @@ class AsyncSelect extends React.PureComponent {
$.get(this.props.dataEndpoint, (data) => {
this.setState({ options: mutator ? mutator(data) : data, isLoading: false });
if (this.props.autoSelect && this.state.options.length) {
if (!this.props.value && this.props.autoSelect && this.state.options.length) {
this.onChange(this.state.options[0]);
}
})

12
superset/assets/spec/javascripts/components/AsyncSelect_spec.jsx
View File

@@ -66,5 +66,17 @@ describe('AsyncSelect', () => {
expect(spy.callCount).to.equal(1);
expect(spy.calledWith(wrapper.instance().state.options[0])).to.equal(true);
});
it('should not auto select when value prop is set', () => {
const wrapper = mount(
<AsyncSelect {...mockedProps} value={2} autoSelect />,
);
const spy = sinon.spy(wrapper.instance(), 'onChange');
server.respond();
expect(spy.callCount).to.equal(0);
expect(wrapper.find(Select)).to.have.length(1);
expect(wrapper.find('.Select-value-label').children().first().text()).to.equal('another');
});
});
});