QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-03 14:49:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(native-filters): filter type check when using experimental flag (#15446)

Browse Source
This commit is contained in:
Ville Brofeldt
2021-06-29 15:04:39 +03:00
committed by GitHub
parent 727847d2e5
commit dd407331a6
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View File

@@ -669,8 +669,8 @@ const FiltersConfigForm = (
? FILTER_TYPE_NAME_MAPPING[name]
: undefined;
const isDisabled =
FILTER_SUPPORTED_TYPES[filterType].length === 1 &&
FILTER_SUPPORTED_TYPES[filterType].includes(
FILTER_SUPPORTED_TYPES[filterType]?.length === 1 &&
FILTER_SUPPORTED_TYPES[filterType]?.includes(
GenericDataType.TEMPORAL,
) &&
!doLoadedDatasetsHaveTemporalColumns;

1
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/utils.ts
View File

@@ -97,4 +97,5 @@ export const hasTemporalColumns = (
export const doesColumnMatchFilterType = (filterType: string, column: Column) =>
!column.type_generic ||
!(filterType in FILTER_SUPPORTED_TYPES) ||
FILTER_SUPPORTED_TYPES[filterType].includes(column.type_generic);