QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

bug fix (#17019)

Browse Source
This commit is contained in:
AAfghahi
2021-10-08 13:19:04 -04:00
committed by GitHub
parent a6173f1929
commit e32a12fa0b
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
View File

@@ -551,6 +551,10 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
});
// cast the new encrypted extra object into a string
dbToUpdate.encrypted_extra = JSON.stringify(additionalEncryptedExtra);
// this needs to be added by default to gsheets
if (dbToUpdate.engine === 'gsheets') {
dbToUpdate.impersonate_user = true;
}
}
if (dbToUpdate?.parameters?.catalog) {

9
superset/db_engine_specs/gsheets.py
View File

@@ -153,9 +153,12 @@ class GSheetsEngineSpec(SqliteEngineSpec):
cls, parameters: GSheetsParametersType,
) -> List[SupersetError]:
errors: List[SupersetError] = []
encrypted_credentials = json.loads(
parameters.get("service_account_info") or "{}"
)
encrypted_credentials = parameters.get("service_account_info") or "{}"
# On create the encrypted credentials are a string,
# at all other times they are a dict
if isinstance(encrypted_credentials, str):
encrypted_credentials = json.loads(encrypted_credentials)
table_catalog = parameters.get("catalog", {})