QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 15:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): redandant force param (#25985)

Browse Source
This commit is contained in:
JUST.in DO IT
2023-11-16 12:58:06 -08:00
committed by GitHub
parent 5fccf67cdc
commit e7a1876807
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/components/Chart/Chart.jsx
View File

@@ -169,7 +169,7 @@ class Chart extends React.PureComponent {
// Create chart with POST request
this.props.actions.postChartFormData(
this.props.formData,
this.props.force || getUrlParam(URL_PARAMS.force), // allow override via url params force=true
Boolean(this.props.force || getUrlParam(URL_PARAMS.force)), // allow override via url params force=true
this.props.timeout,
this.props.chartId,
this.props.dashboardId,

2
superset-frontend/src/components/Chart/chartAction.js
View File

@@ -183,7 +183,7 @@ const v1ChartDataRequest = async (
const qs = {};
if (sliceId !== undefined) qs.form_data = `{"slice_id":${sliceId}}`;
if (dashboardId !== undefined) qs.dashboard_id = dashboardId;
if (force !== false) qs.force = force;
if (force) qs.force = force;
const allowDomainSharding =
// eslint-disable-next-line camelcase

4
superset-frontend/src/components/Chart/chartActions.test.js
View File

@@ -51,7 +51,7 @@ describe('chart actions', () => {
.callsFake(() => MOCK_URL);
getChartDataUriStub = sinon
.stub(exploreUtils, 'getChartDataUri')
.callsFake(() => URI(MOCK_URL));
.callsFake(({ qs }) => URI(MOCK_URL).query(qs));
fakeMetadata = { useLegacyApi: true };
metadataRegistryStub = sinon
.stub(chartlib, 'getChartMetadataRegistry')
@@ -81,7 +81,7 @@ describe('chart actions', () => {
});
it('should query with the built query', async () => {
const actionThunk = actions.postChartFormData({});
const actionThunk = actions.postChartFormData({}, null);
await actionThunk(dispatch);
expect(fetchMock.calls(MOCK_URL)).toHaveLength(1);