QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixing LIKE constant name (#5110)

Browse Source
This commit is contained in:
Gabe Lyons
2018-05-31 11:34:51 -07:00
committed by Maxime Beauchemin
parent cefc206a36
commit f3778c3c81
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset/assets/spec/javascripts/explore/components/AdhocFilterEditPopoverSimpleTabContent_spec.jsx
View File

@@ -113,13 +113,13 @@ describe('AdhocFilterEditPopoverSimpleTabContent', () => {
it('will filter operators for table datasources', () => {
const { wrapper } = setup({ datasource: { type: 'table' } });
expect(wrapper.instance().isOperatorRelevant('regex')).to.be.false;
expect(wrapper.instance().isOperatorRelevant('like')).to.be.true;
expect(wrapper.instance().isOperatorRelevant('LIKE')).to.be.true;
});
it('will filter operators for druid datasources', () => {
const { wrapper } = setup({ datasource: { type: 'druid' } });
expect(wrapper.instance().isOperatorRelevant('regex')).to.be.true;
expect(wrapper.instance().isOperatorRelevant('like')).to.be.false;
expect(wrapper.instance().isOperatorRelevant('LIKE')).to.be.false;
});
it('expands when its multi comparator input field expands', () => {

2
superset/assets/src/explore/AdhocFilter.js
View File

@@ -19,7 +19,7 @@ const OPERATORS_TO_SQL = {
'<=': '<=',
in: 'in',
'not in': 'not in',
like: 'like',
LIKE: 'like',
};
function translateToSql(adhocMetric, { useSimple } = {}) {

2
superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
View File

@@ -42,6 +42,8 @@ function translateOperator(operator) {
return 'equals';
} else if (operator === OPERATORS['!=']) {
return 'not equal to';
} else if (operator === OPERATORS.LIKE) {
return 'like';
}
return operator;
}

4
superset/assets/src/explore/constants.js
View File

@@ -16,11 +16,11 @@ export const OPERATORS = {
'<=': '<=',
in: 'in',
'not in': 'not in',
like: 'like',
LIKE: 'LIKE',
regex: 'regex',
};
export const TABLE_ONLY_OPERATORS = [OPERATORS.like];
export const TABLE_ONLY_OPERATORS = [OPERATORS.LIKE];
export const DRUID_ONLY_OPERATORS = [OPERATORS.regex];
export const HAVING_OPERATORS = [
OPERATORS['=='],