fix(RightMenu): Move RightMenu carets to the right side (#34756)

superset-frontend/src/features/home/LanguagePicker.tsx

@@ -79,6 +79,7 @@ export const useLanguageMenuItems = ({
       ),
       icon: <Icons.CaretDownOutlined iconSize="xs" />,
       children: items,
+      className: 'submenu-with-caret',
       popupClassName: 'language-picker-popup',
     };
   }, [languages, locale]);

superset-frontend/src/features/home/RightMenu.tsx

@@ -577,6 +577,7 @@ const RightMenu = ({
             data-test="new-dropdown-icon"
           />
         ),
+        className: 'submenu-with-caret',
         icon: <Icons.CaretDownOutlined iconSize="xs" />,
         children: buildNewDropdownItems(),
         ...{ 'data-test': 'new-dropdown' },
@@ -596,6 +597,7 @@ const RightMenu = ({
       label: t('Settings'),
       icon: <Icons.CaretDownOutlined iconSize="xs" />,
       children: buildSettingsMenuItems(),
+      className: 'submenu-with-caret',
     });
 
     return items;
@@ -680,6 +682,15 @@ const RightMenu = ({
           display: flex;
           flex-direction: row;
           align-items: center;
+
+          .submenu-with-caret {
+            padding: 0 ${theme.paddingSM}px;
+            .ant-menu-submenu-title {
+              display: flex;
+              gap: ${theme.sizeUnit * 2}px;
+              flex-direction: row-reverse;
+            }
+          }
         `}
         selectable={false}
         mode="horizontal"

superset-frontend/src/hooks/useThemeMenuItems.tsx

@@ -134,6 +134,7 @@ export const useThemeMenuItems = ({
     key: 'theme-sub-menu',
     label: selectedThemeModeIcon,
     icon: <Icons.CaretDownOutlined iconSize="xs" />,
+    className: 'submenu-with-caret',
     children,
   };
 };