Commit Graph

1850 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson
2c8e06e929 initial fix (#16998) 2021-10-08 10:56:14 -07:00
Phillip Kelley-Dotson
bdbcfbc8fc fix: show onhover menu only in edit mode (#17034)
* fix on markdown hover menu

* lint-fix
2021-10-08 10:54:16 -07:00
AAfghahi
e32a12fa0b bug fix (#17019) 2021-10-08 10:19:04 -07:00
Geido
a6173f1929 chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940)
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors
2021-10-08 17:33:04 +03:00
Geido
a57ae35011 fix: Verify when null value should be undefined in Select (#17013)
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
2021-10-08 17:32:09 +03:00
Geido
42efcdf027 chore(Dashboard): Implement dedicated message for missing dataset (#16959)
* Implement dedicated message

* Clean up
2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3 fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
AAfghahi
50ad09bbdc removing paramProperties (#17024) 2021-10-07 15:28:41 -04:00
Michael S. Molina
be211437de fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Michael S. Molina
c471a85170 fix: Unnecessary queries when changing filter values (#16994) 2021-10-07 13:07:33 -03:00
Evan Rusackas
5f73ca85d5 feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001)
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
2021-10-07 08:26:57 -06:00
Geido
66b0877445 Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Kamil Gabryjelski
45908ff104 fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007)
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs
2021-10-07 14:23:26 +02:00
Geido
a782a62097 chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00
jinghua-qa
6dc00b3e3f fix: letter format of sort chart in dashboard edit (#17003) 2021-10-07 16:29:16 +08:00
Evan Rusackas
ac509611b6 chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor (#16999)
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor

* putting the background back in, but using the theme.

* should be no need for this import anymore.
2021-10-07 09:46:37 +02:00
Evan Rusackas
66fbce9dec chore: removing use of supersetTheme in favor of ThemeProvider (#17000) 2021-10-07 10:36:57 +03:00
Lyndsi Kay Williams
90cfa7fb22 fix: FilterableTable result div width (#16912)
* FilterableTable result div width is now inherit

* Changed style to css
2021-10-06 13:14:35 -07:00
Hugh A. Miles II
40861b3db3 fix: check if owners are actually being updated in PUT /datasets/<id> (#16941)
* check if owners are actually being updated

* move logic to FE

* fix

* fix
2021-10-06 11:26:02 -07:00
Michael S. Molina
191033cb44 chore: Translates the favorite filter param (#16990) 2021-10-06 11:04:14 -03:00
Michael S. Molina
c57719128f fix: When click on "View all" from favorite tab, get error (#16988) 2021-10-06 08:18:56 -03:00
David Aaron Suddjian
1cd0124fd5 chore: upgrade babel (#16885)
* upgrade babel versions

* upgrade babel eslint parser

* fix test
2021-10-05 15:02:57 -07:00
Youkyoung Cha
93ebe3d963 fix: handle mixed time-series error (#16928)
* rebase to master

* Fix line 402

Co-authored-by: yougyoung <yougyoung@pubg.com>
2021-10-05 16:00:22 +03:00
Elizabeth Thompson
5866d5ebb0 fix: Revert "fix: RBAC hide right menu (#16902)" (#16968)
* Revert "fix: RBAC hide right menu (#16902)"

This reverts commit 87baac7650.

* fix failing test
2021-10-04 19:18:12 -07:00
Phillip Kelley-Dotson
50ad84bd03 chore: refactor header menu to show in header grid component (#16689)
* initial commit

* add delete to markdown
2021-10-04 15:01:17 -07:00
Geido
3f0756f637 chore: Select component refactoring - SelectControl - Iteration 5 (#16510)
* Refactor Select DatasourceEditor

* Fire onChange with allowNewOptions

* Clean up

* Refactor Select in AnnotationLayer

* Handle on clear

* Update tests

* Refactor Select in SpatialControl

* Show search

* Refactor Select in FilterBox

* Remove search where unnecessary

* Update SelectControl - WIP

* Refactor Controls

* Update SelectControl tests

* Clean up

* Test allowNewOptions false

* Use SelectControl AnnotationLayer

* Use SelectControl SpatialControl

* Clean up

* Render custom label

* Show search

* Implement filterOption

* Improve filterOption

* Update Cypress

* Update Cypress table test

* Use value for defaultValue

* Merge with latest changes

* Reconcile with latest Select changes

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Revert changes to test

* Call onPopoverClear when v value is undefined

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-04 18:24:41 +03:00
Michael S. Molina
1ab36c94f3 chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Michael S. Molina
028f6c0d3f chore: Moves spec files to the src folder - iteration 6 (#16935) 2021-10-04 10:56:30 -03:00
Yongjie Zhao
6225c9a4a3 fix: replace absolute difference with difference in legacy charts (#16931) 2021-10-02 09:10:20 +08:00
Phillip Kelley-Dotson
3f6a24fe1a chore: add certified columns to top of list (#16910)
* initial commit

* inital commit

* add suggestions

* remove changes

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-01 11:50:03 -07:00
Ville Brofeldt
a07c9d591b fix(dashboard): recursive parent on dashboard components (#16933)
* fix(dashboard): don't add recursive parents on wrapper component

* add test

* refine logic and add new test
2021-10-01 08:13:38 -07:00
Michael S. Molina
90f711f45c chore: Moves spec files to the src folder - iteration 5 (#16927) 2021-10-01 11:24:41 -03:00
Hugh A. Miles II
87baac7650 fix: RBAC hide right menu (#16902)
* add provider to right menu

* add roles code

* bad pull
2021-09-30 14:33:54 -04:00
Michael S. Molina
87290ddcc8 fix: Native filters cyclic dependency (#16921) 2021-09-30 14:55:54 -03:00
Michael S. Molina
c5d23fbcc7 fix: Unable to add dataset (#16925) 2021-09-30 14:52:48 -03:00
Geido
7f330c9692 Verify undefined operatorId (#16923) 2021-09-30 18:53:48 +03:00
Geido
c8db435730 fix(Explore): Clear filter value when changing columns (#16871)
* Clear filter value onChange

* Clear filter value on user change action
2021-09-30 17:18:08 +03:00
Michael S. Molina
1a38ec6c43 chore: Adds the drag icon (#16919) 2021-09-30 10:29:12 -03:00
Michael S. Molina
3d520f2cc9 fix: Inclusive sign in time range display (#16906)
* fix: Time range display to show inclusive range

* Skips flakky test
2021-09-30 09:57:07 -03:00
Michael S. Molina
ae26967c4e fix: Disable lazy loading for the Database selector (#16908)
* fix: Disable lazy loading for the Database selector

* Fixes the tests
2021-09-30 09:29:27 -03:00
Michael S. Molina
05632b9804 chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Hugh A. Miles II
331de0c4ae fix: Fix Uniqueness check before update for Sqllab Overwrites (#16859)
* add condition to make sure columns are available before throwing

* fix

* remove database_id from history changed

* refactor update call to datasets

* cleanup

* oops

* prettier
2021-09-29 13:38:29 -04:00
AAfghahi
904c506591 fixing db connection (#16899) 2021-09-29 10:02:34 -07:00
Michael S. Molina
4da4fe4136 fix: Removing parent filter causes incorrect state of child filter (#16876)
* fix: Removing parent filter causes incorrect state of child filter

* removed to isRemoved

* Shows (deleted) when the parent is removed

* Removes unnecessary code
2021-09-29 13:04:07 -03:00
simcha90
3d8cc15cba fix: Clear native filters state (#16893)
* fix:fix get permission function

* fix: clear native filters state
2021-09-29 13:50:21 +03:00
Michael S. Molina
e3b14fe170 fix: Overhead when changing the filter name (#16877) 2021-09-29 07:37:02 -03:00
AAfghahi
aa747219ad feat: Add Private Google Sheets to dynamic form (#16628)
* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* Regenerate package-lock.json

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-28 17:08:50 -07:00
Ville Brofeldt
9ac55d9afa fix(build): enable hot reloading of linked packages (#16867) 2021-09-28 16:21:17 +02:00
Geido
d3f6145aba fix(dashboard): Fill form with the latest values when undo in native filters (#16851)
* Set undoFormValues

* Reorganize

* Revert check

* Fix and clean up

* Fix pre-filter and sort values
2021-09-27 09:39:26 -07:00