Will Barrett
8e23d4f369
chore: Upgrade pylint to 2.5.3 and fix most new rules ( #10101 )
...
* Bump pylint version to 2.5.3
* Add a global disable for the most common new pylint error
* Fix a bunch of files containing very few errors
* More pylint tweakage, low-hanging fruit
* More easy stuff...
* Fix more erroring files
* Fix the last couple of errors, clean pylint!
* Black
* Fix mypy issue in connectors/druid/models.py
2020-06-18 14:03:42 -07:00
Bogdan
be6b9b8fec
feat: implement dttm column configuration through db extra config ( #9444 )
...
* Implement table mutator and examples how to set date defaults
Fix tests
* Fix flaky test
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-06-17 13:46:45 -07:00
Will Barrett
01aede0652
refactor: Break up superset/views/core.py ( #10078 )
...
* Remove unreferenced function from views/core.py
* Remove excess constants from views/core.py
* Extract CssTemplate-related views to their own file from core.py
* Remove duplicate constant declaration and make the constant less racist
* Move free-floating functions in views/core.py to views/utils.py
* Move AccessRequestsModelView out of views/core.py into its own module
* Move health checks and KV ModelView out of core.py and into their own modules
* Move R model view to its own module
* Move after-request header setting to views/base.py from views/core.py
* black
* mypy
* isort
* Fix reference to imported app
* pylint
* Fix some imports
* Add some missing view imports
* Fix a missing import
2020-06-17 13:42:13 -07:00
Bogdan
29e9f2c70b
feat: superset report slack integration ( #9810 )
...
* First draft for the slack integration
Fix slack
another typo
another typo
Fix slack
Add channels to the form
another typo
Another set of changes
Make code more transparent
Fix tests
Add logging
logging
use logger
import logging
import logging
import logging
add assert
more logging
Fix channels
Fix channels
* Address comments
* Move slack into a separate module
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-06-17 11:01:25 -07:00
John Bodley
eba1fe2ebb
fix: Ensuring queries route accepts float or int ( #10079 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-17 08:02:49 -07:00
ʈᵃᵢ
26120467af
fix: use custom int parsing over flask int parsing in sqllab queries endpoint ( #10070 )
2020-06-16 12:58:32 -07:00
Erik Ritter
7504b1cf20
fix: caching on viz with relative time ranges and time compare ( #10061 )
2020-06-16 08:47:35 -07:00
Maxime Beauchemin
280ade826c
fix: dashboard export raises schema issues ( #10060 )
...
* fix: dashboard export raises schema issues
* Fix isort
2020-06-15 21:43:05 -07:00
Ville Brofeldt
a3393c1bc4
fix: native annotations ( #10037 )
...
* fix: native annotations
* Add test
* Add comment to test
2020-06-12 21:53:26 +03:00
John Bodley
9532bff48f
chore(security): Renaming access methods ( #10031 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-11 13:12:23 -07:00
John Bodley
54c6ddbdb7
chore(security): Renaming schemas_accessible_by_user ( #10030 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-11 11:29:43 -07:00
Daniel Vaz Gaspar
c9ee598ac9
fix(security): can_access with None crashes on builtin roles ( #10039 )
2020-06-11 16:02:08 +01:00
serenajiang
8744dadca8
[csv upload][hive] support other delimiters ( #9971 )
...
Co-authored-by: serena-jiang <serena.jiang@airbnb.com >
2020-06-10 17:08:02 -07:00
John Bodley
36627af916
fix: Resolves a regression from #9939 ( #10033 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-10 13:42:08 -07:00
Will Barrett
4ef26993e2
feat: Add owners and physical/virtual status to Datasets API list endpoint ( #10025 )
...
* Add owners and physical/virtual status to Datasets API list endpoint
* black
* Update type definition for DatasourceKind
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
* Fixin' tests and mypy
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com >
2020-06-10 22:04:40 +03:00
Erik Ritter
e17da58a39
feat: add replace option to hive csv upload ( #9764 )
2020-06-10 08:57:33 -07:00
Lily Kuang
f6cd3a917a
refactor(sql): optimize sql query parser ( #9673 )
...
* optimize sql query parser
* update extract from token
* update doc string
* pylint doc string
2020-06-10 09:15:48 +03:00
Ville Brofeldt
7cb38fe28b
chore: remove markup from viz.py ( #9997 )
2020-06-10 07:49:09 +03:00
serenajiang
280b4dce00
fix(SankeyViz): enforce source/target order ( #10003 )
...
* fix(SankeyViz): enforce source/target order
* address pr comments
* black
Co-authored-by: serena-jiang <serena.jiang@airbnb.com >
2020-06-09 10:13:48 -07:00
Ville Brofeldt
315518d2d2
feat: add support for query offset ( #10010 )
...
* feat: add support for query offset
* Address comments and add new tests
2020-06-09 11:46:28 +03:00
John Bodley
91517a56a3
style(mypy): Spit-and-polish pass ( #10001 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-07 08:53:46 -07:00
John Bodley
63e0188f45
style(mypy): Enforcing typing for superset.views ( #9939 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-05 08:44:11 -07:00
Ville Brofeldt
5c4d4f16b3
feat: finalize Word Cloud move to new chart data endpoint ( #9975 )
...
* remove word cloud from viz.py
* Fix Run in SQL Lab
* remove deprecated python tests
* break out legacy endpoint type into function
* Break out exploreChart from exportChart and implement results type
* Fix jest tests and refactor accordingly
* lint
* Rename v1 payload function
* Add dashboard id to v1 chart data request url params
* Add support for domain sharding to v1 chart data request
2020-06-05 14:08:46 +03:00
Daniel Vaz Gaspar
543a3ca6f2
fix(api): Wrong parameter name on database openapi spec ( #9965 )
2020-06-04 15:21:23 +01:00
Bogdan
a48a2e44b5
fix: display python_date_format in react views as well ( #9934 )
...
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-06-03 20:24:25 -07:00
John Bodley
244677cf5e
style(mypy): Enforcing typing for superset ( #9943 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-03 15:26:12 -07:00
Grace Guo
dcac860f3e
feat: [dashboard] notification and warning for auto force refresh ( #9886 )
...
* feat: [dashboard] notification and warning for auto force refresh
* fix review comments
2020-06-03 10:20:56 -07:00
John Bodley
ee777acd57
fix(mypy): Resolves regression introducted in #9824 ( #9973 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-03 00:20:34 -07:00
Xiang Fu
1d9dbcd9dc
fix: pinot select query logic ( #9954 )
...
* Update how pinot handles selection logic
* Change DATETIMECONVERT argument to use single quote for literals
2020-06-02 23:18:35 -07:00
Maxime Beauchemin
209392e9ef
feat: make CRUD annotations inline ( #9888 )
...
* feat: make CRUD annotations inline
This makes the annotations inline of the "annotation layers". Originally
they were setup as separate ModelViews because of a bug in FAB.
* fix pylint
2020-06-02 23:12:37 -07:00
John Bodley
1001c6d5f4
Revert "[caching] Using request context rather than globals" ( #9969 )
...
This reverts commit 90cd3889ac .
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-02 16:03:33 -07:00
John Bodley
15f267d586
style(mypy): Fix memoize watch type ( #9970 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-06-02 16:02:07 -07:00
Ville Brofeldt
38a6bd79da
feat: expand new chart data endpoint coverage ( #9903 )
...
* feat: implement new chart API for additional components
* Fix python tests
* Fix tests
* Fix lint
* fix camel case error in requestParams
* lint
* fix samples row limit
* Add samples row limit to config
* remove unnecessary code
* lint
* Address review comments
2020-06-02 10:47:28 +03:00
John Bodley
b296a0f250
[mypy] Enforcing typing for superset.utils ( #9905 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-27 22:57:30 -07:00
John Bodley
54dced1cf6
style(mypy): Enforcing mypy typing for views.chart ( #9912 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-27 21:31:26 -07:00
John Bodley
b010c35887
style(mypy): Enforcing typing for views.database ( #9920 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-27 21:04:48 -07:00
John Bodley
5ce1076f3c
style(mypy): Enforcing typing for views.dashboard ( #9921 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-27 20:43:11 -07:00
Erik Ritter
c4040a2ae0
fix: annotation layer json ( #9915 )
...
* fix: annotation layer json
* attempt to add a test
* [tests] Fixing test
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-27 09:02:03 -07:00
Maxime Beauchemin
92b843e2ae
css: beautify roles CRUD ( #9890 )
2020-05-26 22:32:13 -07:00
John Bodley
7f6dbf838e
style: enforcing mypy typing for connectors ( #9824 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-25 12:32:49 -07:00
tooptoop4
bd959919e3
Fix missing line break in Database 'extra' instructions ( #9895 )
2020-05-23 17:36:51 -07:00
John Bodley
e789a35558
[mypy] Enforcing typing for superset.models ( #9883 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-22 20:31:21 -07:00
Maxime Beauchemin
ee991963c7
fix: don't create examples db on 'superset init' ( #9881 )
...
* chore: don't create examples db on 'superset init'
* fix isort
2020-05-21 21:34:53 -07:00
Bogdan
3e8e441bfc
feat: implement csv upload configuration func for the schema enforcement ( #9734 )
...
* Implement csv upload func for schema enforcement
Implement function controlled csv upload schema
Refactor + fix tests
Fixing hive as well
* Add explore_db to the extras
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com >
2020-05-21 13:49:53 -07:00
Daniel Vaz Gaspar
61ebb9bbc4
fix: chart datasource explore URL showing datasource name for druid ( #9839 )
2020-05-21 10:45:47 +01:00
Will Barrett
13c24372b0
fix: Emit a warning message rather than an exception on query failure ( #9811 )
...
* Emit a warning message rather than an exception on query failure
* Add exc_info=True to warning message
2020-05-20 13:13:28 -07:00
Ville Brofeldt
a43a1d6303
feat: Add new result formats and types to chart data API ( #9841 )
...
* feat: Add new result formats and types to chart data API
* lint
* Linting
* Add language to query payload
* Fix tests
* simplify tests
2020-05-20 21:36:14 +03:00
michellethomas
368c85de1b
fix: Removing the logic to add timeseries_limit_metric to the data for table ( #9832 )
...
* Removing the logic to add timeseries_limit_metric to the data for table viz
* Also make the change in viz_sip_38
* Fix tests
Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com >
2020-05-20 10:20:54 -07:00
John Bodley
c691a07948
Revert "[sqllab] fix, strip comments before parsing statements" ( #9862 )
...
This reverts commit 949c4eae28 .
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2020-05-20 09:54:17 -07:00
Lily Kuang
6f1208f510
fixes: limit no authorization error for sentry ( #9816 )
...
* rescue no authorization error
* update no authorization exception to warning
2020-05-20 08:48:32 -07:00