Commit Graph

8497 Commits

Author SHA1 Message Date
Elizabeth Thompson
5045ff4d91 chore: add release to pip requirements (#17752)
* add requests to pip requirements

* fix tests

* add redis typing for mypy

* fix test
1.4.0rc3
2021-12-21 17:46:33 -08:00
Elizabeth Thompson
1e2b2f10f0 update changelog 2021-12-21 17:19:02 -08:00
Elizabeth Thompson
96c18b4272 fix test lint (#17835) 2021-12-21 17:17:13 -08:00
Geido
8057582b02 feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-12-21 11:51:55 -08:00
serenajiang
70228ad3fb fix(dashboard): commit update once (#17781)
(cherry picked from commit 3657cbea7f)
2021-12-20 13:38:55 -08:00
Geido
f4661d6924 fix: Remove positions from json_metadata (#17766)
* Remove positions from json_metadata

* Update superset-frontend/src/dashboard/components/PropertiesModal/index.tsx

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* Indent

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
(cherry picked from commit 274fb37a91)
2021-12-20 13:38:55 -08:00
John Bodley
398a01f7dc chore(engine): Translate fractional time grains—requires @superset-ui bump (#17078)
* chore(engine): Translate fractional time grains

* Bump @superset-ui

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-12-15 17:01:09 -08:00
Elizabeth Thompson
752062674b Revert "fix: import should accept old keys (#17330)"
This reverts commit 0b8507fe77.
2021-12-15 09:30:26 -08:00
Daniel Vaz Gaspar
cda62508c4 ci: temp fix for mysqlclient on an OS regression bug (#17724) 2021-12-15 09:30:20 -08:00
Elizabeth Thompson
2e0fe93269 fix prettier/lint error 2021-12-10 17:08:04 -08:00
Elizabeth Thompson
4991272b9c update changelog 2021-12-10 16:24:17 -08:00
Geido
ba6d5b9754 fix: Save properties after applying changes in Dashboard (#17570)
* Refactor PropertiesModal

* Update json_metadata fully

* Clean up

* Verify values

* Catch changed to metadata

* Always updated dashboard info on update

* Avoid unnecessary fetches

* Formt

* Fix copy dashboards

* Fixes onUpdate onCopy handlers

* Pylint

* Update tests

* Clean up

* Handle data on show

* Change Save to Apply

* Update Cypress save test

* Update Cypress edit prop test

* Update PropertiesModal test

* Fix duplicate request with cross filters

* Improve code style

* Fix typo

* Lint
2021-12-10 16:12:49 -08:00
Ville Brofeldt
8b0ab83119 chore(sql): clean up invalid filter clause exception types (#17702)
* chore(sql): clean up invalid filter clause exception types

* fix lint

* rename exception
2021-12-10 16:07:03 -08:00
Geido
4c00bd4332 fix(Dashboard): Copy dashboard with duplicating charts 500 error (#17707)
* Fix copy dashboard with charts

* Fix Cypress test
2021-12-10 16:01:05 -08:00
Beto Dealmeida
77c4f2cb11 fix: set correct schema on config import (#16041)
* fix: set correct schema on config import

* Fix lint

* Fix test

* Fix tests

* Fix another test

* Fix another test

* Fix base test

* Add helper function

* Fix examples

* Fix test

* Fix test

* Fixing more tests

(cherry picked from commit 1fbce88a46)
2021-12-10 15:40:06 -08:00
Elizabeth Thompson
3d8ce130ba update changelog 2021-12-08 14:59:13 -08:00
Craig Rueda
9837feff19 chore(datasets): Sanitizing /save response (#17579)
(cherry picked from commit ac76defc05)
2021-12-08 13:51:15 -08:00
Corbin Robb
9468bdf0c1 fix(sqllab): Have table name tooltip only show when name is truncated (#17386)
* Add conditional to table name tooltip to only show when overflowing

* Remove uneccessary state and useEffect, a little clean up and slight refactoring

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
(cherry picked from commit 8e1619b105)
2021-12-06 13:46:14 -08:00
Elizabeth Thompson
c42ff7972f use full resultType with csv download on chart in dashboard (#17431)
(cherry picked from commit 71e3fa1bf3)
2021-12-06 13:46:14 -08:00
Ville Brofeldt
46343a9dca fix: avoid escaping bind-like params containing colons (#17419)
* fix: avoid escaping bind-like params containing colons

* fix query for mysql

* address comments

(cherry picked from commit ad8a7c42f9)
2021-12-06 13:46:14 -08:00
Erik Ritter
9818bc5e7a Revert "fix(native-filters): Fix update ownState (#17181)" (#17311)
This reverts commit cf284ba3c7.

(cherry picked from commit 7c6d6f47bf)
2021-12-06 13:46:14 -08:00
Geido
733fc7494c Handle undefined (#17183)
(cherry picked from commit 91199c30d8)
2021-12-06 13:46:13 -08:00
Elizabeth Thompson
361e510cae update changelog and updating.md for 1.4.0 1.4.0rc1 2021-11-22 17:27:19 -08:00
Elizabeth Thompson
eb64f82c20 fix conflicts 2021-11-22 16:48:37 -08:00
Grace Guo
3aa554b422 fix: sql lab crash caused by invalid template (#17133)
(cherry picked from commit 96f4421961)
2021-11-22 16:11:45 -08:00
David Aaron Suddjian
ed45717d5f fix(explore): remove unnecessary parameters from the explore url (#17123)
* remove unnecessary parameters from the explore url

* refactor, test

(cherry picked from commit 57f869cf22)
2021-11-22 16:11:45 -08:00
wijnanjo
6f932f9ec1 fix for undefined userId (#17117)
Co-authored-by: jo.wijnant <jo.wijnant@kontron.com>
(cherry picked from commit c9c669d179)
2021-11-22 16:11:45 -08:00
Lyndsi Kay Williams
b577773e30 fix(sqllab): Hover tooltip flashes in SQL Lab (#17068)
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global

(cherry picked from commit 635898a76d)
2021-11-22 16:11:45 -08:00
Erik Ritter
dfd0ed395c fix: prevent caching error pages (#17100)
(cherry picked from commit 031f594fa3)
2021-11-22 16:11:45 -08:00
Beto Dealmeida
cca78f1b6e fix: accept headers on import (#17080)
* fix: accept headers on import

* Add unit test

(cherry picked from commit 40e9add641)
2021-11-22 16:11:44 -08:00
jinghua-qa
b4f4f4cdfa fix(other): column name in created content on profile page (#17029)
* fix: fix name in created content on profile page

* add more fix on mutater

(cherry picked from commit f2d41dc416)
2021-11-22 16:11:44 -08:00
Geido
5899ae163a fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018)
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
(cherry picked from commit 14b7f6cdba)
2021-11-22 16:11:44 -08:00
Phillip Kelley-Dotson
9459d09ae7 initial fix (#16998)
(cherry picked from commit 2c8e06e929)
2021-11-22 16:11:44 -08:00
Beto Dealmeida
0b8507fe77 fix: import should accept old keys (#17330)
* fix: import should accept old keys

* Fix lint

* Preserve V1 schema
2021-11-22 11:58:13 -08:00
Beto Dealmeida
c015e661a9 fix: clear 'delete' confirmation (#17345)
* fix: clear 'delete' confirmation

* Add tests

(cherry picked from commit 43f4ab845a)
2021-11-22 11:56:56 -08:00
Elizabeth Thompson
7d9f63eda7 fix: add fallback and validation for report and cron timezones (#17338)
* add fallback and validation for report and cron timezones

* add logging to exception catch

* Run black

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
(cherry picked from commit f10bc6d8fe)
2021-11-22 11:53:45 -08:00
Hugh A. Miles II
30c6ec07ef fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log

(cherry picked from commit d0bad96b1a)
2021-11-22 11:53:45 -08:00
Elizabeth Thompson
680cdca14a fix: update values for default timezone selector (#17124)
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx

(cherry picked from commit ae4ced8da6)
2021-11-22 11:53:45 -08:00
AAfghahi
8a24374f9f fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention

(cherry picked from commit 5948a9fd02)
2021-11-22 11:31:20 -08:00
Kamil Gabryjelski
33826cd50f fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls

(cherry picked from commit fa44325a36)
2021-11-22 11:31:20 -08:00
Ville Brofeldt
c4b57e6b3e ci: fix broken test skips (#17005)
(cherry picked from commit 9e980b6f2b)
2021-11-22 11:31:20 -08:00
Michael S. Molina
7db1caa2ad fix: Unnecessary queries when changing filter values (#16994)
(cherry picked from commit c471a85170)
2021-11-22 11:31:20 -08:00
jinghua-qa
687676cb09 fix: letter format of sort chart in dashboard edit (#17003)
(cherry picked from commit 6dc00b3e3f)
2021-11-22 11:31:20 -08:00
serenajiang
2eaf5c854e fix(sqllab): SqlJsonExecutionContext.query null pointer (#16997)
(cherry picked from commit cde4cdcd0c)
2021-11-22 11:31:20 -08:00
Lyndsi Kay Williams
09b853c831 fix: FilterableTable result div width (#16912)
* FilterableTable result div width is now inherit

* Changed style to css

(cherry picked from commit 90cfa7fb22)
2021-11-22 11:31:20 -08:00
Erik Ritter
5f34ae2cf3 fix: Use production build config for cypress tests (#16978)
* fix: Use production build config for cypress tests

* set usedExports to global

(cherry picked from commit 2757b93fea)
2021-11-22 11:31:20 -08:00
Geido
ea3d51efec fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-22 10:55:21 -08:00
Phillip Kelley-Dotson
55b3da661e fix: show onhover menu only in edit mode (#17034)
* fix on markdown hover menu

* lint-fix
2021-11-22 10:49:04 -08:00
Geido
b775193f9f fix: Verify when null value should be undefined in Select (#17013)
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
2021-11-22 10:46:23 -08:00
Geido
7c966c52dc chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-11-22 10:46:07 -08:00