Commit Graph

175 Commits

Author SHA1 Message Date
Evan Rusackas
844b471509 fix: removing unsupported modal sizes (#10625)
* fix: removing unsupported modal sizes

* linting!

* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"

* supporting 'large' and 'small' over 'lg' and 'sm'
2020-08-18 14:33:39 -07:00
Evan Rusackas
08211953b2 chore: migrate console logs to logging service (#10608) 2020-08-16 20:20:47 -07:00
Grace Guo
ca9ca99510 refactor: [migration] convert iframe chart into dashboard markdown component (#10590)
* refactor: [migration] convert iframe chart into dashboard markdown component

* remove 3 viz_types

* fix comments
2020-08-16 14:43:30 -07:00
ʈᵃᵢ
db88cec431 feat: SIP-34 card/grid views for dashboards and charts (#10526) 2020-08-13 14:46:56 -07:00
Evan Rusackas
a3fd2b420e fix: More tweaks needed after adding Doctype tag (#10504)
* fixing last-of-type specificity

* Simplifying/consolidating styles

* fixing filterbox in explore

* linting

* adding some px to font sizes

* fixing in-dash overflow

* removing px for one special fontsize case

* simplifying, addressing comments
2020-08-13 11:50:14 -07:00
Jesse Yang
b6c6b6800a fix: table viz query mode switch not working (#10552) 2020-08-07 14:15:03 -07:00
Erik Ritter
4765f8b10d fix: embedded chart height (#10551) 2020-08-07 13:53:18 -07:00
Jesse Yang
ea0db0d195 bugfix: table chart query mode initial value (#10544) 2020-08-07 02:25:48 -07:00
Maxime Beauchemin
0bad77f0fe chore: TypeScript <Label /> (#10494)
* chore: TypeScript <Label />

* rebase

* chore: TypeScript <Label />

* rebase

* A bunch o' test fixes. One more to go!

* helper for mountying Emotional components with Enzyme

* asf license

* fixed last test, some linting

* improve the storybook

* Adressing comments

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-06 22:33:07 -07:00
Maxime Beauchemin
ece91928a9 style: use tabs in dashboard edit pane (#10394)
* style: use tabs in dashboard edit pane

* fix tests

* more hackin'

* getting ready to rip cell measurer

* working

* pogress

* Fix cards

* done

* fix jest

* fix cy
2020-08-05 18:53:53 -07:00
simchaNielsen
57dc7622b4 fix: show label for filters in filter box in explore (#10412)
* fix: show label for filters in filter box in explore

* test: add test for label in filter box

* test: add test / fix lint

* fix: fix CR notes

* refactor: add label propType to FilterBoxItemControl.jsx
2020-08-05 09:23:11 +03:00
Moriah Kreeger
e040bf7acf feat: add favorite star to dashboard and chart lists (#10510) 2020-08-04 16:34:50 -07:00
Moriah Kreeger
523c6b77bf fix: update time range select tooltip (#10458) 2020-08-04 16:34:20 -07:00
Jesse Yang
246add45a0 fix: explore panel missing padding (#10505) 2020-08-04 15:08:28 -07:00
Lily Kuang
fa07506d0d feat: dataset editor improvements (#10444) 2020-08-04 11:52:35 -07:00
Ville Brofeldt
a43ee22f11 style: replace inclusive/exclusive on DateFilterControl with </≤ (#10420)
* feat: improve filter control tooltips

* add styles

* break out utils into own file

* lint

* add tests

* styled component now working

* lint

* add license headers

* replace shallow with mount due to withTheme

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-07-31 20:06:04 +03:00
Ville Brofeldt
9eab29aeaa fix: enforce mandatory chart name on save and edit (#10482)
* fix: show empty charts as empty in chart list view

* migrate ControlLabel to FormLabel and enforce requred fields

* lint

* reorder buttons
2020-07-31 19:30:02 +03:00
Evan Rusackas
16459ad401 style: DOCTYPE tag, and related CSS cleanup/refactoring (#10302) 2020-07-29 18:49:32 -07:00
Maxime Beauchemin
ea3c3bbae4 style: SIP-34 labels (#10403)
* style: SIP-34 labels

Aligning with SIP-34 designs for labels/pills. Going uppercase fixes the
padding issues we had before, and the rounder pills look better.

Cleaning up some CSS in the process

* lint
2020-07-24 18:03:38 -07:00
Maxime Beauchemin
b438ba9ed5 chore: wiring ControlLabel to a new FormLabel (#10388)
* chore: wiring ControlLabel to a new FormLabel

Creating new simple <FormLabel /> component and wiring all <label>
and react-bootstrap.ControlLabel towards it.

FormLabel becomes a pivotal point that can be altered to point to AntD
when we're ready.

* lint

* ViewportControl

* addressing comments
2020-07-23 00:27:22 -07:00
Maxime Beauchemin
ea53916730 feat: SIP-34 explore save modal (#10355)
* feat: SIP-34 explore save modal

* using a const for the session storage key

* backend changes

* minor tweaks

* more tweaks

* radio cosmetics

* styles

* fix tests

* CreatableSelect\!

* Fix cypress & lint

* fix unit

* lint
2020-07-23 00:26:29 -07:00
Erik Ritter
5fa4680447 feat: update timeout error UX (#10274) 2020-07-20 15:32:17 -07:00
Phillip Kelley-Dotson
7d10669ca8 move control panel to filterbox folder (#10346) 2020-07-20 13:40:00 -07:00
Erik Ritter
5984df3522 chore: enable no-static-element-interactions eslint rule (#10351) 2020-07-17 09:19:16 -07:00
Erik Ritter
09de805017 chore: enable no-unused-vars and prefer-template eslint rules (#10350) 2020-07-16 19:13:59 -07:00
Erik Ritter
6ae9f3af8e feat: add download as image button to explore (#10297) 2020-07-14 16:40:12 -07:00
Jesse Yang
96e0da9fea fix(table-viz): table chart time column should use default (#10293) 2020-07-13 23:44:57 -07:00
Jesse Yang
4d179622fa fix(explore): edit datasource does not update control states (#10284) 2020-07-10 12:46:25 -07:00
Maxime Beauchemin
7d4d2e7469 fix(explore): 'Edit Datasource' is missing from btn-dropdown (#10283)
Not sure how it got broken but he's a fix. I'm thinking this is related
to the controls refactor.

closes https://github.com/apache/incubator-superset/issues/10247
2020-07-10 00:11:53 -07:00
Jesse Yang
af864e9fff fix: deckgl dimension select missing options (#10277)
Fixes #10246
2020-07-09 18:27:05 -07:00
Ville Brofeldt
c0d663db9a feat: show formatted dates instead of epoch on results (#10268) 2020-07-09 20:48:53 +03:00
Jesse Yang
e94c9804a2 fix: optimize mapStateToProps for chart controls (#10264) 2020-07-09 00:33:48 -07:00
Evan Rusackas
3dfa4aa15d chore: nixing requiresTime (#10259) 2020-07-08 17:10:03 -07:00
Grace Guo
f6ccd61547 [fix] disable search all options by default (#10260) 2020-07-08 16:43:38 -07:00
Jesse Yang
e5761d3cf7 fix(table-viz): JS error when sort time column (#10250) 2020-07-07 21:28:09 -07:00
Grace Guo
f849103374 feat: Typeahead searchable filter_box for dashboard (#10210)
* [WIP] Typeahead dashboard filter_box

* Make it work

* add config option for async filter_box

* enable for > 1000 options only

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-07-07 09:31:18 -07:00
Jesse Yang
700429f431 fix: chart validation error not cleared on control value update (#10224) 2020-07-01 18:32:27 -07:00
Jesse Yang
9bdfa055ac feat(viz): add query mode switch to table chart (#10113)
1, Replace table chart rendering from jquery.DataTables to react-table: apache-superset/superset-ui#623
2. Rearrange the control panel, replace GROUP BY and NOT GROUP BY with a "Query Mode" switch: apache-superset/superset-ui#609
2020-06-28 21:37:04 -07:00
Jesse Yang
ecb44a4243 refactor: import emotion-theming methods from @superset-ui/style (#10157)
This makes the code cleaner and fixes missing theme variables when `npm link @superset-ui/style`.
2020-06-24 19:23:51 -07:00
Evan Rusackas
36ea42f092 fix: Loading overlay bugfix and cleanup (#10105)
* fix: reordering DOM output, simplifying styles, Emotionalizing

* simplification

* converting RefreshChartOverlay to TS

* Loading -> TS, stripping unused size prop

* simplification...

* just letting "position" prop act as a class name. Simpler!

* consolidating styles, changing a className prop to a position prop.

* nixing (unused) classname prop

* replacing inline loading img with the proper Loading component

* BY THERE.

* position prop is optional!
2020-06-24 14:21:45 -07:00
Ville Brofeldt
38667b72b1 fix: refine shouldUseLegacyApi and add tests (#10148)
* fix: refine shouldUseLegacyApi and add tests

* address review comments
2020-06-24 19:38:36 +03:00
Jesse Yang
ed4f6e93ac chore: bump superset-ui to v0.14.1 (#10112) 2020-06-22 11:14:23 -07:00
Maxime Beauchemin
cf0f1d568d style: replace broken glyphs with font-awesome (#10123)
Glyphicons stopped working recently, not sure why, but let's get rid of
them and double down on font-awesome that we use a lot more in the
codebase. There's only a few instances of glyphicons and they all are
broken ATM.

Also a few other minor style tweaks
2020-06-21 21:38:08 -07:00
Will Barrett
961b55cfba fix: Visualization settings were lost when editing a datasource from Explore (#10092) 2020-06-19 12:55:49 -07:00
Maxime Beauchemin
a6390afb89 style: push bootstrap theme towards SIP-34 styles (#10056)
* feat: cartel theme

* piling

* more tweaks

* Make things look better

* lint

* fix tests

* paint it black

* tweaks
2020-06-18 15:01:58 -07:00
Phillip Kelley-Dotson
02fee35314 chore(metricoption): remove metricoption and columntypelable dependency (#10077)
* remove columntypeLabel and metricoptions from superset

* fix lint

* remove old test

* update pakage

* add suggestions

* fix merge conflict
2020-06-17 19:55:17 -07:00
Ville Brofeldt
d3a9ce5afc fix: chart export fails when buildQuery not present (#10062) 2020-06-16 09:25:10 -07:00
Ville Brofeldt
ee77707532 feat: add deafult buildQuery for V1 chart data requests (#10048) 2020-06-12 07:49:13 -07:00
Natalie Ruhe
d1588c7658 Fix chart annotation source type showing perpetual loading when re-selecting the same value. (#10036)
Remove accidental console.log used during testing.

Co-authored-by: Natalie Ruhe <natalie@preset.io>
2020-06-10 16:17:56 -07:00
Ville Brofeldt
a8db78b069 chore: bump superset-ui to 0.13.27 (#10018)
* chore: bump superset-ui

* Remove redundant control panels
2020-06-10 10:13:00 +03:00