Commit Graph

175 Commits

Author SHA1 Message Date
Ville Brofeldt
5c4d4f16b3 feat: finalize Word Cloud move to new chart data endpoint (#9975)
* remove word cloud from viz.py

* Fix Run in SQL Lab

* remove deprecated python tests

* break out legacy endpoint type into function

* Break out exploreChart from exportChart and implement results type

* Fix jest tests and refactor accordingly

* lint

* Rename v1 payload function

* Add dashboard id to v1 chart data request url params

* Add support for domain sharding to v1 chart data request
2020-06-05 14:08:46 +03:00
ʈᵃᵢ
619fbc9557 fix: remove -1,-1 from owners request in charts, dashboards list and propertiesModal (#9989) 2020-06-04 15:31:42 -07:00
ʈᵃᵢ
d187d2887e fix: fetch all owners for dashboard, chart listview filters and properties modal (#9784) 2020-06-03 19:57:03 -07:00
Michael Joseph Rosenthal
3fd6e0630e fix #8302, disabling save button when can_add: false, can_overwrite: false (#9456) 2020-06-02 23:20:52 -07:00
Ville Brofeldt
fc92692f49 feat: implement new version of word cloud (#9962) 2020-06-02 19:28:58 +03:00
Ville Brofeldt
38a6bd79da feat: expand new chart data endpoint coverage (#9903)
* feat: implement new chart API for additional components

* Fix python tests

* Fix tests

* Fix lint

* fix camel case error in requestParams

* lint

* fix samples row limit

* Add samples row limit to config

* remove unnecessary code

* lint

* Address review comments
2020-06-02 10:47:28 +03:00
Grace Guo
5324e25328 [filter_box] disable instant_filtering by defult (#9952) 2020-05-31 22:12:04 -07:00
Jesse Yang
359ea8825d fix(react-select): FilterBox focus event and adhoc filter popup height (#9933)
* fix(react-select): FilterBox focus event and adhoc filter popup height

* Fix flacky cypress test

* Use focus instead of click
2020-05-27 15:15:32 -07:00
Ville Brofeldt
1b72907b18 Revert "feat: bump superset-ui and implement queryFields in formData (#9908)" (#9931)
This reverts commit 2c97e72959.
2020-05-27 22:50:14 +03:00
Phillip Kelley-Dotson
e0c3da5df1 feat: paired t testchart control migration (#9916)
* cherry pick

* update package
2020-05-26 14:11:03 -07:00
Phillip Kelley-Dotson
1fffa37e85 feat: remove para controls (#9851)
* remove para controls

* update package version
2020-05-26 12:37:33 -07:00
Ville Brofeldt
2c97e72959 feat: bump superset-ui and implement queryFields in formData (#9908)
* feat: Bump superset-ui packages for queryFields

* feat: Implement queryField in formData
2020-05-26 10:19:33 -07:00
Phillip Kelley-Dotson
333dc8529e feat: tablechart plugin controls migration (#9847)
* delete controls

* move columnoption to controls

* update package and remove columnoption

* fix: remove console and fix import

* fix: lint

* update version

* fix last rebase

* fix: lint:
2020-05-21 12:15:02 -07:00
Evan Rusackas
428ad70aac feat: Adding Emotion ThemeProviders for all React apps (#9853)
* bumping style package (now with typography styles!)

* ThemeProvider ALL the things!

* package lock

* linting

* no need to parseInt here anymore, the values are numeric now.
2020-05-20 12:43:02 -07:00
David Aaron Suddjian
f076485fd7 upgrade plugins, remove unnecessary code (#9848) 2020-05-20 12:41:12 -07:00
Ville Brofeldt
a43a1d6303 feat: Add new result formats and types to chart data API (#9841)
* feat: Add new result formats and types to chart data API

* lint

* Linting

* Add language to query payload

* Fix tests

* simplify tests
2020-05-20 21:36:14 +03:00
Phillip Kelley-Dotson
1a775e2612 feat: markupchart plugin controls migration (#9806)
* remove shims and controls

* update chart version

Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-19 23:04:20 -07:00
Jesse Yang
81ab8dd8b4 feat: upgrade react-select and make multi-select sortable (#9628)
* feat: upgrade react-select v1.3.0 to v3.1.0

Upgrade `react-select`, replace `react-virtualized-select` with a custom
solution implemented with `react-window`.

Future plans include deprecate `react-virtualized` used in other places, too.

Migrate all react-select related components to `src/Components/Select`.

* Fix new list view

* Fix tests

* Address PR comments

* Fix a flacky Cypress test

* Adjust styles for Select in CRUD ListView

* Fix loadOptions for owners select in chart PropertiesModal

TODO: add typing support for AsyncSelect props.

* Address PR comments; allow isMulti in SelectControl, too

* Clean up NaN in table filter values

* Fix flacky test
2020-05-19 16:59:49 -07:00
Grace Guo
5ca6ed716f [explore view] inline edit slice name should not overwrite (#9817) 2020-05-18 22:53:29 -07:00
Grace Guo
d96bb874f2 fix: [filter_box] fix 2 issues in single value filter_box (#9829)
* fix: [filter_box] fix 2 issues in single value filter_box

* add unit test

* add fix per comments
2020-05-18 21:25:10 -07:00
Phillip Kelley-Dotson
38c57f45ac feat: partitionchart controls migration (#9768)
* fix lint error

* fix: import lint error

* pull in latests code

* delete control from plugin registry

* fixing again...

* another fix with rebase...

* commit change

* update packages and fix test

* fix: add ignore to lint error

* fix mr

* fix lint

* fix imports

Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-18 12:48:51 -07:00
Ville Brofeldt
7a95c52d61 refactor: simplify getExploreUrl functions (#9831)
* remove payload from return signature

* Rename function and fix tests

* Lint

* fix tests

* Move useLegacyApi inquiry to exploreUtils
2020-05-18 19:19:05 +03:00
David Aaron Suddjian
34df11a61c upgrade migrated plugins, remove controlPanel configs (#9774)
* remove migrated plugins

* remove chord stuff

* upgrade plugin packages

* update package lock
2020-05-14 17:06:49 -07:00
David Aaron Suddjian
3a213916c4 use the builtin calendar control panel (#9771) 2020-05-07 21:15:03 -07:00
David Aaron Suddjian
8a49c69f38 use word cloud's built in control panel (#9770) 2020-05-07 18:28:48 -07:00
Jesse Yang
13c5b133a9 test(frontend): use absolute path for src imports (#9761)
* test(frontend): use absolute path for src imports

* Upgrade prettier, fix eslint
2020-05-07 14:18:10 -07:00
Evan Rusackas
b93bf05bbd fix: removing controls from incubator-superset that are now in the plugin (#9758) 2020-05-06 17:29:49 -07:00
Maxime Beauchemin
9aabafe9fe fix: adhoc filter 'equals' doesn't let you save (#9652)
When altering a filter, when using `equals` or `does not equals`,
the save button is disabled even when it should be enalbed.
2020-05-06 08:38:10 -07:00
Ville Brofeldt
5485eb993c feat: Add controlGroups to formData (#9740) 2020-05-06 14:53:13 +03:00
Maxime Beauchemin
67d8b634b8 fix: autocomplete search in AdhocFilter operator dropdown (#9654)
Searching for 'equ' in AdhocFilter's operator dropdown doesn't find the
options who's label contain that substring.

I'd write a unit test but it's pretty tricky.
2020-05-05 21:43:33 -07:00
David Aaron Suddjian
9d3da79c4b migrate bignumber to use builtin controls (#9707)
* migrate bignumber to use builtin controls

* install @babel/compat-data
2020-04-30 19:27:44 -07:00
Grace Guo
43eec67291 [table editor] hide Edit Datasource option when no onDatasourceSave (#9706)
* [table editor] hide Edit Datasource option when no onDatasourceSave

* add !! operator to get truthiness
2020-04-30 17:32:01 -07:00
Grace Guo
52a0afe241 [fix] reduce table metadata fetch for latest_partition check (#9685)
* [fix] reduce table metadata fetch for latest_partition check

* fix review comment
2020-04-29 11:40:29 -07:00
Grace Guo
735dcd2002 [explore view] add partition as adhoc filter option (#9637)
* [explore view] add partition as adhoc option

* use adhocFilter Simple Tab

* simplify conditional check for custom adhoc filter operator

* add simple unit tests
2020-04-28 23:09:44 -07:00
Evan Rusackas
5e4c291913 Controls cleanup pass (#9578)
* migrating date_filter

* normalized control

* filter_configs control

* column_collection control

* time_range_endpoints control

* time_range_fixed control

* url_params control

* cache_timeout control

* annotation_layers control

* color control unused?

* linters rule 🤘

* this should have been deleted earlier

* global_opacity, mapbox_label, mapbox_style, viewport_zoom

* linting

* comparison_type

* contribution control

* log_scale

* show_values

* table_filter

* pandas_aggfunc

* code control

* formatSelectOptions import

* lint

* markup_type control

* lintage

* date_time_format control, linting

* url control, test mods

* min_periods control

* rolling_periods

* rolling_type

* missing lib

* order_desc

* number_format

* link_length

* all_columns_y

* all_columns_x

* normalize_across, select_country, all_columns

* fixing test

* linter-caught dependencies

* waiting

* wait longer!

* utilizing tabOverride for Analytics

* tabOverride for Annotations and Layers
2020-04-24 16:12:26 -07:00
Jesse Yang
7b33d5457b fix: change number format to original value to "~g" (#9608)
Originally it uses " ", which do give the original value, but will
not work when the `getNumberFormatter` in `superset-ui/number-format`
is called for the second time. Because the format will successfully
register as "" [1], but cannot be obtained again via `registry.get()`[2].

[1]: 44ad062dd0/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts (L30)
[2]: dc804b7a70/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts (L36)
2020-04-22 10:07:37 -07:00
Jesse Yang
2b957a2c1e Add raw number/integer option to d3 number formats (#9562) 2020-04-20 21:31:47 -07:00
Evan Rusackas
ea27e68ee1 Migrating shared NVD3 controls to new module (#9525)
* proto module

* caught a missed 'freq' unique control

* line_interpolation

* linting

* showLegend

* show_controls

* xAxisLabel

* bottomMargin

* x_ticks_layout

* missed one

* x_axis_format

* yLogScale

* y_axis_bounds

* linting

* nixing yarn lock

* x_axis_showminmax

* xAxisShowminmax control

* richTooltip

* linting, syntax fix

* show_bar_value, bar_stacked

* reduceXticks, yaxislabel

* left_margin, max_bubble_size, y_axis_showminmax

* show_labels

* send_time_range, y_axis_2_format, show_markers, order_bars

* nixing commented imports

* fake controls

* looking up actual controls for comparison.

* adding key to test setup

* controls inventory

* apache junk

* lint 

* ignore null controls

* fixing goofed up spread operation for xAxisFormat config

* lint 

* fixes for errors caused by <hr> element in filterbox controls

* fixing filter controls for 'druid_time_origin', 'granularity', 'granularity_sqla', 'time_grain_sqla'

* getControlsInventory -> getControlsForVizType

* further renaming of chartControlsInventory - > getControlsForVizType

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
2020-04-17 11:40:50 -07:00
Ville Brofeldt
427d2a05e5 chore: Migrate unique FilterBox controls from controls.jsx (#9566)
* Migrate FilterBox controls from controls.jsx

* Linting
2020-04-17 12:20:32 +03:00
Evan Rusackas
6270f7dc24 Importing validators module from superset-ui (#9465)
* importing... this is going to break CI, but there it is.

* adding validator package.

* pluralization - maybe it should be plural, but whatevs

* updating validators to match new exports

* removing old validators

* lintage 

* validateNumeric -> validateNumber

* using legacyValidateInteger, legacyValidateNumber

* linting 

* removing extraneous package lock file
2020-04-14 12:00:25 -07:00
Evan Rusackas
f29d0fd9f2 control to turn off table bar-chart backgrounds (#9500)
* control to turn off table bar-chart backgrounds

* flipping enable to disable, to support existing charts

* lint 

* Turn ON to enable (reversing logic)

* bumping big number chart

* ling 
2020-04-13 16:53:50 -07:00
Ville Brofeldt
5ec0192bcc fix: add lineWidth to Shared_DeckGL.jsx (#9496)
* fix: add lineWidth to Shared_DeckGL.jsx

* linting
2020-04-09 12:47:50 -07:00
Jianchao Yang
5565895819 fix: add explore control tabOverride at the section level (#9495) 2020-04-08 18:26:53 -07:00
David Aaron Suddjian
5e535062da Filter owners select by text input (#9337)
* filter owners select by text input

* use rison

* fix backend owners filter logic

* use fullname, not username on owners inputs

* fix some tests

* fixing tests

* deterministic tests

* appease linter

* add back search by username

* more comprehensive filter test

* add clarifying text

* formatting...
2020-04-07 09:09:02 -07:00
Evan Rusackas
b6bca9f137 Migrating shared DeckGL controls (#9455)
* Missed a couple unique controls!

* new shared module, with filter_nulls export.

* autozoom

* dimension

* nixing unneeded import

* stroke_width

* js_columns

* remaining js_* controls

* cleaning up unused stuff

* legend_format

* exports for prior commit

* legend_position

* line_column

* fill_color_picker

* filled, stroked, stroke_color_picker

* grid_size, extruded

* ... more gridsize

* viewport

* point_radius_fixed, spatial

* multiplier, line_type, line_width

* reverse_long_lat

* lint 
2020-04-06 18:37:25 -07:00
Evan Rusackas
1cdfb829d7 Eslint prefer-object-spread (#9466)
* The rule.

* The result
2020-04-03 17:05:16 -07:00
Evan Rusackas
265a2feb29 Migrating NVD3 Area's stacked_style config (#9454)
* Migrating NVD3 Area's stacked_style config

* test mods

* lint

* nonsense change

* undoing nonsense. Come on GitHub, WORK.
2020-04-03 12:50:28 -07:00
Evan Rusackas
cd572334c9 Migrating unique NVD3 viz controls (#9445)
* donut control

* labels outside

* linting

* x_log_scale, pie_label_type

* linting

* line_charts, line_charts_2

* marker_labels

* marker_line_labels, marker_lines, markers

* prefix_metric_with_slice_name, range_labels, ranges

* stacked_style

* Revert "stacked_style"

This reverts commit aae2d418b8f1950fbe32248b62e50a12fbf186bd.

* stacked_style take 2...

* Revert "stacked_style take 2..."

This reverts commit 38b7155f50143684c92a67b2a9fa16f65c269d35.
2020-04-03 12:50:07 -07:00
Evan Rusackas
9e79cf37f8 Migrating unique bigNumber(total) controls (#9440)
* migrating options controls

* lint 

* baby steps...

* shared BigNumber controls file

* capitalization matters
2020-04-02 10:52:32 -07:00
Evan Rusackas
c003189d0d migrating unique controls (#9446) 2020-04-02 09:26:52 -07:00