Commit Graph

5421 Commits

Author SHA1 Message Date
Ville Brofeldt
71fc7cbfcf fix(sql-lab): relax column name restrictions (#10816) 2020-09-16 09:34:06 +03:00
Jesse Yang
30efcc964d fix: ColorSchemeControl should not use CreatableSelect (#10814)
* fix: ColorSchemeControl should not be CreatableSelect

   Currently if you type to search in ColorSchemeControl it crashes the
whole page.

* Make it possible to filter by label

* Fix ColorSchemeControl unit test
2020-09-16 09:33:40 +03:00
gtg472b
698bad187f Fix: Include RLS filters for cache keys (#10805)
* Fix: Include RLS filters for cache keys

This fix makes sure that RLS filters are searched for templatable jinja content, ensuring cached visualizations aren't shown to the wrong user.

* Fix: Include RLS filters for cache keys

This fix makes sure that RLS filters are searched for templatable jinja content, ensuring cached visualizations aren't shown to the wrong user.

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-09-16 09:30:11 +03:00
Ville Brofeldt
8ecfb18ac7 fix: pivot table timestamp grouping (#10774)
* fix: pivot table timestamp grouping

* address comments
2020-09-16 09:30:07 +03:00
chuancy
8fb6c8361c fix(db-engine-spec): execute oracle DML statement bug in sqllab (#10706)
* fix execute oracle DML statement bug in sqllab

when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. 

Refer https://www.python.org/dev/peps/pep-0249/, superset old version use
`cursor.description` ,because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet.

* Apply suggestions from code review

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update oracle.py

* Update oracle.py

* Update oracle.py

* Apply suggestions from code review

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update oracle.py

* Update superset/db_engine_specs/oracle.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-09-16 09:30:01 +03:00
Ville Brofeldt
4d73490fa3 fix(jinja): extract form_data from json body (#10684)
* fix(jinja): extract form_data from json body

* add test

* disable test for presto
2020-09-16 09:29:44 +03:00
Ville Brofeldt
fa9a558354 refactor(database): use SupersetResultSet on SqlaTable.get_df() (#10707)
* refactor(database): use SupersetResultSet on SqlaTable.get_df()

* lint

* change cypress test
2020-09-16 09:28:31 +03:00
Ville Brofeldt
421694bfa8 fix(filter-box): don't add empty filter to filtersChoices (#10687)
* fix(filter-box): don't add empty filter to filtersChoices

* add test
2020-09-16 09:28:23 +03:00
Ville Brofeldt
091c6ae316 feat(row-level-security): add hook for customizing form dropdowns (#10683) 2020-09-16 09:28:17 +03:00
Maxime Beauchemin
25d9fb7544 fix: dedup groupby in viz.py while preserving order (#10633) 2020-09-16 09:27:39 +03:00
Ville Brofeldt
029a70b8b9 feat(viz-plugins): add date formatting to pivot-table (#10637)
* feat: make pivot table dates formattable

* Bump npm packages
2020-09-16 09:19:40 +03:00
Cory Zue
fc94d74aed improve documentation for country maps (#10621) 2020-09-16 09:19:36 +03:00
Ville Brofeldt
d06e023d88 fix: show error if rolling window returns empty df (#10572)
* fix: show error if rolling window returns empty df

* add test
2020-09-16 09:19:27 +03:00
Daniel Vaz Gaspar
f3bf6cebb7 fix: dataset delete and perm delete (#10578) 2020-09-16 09:18:42 +03:00
Daniel Vaz Gaspar
92b3f88b1a fix: disable false positive error (#10576) 2020-09-16 09:18:28 +03:00
Jesse Yang
820d07d6cf fix(dashboard): add animation state to fix tab switch re-renders (#10475) 2020-09-16 09:18:15 +03:00
Jesse Yang
3aadbc4fde fix: table viz query mode switch not working (#10552) 2020-09-16 09:18:09 +03:00
Erik Ritter
3293ef4b6b fix: embedded chart height (#10551) 2020-09-16 09:18:00 +03:00
Ville Brofeldt
ebb3307c1d fix: handle query exceptions gracefully (#10548)
* fix: handle query exceptions gracefully

* add more recasts

* add test

* disable test for presto

* switch to SQLA error
2020-09-16 09:17:54 +03:00
Jesse Yang
3b4882d836 bugfix: table chart query mode initial value (#10544) 2020-09-16 09:17:49 +03:00
Ville Brofeldt
bc80029f15 fix: remove unnecessary exception when exploring non-legacy viz plugins (#10538)
* fix: remove unnecessary exception when exploring non-legacy viz plugins

* lint
2020-09-16 09:17:44 +03:00
Daniel Vaz Gaspar
fb60d302c2 fix(log): don't log exceptions on test connection (#10522)
* fix(log): don't log exceptions on test connection

* fix lint
2020-09-16 09:17:39 +03:00
Jason Davis
13928fcf2d feat: make screenshot timeout configurable (#10517)
* made screenshot timeout configurable

* added default value to config and refractored use

* black

* updated config comment

* moves config variables to thumbnail section

Co-authored-by: Jason Davis <@dropbox.com>
2020-09-16 09:17:29 +03:00
Moriah Kreeger
1fb14e81f7 fix: update time range select tooltip (#10458) 2020-09-16 09:17:14 +03:00
Ville Brofeldt
ddac4b8838 fix: support non-string groupbys for pie chart (#10493)
* chore: add unit tests to pie chart

* refine logic for floats and nans and add more tests
2020-09-16 09:17:05 +03:00
Daniel Vaz Gaspar
024ef9a9e3 fix(log): log endpoint authentication (#10435)
* fix(log): log crashes if expired or not authenticated

* add auth to log endpoint
2020-09-16 09:16:58 +03:00
Stuart Hu
9c62eb2a7b update code (#10430)
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
2020-09-16 09:16:52 +03:00
Ville Brofeldt
6a85a341ad fix: pie chart multiple groupbys (#10391) 2020-09-16 09:16:45 +03:00
Ville Brofeldt
fa787d2de4 bump version and update changelog 0.37.1rc1 0.37.1 2020-09-06 13:41:57 +03:00
Daniel Vaz Gaspar
a72903cb92 security: disallow uuid package on jinja1 (#10794)
* fix: disallow uuid package on jinja2

* update UPDATING.md

* Update UPDATING.md

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-09-05 16:54:09 +03:00
Ville Brofeldt
0dbc1dbb9a add changelog entries 0.37.0rc4 0.37.0 2020-08-01 10:01:07 +03:00
pphszx
6d07273360 fix: excel sheet upload is not working (#10450)
* remove conflicts with csv upload

* revert StringField

* change description

* remove redundant space

* apply string approach
2020-07-29 10:21:22 +03:00
Ville Brofeldt
0f3670e1af feat: support non-numeric columns in pivot table (#10389)
* fix: support non-numeric columns in pivot table

* bump package and add unit tests

* mypy
2020-07-28 10:59:12 +03:00
Jesse Yang
bde453be79 fix(dashboard): chart rerender when switching tabs (#10432) 2020-07-27 11:53:00 +03:00
Ville Brofeldt
7b6f88a272 fix: incorrect filter operator emitted by Filter Box (#10421)
* fix: equals operator in filter box

* fix time range endpoint schema

* fix test

* bump packages

* fix tests

* lint
2020-07-26 14:50:06 +03:00
Ville Brofeldt
f908770dbc fix: bump pivot-table and rose (#10400) 2020-07-26 14:49:48 +03:00
Ville Brofeldt
1fc06a7443 fix: treemap template literal (#10382) 2020-07-26 14:47:46 +03:00
Daniel Vaz Gaspar
070dd5359c fix: group by with timestamp granularity (#10344)
* fix, group by with timestamp granularity

* fix, bug found by mypy

* lint

* comment

* Following ville's solution

* lint and comments
2020-07-26 14:30:35 +03:00
Daniel Vaz Gaspar
f13629abd5 fix: modified by column on charts and dashboards (#10340) 2020-07-26 14:30:09 +03:00
Ville Brofeldt
c74acdc381 Add changelog 0.37.0rc3 2020-07-21 08:42:45 +03:00
Ville Brofeldt
5b4277e4fc fix: extra filters for chart data endpoint (#10359)
* fix: extra filters

* fix old test and add new test

* add test for null filter value

* leave lowercase until all operators are fully uppercased

* bump packages

* rename test
2020-07-21 08:27:55 +03:00
Bogdan
e2690f0802 Pin slack client, breaking change (#10345)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-07-21 08:27:05 +03:00
Ville Brofeldt
d9ec47bc63 chore: add cherries to CHANGELOG.md 0.37.0rc2 2020-07-16 11:53:01 +03:00
Ville Brofeldt
3f284eaa09 fix: make __time an ok column name in SQL Lab (#10336) 2020-07-16 11:20:10 +03:00
Jesse Yang
08d43b1515 fix(table-viz): value "undefined" for column.name (#10325)
Bump table viz plugin to fix a bug: apache-superset/superset-ui#686
2020-07-16 09:15:25 +03:00
Daniel Vaz Gaspar
c57df314d7 fix: humanised changed on UTC on dashboards and charts (#10321)
* fix: API marshmallow3 drop utc for naive datetime fields

* fix: API marshmallow3 drop utc for naive datetime fields

* fix, tests

* isort and test

* black

* add and fix test

* fix comment
2020-07-16 09:15:12 +03:00
Erik Ritter
2f2fb47721 chore: type welcome (#10317) 2020-07-16 09:14:55 +03:00
Erik Ritter
9f0d456b6a chore: add typing to more sqllab components (#10278) 2020-07-16 09:14:17 +03:00
Erik Ritter
2631b3882e chore: add typing to profile (#10282) 2020-07-16 09:12:40 +03:00
Daniel Vaz Gaspar
791d787256 fix: Bump FAB to 3.0.1 fix superset init (#10310) 2020-07-14 19:13:25 +03:00