Commit Graph

11828 Commits

Author SHA1 Message Date
Antonio Rivero Martinez
8a57a71bed fix(sql lab): Save Dataset Modal Autocomplete should display list when overwritting (#20512)
* Save Dataset Modal:

- Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app
- Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting
- We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected
- Updated tests

* Save Dataset Modal:

- Update missing test for DatasourceControl

* Save Dataset Modal:

- Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application

* Save Dataset Modal:

- Remove unused comment

* Save Dataset Modal:

- Add getPopupContainer as prop for Select component

* Save Dataset Modal:

- Add tests for our new getPopupContainer prop in Select component. So if passed it gets called.

* Save Dataset Modal:

- use lowercased property when calling post form data

* Save Dataset Modal:

- Update tests so there is no need to define a null returning func

* Save Dataset Modal:

- Including getPopupContainer from PickedSelectProps instead
- Updating definition in SelectFilterPlugin
2022-07-01 14:40:13 -06:00
Lily Kuang
2389871556 feat: add extension point to the top of welcome page (#20575)
* welcome top extension

* show database modal

* add test

* Delete lines.svg

* rename to banner

* remove lines

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-07-01 12:21:13 -07:00
David Aaron Suddjian
7f70de30fb one action, one file (#20554) 2022-07-01 11:18:04 -07:00
nisheldo
7275805e95 chore: updating python docker image to 3.8.13 (#20550) 2022-07-01 11:16:17 -07:00
Yongjie Zhao
b870a21eaa refactor: remove unused flatten function (#20582) 2022-07-01 19:17:55 +08:00
Yongjie Zhao
290b89c7b4 feat: apply standardized form data to deckgl (#20579) 2022-07-01 14:51:59 +08:00
Cody Leff
b99482dfb1 Try making skipped Cypress test less flaky and un-skip. (#20568) 2022-06-30 16:30:32 -06:00
Evan Rusackas
ac8e502228 fix: Respecting max/min opacities, and adding tests. (#20555)
* Respecting max/min opacities, and adding tests.

* revising tests

* Adding missing test case for maximum coverage :)

* removing unnecessary logic and test

* adding another unit test for (hopefully) full coverage.

* no more ternary operator

* New approach with Math.min  - take THAT codecov.

* one more stab at making codecov happy... ignoring the file next.

* lint fixes
2022-06-30 16:09:03 -06:00
Evan Rusackas
f5f8ddec3e Revert "feat(plugin-chart-echarts): Support stacking negative and positive values (#20408)" (#20571)
This reverts commit c959d92dd1.
2022-06-30 13:52:43 -06:00
Kamil Gabryjelski
b30f6a5db1 chore(explore): Get Explore data from endpoint instead of bootstrap_data (#20519)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fix dashboard id autofill

* Fix lint

* Fix test
2022-06-30 21:06:51 +02:00
Sam Faber-Manning
f2af81b1c7 feat: add extension point to the right side of the menu bar (#20514)
* add setupExtensions

* add 'navbar.right' extension to registry

* add test for navbar.right extension point

* rename MenuRight -> RightMenu

* lint
2022-06-30 11:43:20 -06:00
Cody Leff
edb1383bf8 chore(dashboard): Resolve form_data vs. formData in dashboard redux state 2022-06-30 18:49:18 +08:00
Stephen Liu
932e304ffb fix(database-modal): forms in database modal will be effected by external form values (#20487) 2022-06-30 16:21:33 +08:00
Stephen Liu
24a53c38c6 fix(big-number): big number gets cut off on a Dashboard (#20488) 2022-06-30 16:19:38 +08:00
yourssvk
90d486a643 fix: SQL Lab cancel query in Redshift database connection does not wo… (#16326)
* fix: SQL Lab cancel query in Redshift database connection does not work #16325


Co-authored-by: Venkata Krishnan Somasundaram <venkata_cred@Venkatas-MacBook-Pro.local>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-06-29 11:12:59 -07:00
Jesse Yang
cadd259788 feat: save active tabs in dashboard permalink (#19983) 2022-06-29 09:43:52 -07:00
Diego Medina
c5d3678a31 fix: Unable to download the Dashboard as image in case there's an image added through Markdown (#20362)
* fix: Unable to download the Dashboard as image in case there's an image added through Markdown

* licence
2022-06-30 00:22:49 +08:00
Michael S. Molina
cb3cd41dcd fix: Removes psycopg2 as a required dependency (#20543)
* fix: Removes psycopg2 as a required dependency

* Disables lint warning
2022-06-29 09:22:13 -03:00
Michael S. Molina
4eb2a6f4a3 chore: Updates metrics and columns font-size (#20526) 2022-06-29 08:05:00 -03:00
Yongjie Zhao
de524bc59f feat: apply standardized form data to tier 2 charts (#20530) 2022-06-29 16:27:31 +08:00
Yongjie Zhao
927d066f70 chore: move isAdhocColumn from controls to core (#20529)
* chore: move isAdhocColumn to superset-ui/core

* ut
2022-06-29 13:09:44 +08:00
Antonio Rivero Martinez
850f5fa136 fix(database-modal): Refresh Data when importing (#20523)
* Database Modal:

- Add missing invocation to onDatabaseAdd after importing DB from file
- Add keys to our IconButtons

* Database Modal:

- Reduce if clause so it's more concise
2022-06-28 16:13:09 -06:00
Alex Lauderbaugh
93fbfe9d28 Updated copy in chart drop down to "View as table" (#20486) 2022-06-28 14:49:13 -06:00
Kamil Gabryjelski
e12ee59b13 feat(explore): Apply denormalization to tier 2 charts form data (#20524)
* feat(explore): Denormalize form data in Calendar Heatmap

* feat(explore): Denormalize form data in Bubble

* feat(explore): Denormalize form data in Chord

* Dimensions -> Dimension for single selection

* feat(explore): Denormalize form data in Country Map

* feat(explore): Denormalize form data in Heatmap

* feat(explore): Denormalize form data in Histogram

* feat(explore): Denormalize form data in Handlebars

* feat(explore): Denormalize form data in Percent Change

* Use new standardized form data interface
2022-06-28 20:21:36 +02:00
Yongjie Zhao
c348a095b9 refactor(standardized form data): refine interface and improve code smells (#20518) 2022-06-28 21:09:42 +08:00
smileydev
23e62d3782 fix(db): Show the only db install guide when the db is already installed and error is existed while importing file. (#20442)
* fix(db): make to show the db error msg when db installed and error is exist

* fix(db): make to replace dbinstall str into showDbInstallInstructions
2022-06-28 20:53:02 +08:00
Saint
364bb7c639 chore: added new translations to the spanish language (#20427)
* Added new translations for Spanish Language - Specifically on the visualizations of Time-Series

* Chore: Added more translations to the Time-Series visualizations
2022-06-28 20:34:14 +08:00
Cody Leff
280b4be449 feat(vizgallery): Double-click viz type to submit form (#20513)
* Make double-clicking on viz type submit the form.

* Add tests.
2022-06-28 09:27:04 -03:00
Michael S. Molina
480ee38917 chore: Updates control panels font size in Explore (#20510) 2022-06-28 09:16:59 -03:00
Susur
c4d2238a16 feat: add Spark Sql DB engine spec and support Spark 3.x (#20462)
* add apache spark3

* add Spark DB engine spec

* rebase secret key

* modify License error

* rebase databricks

* modify code style

* black code style

Co-authored-by: kai.he01 <kai.he01@idiaoyan.com>
2022-06-27 15:50:35 -07:00
Elizabeth Thompson
ddcef70fbd change permissions on action (#20496) 2022-06-27 15:22:43 -07:00
John Bodley
f29cde2269 refactor: Minor optimization for updating DatasetDAO columns and metrics (#20473)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-25 14:31:04 -07:00
John Bodley
3483446c28 refactor: Cleanup user get_id/get_user_id (#20492)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-24 17:57:04 -07:00
Daniel Vaz Gaspar
c56e37cda2 fix: bump FAB to 4.1.2 (#20483) 2022-06-24 19:13:48 +01:00
Diego
bcc51400bd docs(contribute): update compatible Python versions in local environment setup instructions (#20260)
* Remove incompatible Python 3.7 from local env setup docs

* Ensure Python 3.8 or 3.9

Co-authored-by: Diego Martin <diego.martin@indigitall.com>
2022-06-24 10:59:59 -07:00
Multazim Deshmukh
5a2abfab65 fix: correction from mmsql to mssql in setup.py (#20493)
Co-authored-by: Multazim Deshmukh <multazim.deshmukh@morningstar.com>
2022-06-24 10:43:16 -07:00
Yongjie Zhao
bbbe102887 feat(standardized form data): keep all columns and metrics (#20377) 2022-06-24 21:46:25 +08:00
Kamil Gabryjelski
c7f1c7d5bd chore: Restructure explore redux state (#20448)
* chore: Restructure explore redux state

* fixes

* fix tests

* add new tests

* Fix type

* Address comments

* Fix bug

* Fix import

* Add new test

* Move unsaved chart id to a constant

* Add todo
2022-06-24 15:26:07 +02:00
Michael S. Molina
20163361b9 feat: Adds the /explore endpoint to the v1 API (#20399)
* feat: Adds the /explore endpoint to the v1 API

* Fixes pylint errors

* Fixes tests

* Changes the tests logic

* Removes ABC reference

* Improves indentation

* Addresses review comments

* Rebases code

* Improves dataset and slice assertions

* Fixes tests

* Removes schema and table name assertions

* Removes fixed IDs

* Fixes datasource ID
2022-06-24 08:23:30 -03:00
Elizabeth Thompson
44f0b511dd remove autoflush for queries during dual write (#20460) 2022-06-23 14:50:30 -07:00
John Bodley
661ab35bd0 fix: Re-add filter-box time granularity/column (#20485)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 12:42:40 -07:00
Daniel Vaz Gaspar
b33c23ef25 fix: migration revision order (#20484) 2022-06-23 18:42:35 +01:00
Stephen Liu
aa4068048a fix(docs): prevent some symbols from being copied with (#20480) 2022-06-23 13:11:42 -04:00
stevetracvc
a45d011e74 fix: issue with sorting by multiple columns in a table (#19920)
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
2022-06-23 08:39:46 -03:00
John Bodley
f5cb23e0a3 fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL (#20385)
* fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL

* Update 2022-06-14_15-28_e09b4ae78457_resize_key_value_blob.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 08:38:33 -03:00
Diego Medina
4dc30441b7 fix: alert & reports active toggle optimistic update (#20402) 2022-06-23 08:33:54 -03:00
Michael S. Molina
a169b60712 fix: Changes the return type of get_permissions to be JSON friendly (#20472)
* fix: Changes the return type of get_permissions to be JSON friendly

* Removes dangling comma

* Removes unused import

* Fixes typing errors
2022-06-22 15:28:59 -06:00
AAfghahi
2c16be42e1 async queries limit bug (#20468) 2022-06-22 16:21:34 -04:00
Eric Briscoe
9f9aae49c9 chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
cccs-Dustin
daded10992 feat(SQL Lab): Make SQL Lab explore use the default viz from the config file (#20056)
* Modified SQL Lab so it uses the default viz to explore a new dataset with

* Added a comment to the config file

* Remove trailing whitespace

* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz

* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'

* Will only pop 'selectedColumns' out of 'form_data' if it is present

* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
2022-06-22 11:33:44 -06:00